diff options
| author | Egor Yusov <egor.yusov@gmail.com> | 2018-12-16 19:46:29 +0000 |
|---|---|---|
| committer | Egor Yusov <egor.yusov@gmail.com> | 2018-12-16 19:46:29 +0000 |
| commit | 19db0a0e7cce02ce2dc55b37c1b36ad90889e429 (patch) | |
| tree | 005b8a9554bfdd1b362feb9bdcd9a3e263085324 /Graphics | |
| parent | Updated release history (better wording) (diff) | |
| download | DiligentCore-19db0a0e7cce02ce2dc55b37c1b36ad90889e429.tar.gz DiligentCore-19db0a0e7cce02ce2dc55b37c1b36ad90889e429.zip | |
Fixed a number of minor issues revealed by code analysis
Diffstat (limited to 'Graphics')
3 files changed, 21 insertions, 19 deletions
diff --git a/Graphics/GraphicsAccessories/interface/ResourceReleaseQueue.h b/Graphics/GraphicsAccessories/interface/ResourceReleaseQueue.h index 1852fe6e..13b22ad6 100644 --- a/Graphics/GraphicsAccessories/interface/ResourceReleaseQueue.h +++ b/Graphics/GraphicsAccessories/interface/ResourceReleaseQueue.h @@ -120,13 +120,13 @@ public: }; } - DynamicStaleResourceWrapper(DynamicStaleResourceWrapper&& rhs)noexcept : + DynamicStaleResourceWrapper(DynamicStaleResourceWrapper&& rhs) noexcept : m_pStaleResource(std::move(rhs.m_pStaleResource)) { rhs.m_pStaleResource = nullptr; } - DynamicStaleResourceWrapper (const DynamicStaleResourceWrapper& rhs)noexcept : + DynamicStaleResourceWrapper (const DynamicStaleResourceWrapper& rhs) noexcept : m_pStaleResource(rhs.m_pStaleResource) { } @@ -175,11 +175,11 @@ public: return StaticStaleResourceWrapper{std::move(Resource)}; } - StaticStaleResourceWrapper(StaticStaleResourceWrapper&& rhs)noexcept : + StaticStaleResourceWrapper(StaticStaleResourceWrapper&& rhs) noexcept : m_StaleResource(std::move(rhs.m_StaleResource)) {} - StaticStaleResourceWrapper& operator = (StaticStaleResourceWrapper&& rhs)noexcept + StaticStaleResourceWrapper& operator = (StaticStaleResourceWrapper&& rhs) noexcept { m_StaleResource = std::move(rhs.m_StaleResource); return *this; diff --git a/Graphics/GraphicsAccessories/interface/VariableSizeGPUAllocationsManager.h b/Graphics/GraphicsAccessories/interface/VariableSizeGPUAllocationsManager.h index 425bbd06..4ea7e814 100644 --- a/Graphics/GraphicsAccessories/interface/VariableSizeGPUAllocationsManager.h +++ b/Graphics/GraphicsAccessories/interface/VariableSizeGPUAllocationsManager.h @@ -61,7 +61,7 @@ namespace Diligent } // = default causes compiler error when instantiating std::vector::emplace_back() in Visual Studio 2015 (Version 14.0.23107.0 D14REL) - VariableSizeGPUAllocationsManager(VariableSizeGPUAllocationsManager&& rhs) : + VariableSizeGPUAllocationsManager(VariableSizeGPUAllocationsManager&& rhs) noexcept : VariableSizeAllocationsManager(std::move(rhs)), m_StaleAllocations(std::move(rhs.m_StaleAllocations)), m_StaleAllocationsSize(rhs.m_StaleAllocationsSize) diff --git a/Graphics/GraphicsEngine/interface/GraphicsTypes.h b/Graphics/GraphicsEngine/interface/GraphicsTypes.h index 16565ae0..d515b2a1 100644 --- a/Graphics/GraphicsEngine/interface/GraphicsTypes.h +++ b/Graphics/GraphicsEngine/interface/GraphicsTypes.h @@ -1519,32 +1519,34 @@ namespace Diligent Uint8 BlockHeight; /// Initializes the structure - explicit TextureFormatAttribs( const Char *_Name, + explicit TextureFormatAttribs( const Char* _Name, TEXTURE_FORMAT _Format, - Uint8 _ComponentSize, - Uint8 _NumComponents, + Uint8 _ComponentSize, + Uint8 _NumComponents, COMPONENT_TYPE _ComponentType, - bool _IsTypeless, - Uint8 _BlockWidth, - Uint8 _BlockHeight) : - Name(_Name), - Format(_Format), + bool _IsTypeless, + Uint8 _BlockWidth, + Uint8 _BlockHeight) : + Name (_Name), + Format (_Format), ComponentSize(_ComponentSize), NumComponents(_NumComponents), ComponentType(_ComponentType), - IsTypeless(_IsTypeless), - BlockWidth(_BlockWidth), - BlockHeight(_BlockHeight) + IsTypeless (_IsTypeless), + BlockWidth (_BlockWidth), + BlockHeight (_BlockHeight) { } TextureFormatAttribs() : - Name("TEX_FORMAT_UNKNOWN"), - Format(TEX_FORMAT_UNKNOWN), + Name ("TEX_FORMAT_UNKNOWN"), + Format (TEX_FORMAT_UNKNOWN), ComponentSize(0), NumComponents(0), ComponentType(COMPONENT_TYPE_UNDEFINED), - IsTypeless(false) + IsTypeless (false), + BlockWidth (0), + BlockHeight (0) {} }; |
