From a0488c54c6c5017c71198d8b13c9ed75894791de Mon Sep 17 00:00:00 2001 From: azhirnov Date: Wed, 16 Sep 2020 22:41:57 +0300 Subject: use NUM_SHADER_TYPES constant instead of magic number, use std::array instead of c-style array. --- .../GraphicsEngineOpenGL/include/GLPipelineResourceLayout.hpp | 11 +++++++---- Graphics/GraphicsEngineOpenGL/src/PipelineStateGLImpl.cpp | 2 +- 2 files changed, 8 insertions(+), 5 deletions(-) (limited to 'Graphics/GraphicsEngineOpenGL') diff --git a/Graphics/GraphicsEngineOpenGL/include/GLPipelineResourceLayout.hpp b/Graphics/GraphicsEngineOpenGL/include/GLPipelineResourceLayout.hpp index cf6a9e86..d3b11a18 100644 --- a/Graphics/GraphicsEngineOpenGL/include/GLPipelineResourceLayout.hpp +++ b/Graphics/GraphicsEngineOpenGL/include/GLPipelineResourceLayout.hpp @@ -82,7 +82,10 @@ class GLPipelineResourceLayout public: GLPipelineResourceLayout(IObject& Owner) : m_Owner(Owner) - {} + { + m_ProgramIndex.fill(-1); + } + ~GLPipelineResourceLayout(); // No copies, only moves are allowed @@ -328,9 +331,9 @@ private: /*34*/ OffsetType m_ImageOffset = 0; /*36*/ OffsetType m_StorageBufferOffset = 0; /*38*/ OffsetType m_VariableEndOffset = 0; -/*40*/ std::array m_ProgramIndex = {{-1, -1, -1, -1, -1, -1}}; -/*46*/ Uint8 m_NumPrograms = 0; -/*48*/ +/*40*/ std::array m_ProgramIndex; +/*48*/ Uint8 m_NumPrograms = 0; +/*49*/ // clang-format on template OffsetType GetResourceOffset() const; diff --git a/Graphics/GraphicsEngineOpenGL/src/PipelineStateGLImpl.cpp b/Graphics/GraphicsEngineOpenGL/src/PipelineStateGLImpl.cpp index bb2201d1..1cc0a1ef 100644 --- a/Graphics/GraphicsEngineOpenGL/src/PipelineStateGLImpl.cpp +++ b/Graphics/GraphicsEngineOpenGL/src/PipelineStateGLImpl.cpp @@ -102,7 +102,7 @@ PipelineStateGLImpl::PipelineStateGLImpl(IReferenceCounters* pRefCoun } else { - m_GLPrograms.emplace_back(ShaderGLImpl::LinkProgram(m_ppShaders, m_NumShaders, false)); + m_GLPrograms.emplace_back(ShaderGLImpl::LinkProgram(m_ppShaders.data(), m_NumShaders, false)); m_ProgramResources.resize(1); SHADER_TYPE ShaderStages = SHADER_TYPE_UNKNOWN; for (Uint32 i = 0; i < m_NumShaders; ++i) -- cgit v1.2.3