From 3ee898118ef4a0b7df203c59bd872d9df2158d93 Mon Sep 17 00:00:00 2001 From: Nathan Lee <2431820-nathanal@users.noreply.gitlab.com> Date: Sat, 8 Jun 2019 17:44:51 +1000 Subject: Stop crash when Text > Outermost element is active Fix https://gitlab.com/inkscape/inkscape/issues/289 --- src/ui/toolbar/text-toolbar.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/ui/toolbar/text-toolbar.cpp b/src/ui/toolbar/text-toolbar.cpp index a8604778a..b191385df 100644 --- a/src/ui/toolbar/text-toolbar.cpp +++ b/src/ui/toolbar/text-toolbar.cpp @@ -347,7 +347,7 @@ TextToolbar::TextToolbar(SPDesktop *desktop) _outer_style_item->set_icon_name(INKSCAPE_ICON("text_outer_style")); add(*_outer_style_item); _outer_style_item->signal_toggled().connect(sigc::mem_fun(*this, &TextToolbar::outer_style_changed)); - _outer_style_item->set_active(prefs->getBool("/tools/text/outer_style", false)); + // need to set_active status *after* a bunch of other widgets. See end of this function. } /* Font size */ @@ -736,6 +736,9 @@ TextToolbar::TextToolbar(SPDesktop *desktop) _direction_item->signal_changed_after().connect(sigc::mem_fun(*this, &TextToolbar::direction_changed)); } + // Text outer style (continued) + _outer_style_item->set_active(prefs->getBool("/tools/text/outer_style", false)); + show_all(); // Is this necessary to call? Shouldn't hurt. -- cgit v1.2.3