From 6acb5933067c98c1b3a6bce5b27596f4536762c6 Mon Sep 17 00:00:00 2001 From: Thomas Holder Date: Wed, 20 Nov 2019 14:26:06 +0100 Subject: fix PNG export dialog crash (heap-use-after-free) Possibly related to inbox#1185 --- src/ui/dialog/export.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/ui/dialog/export.cpp b/src/ui/dialog/export.cpp index 7b2f2628d..d684a2693 100644 --- a/src/ui/dialog/export.cpp +++ b/src/ui/dialog/export.cpp @@ -452,11 +452,11 @@ void Export::set_default_filename () { { SPDocument * doc = SP_ACTIVE_DOCUMENT; const gchar *uri = doc->getDocumentURI(); - const gchar *text_extension = get_file_save_extension (Inkscape::Extension::FILE_SAVE_METHOD_SAVE_AS).c_str(); + auto &&text_extension = get_file_save_extension(Inkscape::Extension::FILE_SAVE_METHOD_SAVE_AS); Inkscape::Extension::Output * oextension = nullptr; - if (text_extension != nullptr) { - oextension = dynamic_cast(Inkscape::Extension::db.get(text_extension)); + if (!text_extension.empty()) { + oextension = dynamic_cast(Inkscape::Extension::db.get(text_extension.c_str())); } if (oextension != nullptr) { -- cgit v1.2.3