From 79e894aec257c99bf0961d56750779d30561244f Mon Sep 17 00:00:00 2001 From: Thomas Holder Date: Sun, 30 Sep 2018 19:57:53 +0200 Subject: refactor: simplify loop --- src/ui/dialog/align-and-distribute.cpp | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/src/ui/dialog/align-and-distribute.cpp b/src/ui/dialog/align-and-distribute.cpp index c606f52bf..5bf437ca1 100644 --- a/src/ui/dialog/align-and-distribute.cpp +++ b/src/ui/dialog/align-and-distribute.cpp @@ -602,7 +602,6 @@ private : if (!selection) return; std::vector selected(selection->items().begin(), selection->items().end()); - if (selected.empty()) return; //Check 2 or more selected objects if (selected.size() < 2) return; @@ -621,20 +620,15 @@ private : } sort(selected.begin(),selected.end(),sort_compare); } - std::vector::iterator it(selected.begin()); - SPItem* item = *it; - Geom::Point p1 = item->getCenter(); - for (++it ;it != selected.end(); ++it) + + Geom::Point p1 = selected.back()->getCenter(); + for (SPItem *item : selected) { - item = *it; Geom::Point p2 = item->getCenter(); Geom::Point delta = p1 - p2; sp_item_move_rel(item,Geom::Translate(delta[Geom::X],delta[Geom::Y] )); p1 = p2; } - Geom::Point p2 = selected.front()->getCenter(); - Geom::Point delta = p1 - p2; - sp_item_move_rel(selected.front(),Geom::Translate(delta[Geom::X],delta[Geom::Y] )); // restore compensation setting prefs->setInt("/options/clonecompensation/value", saved_compensation); -- cgit v1.2.3