From a0c66f4d4f75ad8d2a29c95567d97e5f7a883205 Mon Sep 17 00:00:00 2001 From: "Johan B. C. Engelen" Date: Sun, 27 Oct 2013 20:04:05 +0100 Subject: fix warning and add comments about fixing code (bzr r12735) --- src/libavoid/connector.cpp | 4 +++- src/svg/svg-length.cpp | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/libavoid/connector.cpp b/src/libavoid/connector.cpp index cf8cfa11a..8dcb66f2d 100644 --- a/src/libavoid/connector.cpp +++ b/src/libavoid/connector.cpp @@ -1736,7 +1736,8 @@ CrossingsInfoPair countRealCrossings(Avoid::Polygon& poly, !reversedY); } else - { + { /// \todo FIXME: this whole branch was not doing anything + /* int turnDirA = vecDir(a0, a1, a2); int turnDirB = vecDir(b0, b1, b2); bool reversed = (side1 != -turnDirA); @@ -1761,6 +1762,7 @@ CrossingsInfoPair countRealCrossings(Avoid::Polygon& poly, } VertID vID(b1.id, true, b1.vn); //(*pointOrders)[b1].addPoints(&b1, &a1, reversed); + */ } } } diff --git a/src/svg/svg-length.cpp b/src/svg/svg-length.cpp index 6f1a88a58..b9e8e6340 100644 --- a/src/svg/svg-length.cpp +++ b/src/svg/svg-length.cpp @@ -65,6 +65,7 @@ unsigned int sp_svg_number_read_d(gchar const *str, double *val) } // TODO must add a buffer length parameter for safety: +// rewrite using std::string? static unsigned int sp_svg_number_write_ui(gchar *buf, unsigned int val) { unsigned int i = 0; @@ -81,6 +82,7 @@ static unsigned int sp_svg_number_write_ui(gchar *buf, unsigned int val) } // TODO unsafe code ingnoring bufLen +// rewrite using std::string? static unsigned int sp_svg_number_write_i(gchar *buf, int bufLen, int val) { int p = 0; @@ -98,6 +100,7 @@ static unsigned int sp_svg_number_write_i(gchar *buf, int bufLen, int val) } // TODO unsafe code ingnoring bufLen +// rewrite using std::string? static unsigned sp_svg_number_write_d(gchar *buf, int bufLen, double val, unsigned int tprec, unsigned int fprec) { /* Process sign */ -- cgit v1.2.3