From a5e704137d4231a68b2a45951301d98019a26316 Mon Sep 17 00:00:00 2001 From: Patrick Storz Date: Thu, 8 Aug 2019 00:38:55 +0200 Subject: Make sure we have get_widget() --- src/extension/prefdialog/widget.cpp | 5 ++++- src/extension/prefdialog/widget.h | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/extension/prefdialog/widget.cpp b/src/extension/prefdialog/widget.cpp index d1035ef85..7d37dd122 100644 --- a/src/extension/prefdialog/widget.cpp +++ b/src/extension/prefdialog/widget.cpp @@ -125,10 +125,13 @@ InxWidget::~InxWidget() _appearance = nullptr; } -/** Basically, if there is no widget pass a NULL. */ Gtk::Widget * InxWidget::get_widget(sigc::signal * /*changeSignal*/) { + // if we end up here we're missing a definition of ::get_widget() in one of the subclasses + g_critical("InxWidget::get_widget called from widget of type '%s' in extension '%s'", + typeid(this).name(), _extension->get_id()); + g_assert_not_reached(); return nullptr; } diff --git a/src/extension/prefdialog/widget.h b/src/extension/prefdialog/widget.h index 6ee678f29..843655c6e 100644 --- a/src/extension/prefdialog/widget.h +++ b/src/extension/prefdialog/widget.h @@ -58,7 +58,7 @@ public: /** Checks if name is a valid widget name, i.e. a widget can be constructed from it using make() */ static bool is_valid_widget_name(const char *name); - /** Return the instances GTK::Widget representation for usage in a GUI + /** Return the instance's GTK::Widget representation for usage in a GUI * * @param changeSignal Can be used to subscribe to parameter changes. * Will be emitted whenever a parameter value changes. -- cgit v1.2.3