From 2b56810c6a95306616f8e64499bfa20476dc7dff Mon Sep 17 00:00:00 2001 From: Gail Carmichael Date: Thu, 10 Jan 2008 22:40:48 +0000 Subject: Fix for Bug #181663 (Font style errors / assert when changing style) - I didn't see the problem described in the main part, but the assert was overzealous and, in my new opinion, shouldn't be there, so it's gone. - Fixed other style button problems mentioned in comments. (bzr r4453) --- src/desktop-style.cpp | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) (limited to 'src/desktop-style.cpp') diff --git a/src/desktop-style.cpp b/src/desktop-style.cpp index e56e7fbbe..fe388ded3 100644 --- a/src/desktop-style.cpp +++ b/src/desktop-style.cpp @@ -1075,18 +1075,22 @@ objects_query_fontspecification (GSList *objects, SPStyle *style_res) texts ++; - if (style_res->text->font_specification.value && style->text->font_specification.value && + if (style_res->text->font_specification.value && style_res->text->font_specification.set && + style->text->font_specification.value && style->text->font_specification.set && strcmp (style_res->text->font_specification.value, style->text->font_specification.value)) { different = true; // different fonts } + + if (style->text->font_specification.set) { - if (style_res->text->font_specification.value) { - g_free(style_res->text->font_specification.value); - style_res->text->font_specification.value = NULL; + if (style_res->text->font_specification.value) { + g_free(style_res->text->font_specification.value); + style_res->text->font_specification.value = NULL; + } + + style_res->text->font_specification.set = TRUE; + style_res->text->font_specification.value = g_strdup(style->text->font_specification.value); } - - style_res->text->font_specification.set = TRUE; - style_res->text->font_specification.value = g_strdup(style->text->font_specification.value); } if (texts == 0 || !style_res->text->font_specification.set) -- cgit v1.2.3