From 8f7a3a637f6a465e78e88490a03f539f0d8fdc1a Mon Sep 17 00:00:00 2001
From: Patrick Storz <eduard.braun2@gmx.de>
Date: Tue, 23 Jul 2019 01:06:21 +0200
Subject: Refactor a lot of the parameter handling code

Many fixes, improvements and simplifications to existing code.

Implements the first part of the changes discussed in
  https://gitlab.com/inkscape/inkscape/issues/333
---
 src/extension/internal/bitmap/addNoise.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/extension/internal/bitmap/addNoise.cpp')

diff --git a/src/extension/internal/bitmap/addNoise.cpp b/src/extension/internal/bitmap/addNoise.cpp
index 5981eed24..b9e80a915 100644
--- a/src/extension/internal/bitmap/addNoise.cpp
+++ b/src/extension/internal/bitmap/addNoise.cpp
@@ -33,7 +33,7 @@ AddNoise::applyEffect(Magick::Image *image) {
 
 void
 AddNoise::refreshParameters(Inkscape::Extension::Effect *module) {	
-	_noiseTypeName = module->get_param_enum("noiseType");
+	_noiseTypeName = module->get_param_optiongroup("noiseType");
 }
 
 #include "../clear-n_.h"
-- 
cgit v1.2.3


From 22c4b9e1b4964bf244d2c563217cc431194dc20a Mon Sep 17 00:00:00 2001
From: Patrick Storz <eduard.braun2@gmx.de>
Date: Sun, 1 Sep 2019 20:28:08 +0200
Subject: Update internal extensions for latest .inx format changes

---
 src/extension/internal/bitmap/addNoise.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/extension/internal/bitmap/addNoise.cpp')

diff --git a/src/extension/internal/bitmap/addNoise.cpp b/src/extension/internal/bitmap/addNoise.cpp
index b9e80a915..26b050fa8 100644
--- a/src/extension/internal/bitmap/addNoise.cpp
+++ b/src/extension/internal/bitmap/addNoise.cpp
@@ -45,13 +45,13 @@ AddNoise::init()
 		"<inkscape-extension xmlns=\"" INKSCAPE_EXTENSION_URI "\">\n"
 			"<name>" N_("Add Noise") "</name>\n"
 			"<id>org.inkscape.effect.bitmap.addNoise</id>\n"
-			"<param name=\"noiseType\" _gui-text=\"" N_("Type:") "\" type=\"enum\" >\n"
-				"<_item value='Uniform Noise'>" N_("Uniform Noise") "</_item>\n"
-				"<_item value='Gaussian Noise'>" N_("Gaussian Noise") "</_item>\n"
-				"<_item value='Multiplicative Gaussian Noise'>" N_("Multiplicative Gaussian Noise") "</_item>\n"
-				"<_item value='Impulse Noise'>" N_("Impulse Noise") "</_item>\n"
-				"<_item value='Laplacian Noise'>" N_("Laplacian Noise") "</_item>\n"
-				"<_item value='Poisson Noise'>" N_("Poisson Noise") "</_item>\n"
+			"<param name=\"noiseType\" gui-text=\"" N_("Type:") "\" type=\"optiongroup\" appearance=\"combo\" >\n"
+				"<option value='Uniform Noise'>" N_("Uniform Noise") "</option>\n"
+				"<option value='Gaussian Noise'>" N_("Gaussian Noise") "</option>\n"
+				"<option value='Multiplicative Gaussian Noise'>" N_("Multiplicative Gaussian Noise") "</option>\n"
+				"<option value='Impulse Noise'>" N_("Impulse Noise") "</option>\n"
+				"<option value='Laplacian Noise'>" N_("Laplacian Noise") "</option>\n"
+				"<option value='Poisson Noise'>" N_("Poisson Noise") "</option>\n"
 			"</param>\n"
 			"<effect>\n"
 				"<object-type>all</object-type>\n"
-- 
cgit v1.2.3