From 25de599c368f7859ec2a8e3e8c128fced3d52a9e Mon Sep 17 00:00:00 2001 From: "Johan B. C. Engelen" Date: Sat, 3 Aug 2013 21:15:44 +0200 Subject: cppcheck Common realloc mistake: 'qrsData' nulled but not freed upon failure (bzr r12448) --- src/livarot/Shape.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'src/livarot/Shape.cpp') diff --git a/src/livarot/Shape.cpp b/src/livarot/Shape.cpp index c29444a33..ab93486e5 100644 --- a/src/livarot/Shape.cpp +++ b/src/livarot/Shape.cpp @@ -130,7 +130,12 @@ Shape::MakeQuickRasterData (bool nVal) if (_has_quick_raster_data == false) { _has_quick_raster_data = true; - qrsData = (quick_raster_data*)realloc(qrsData, maxAr * sizeof(quick_raster_data)); + quick_raster_data* new_qrsData = static_cast(realloc(qrsData, maxAr * sizeof(quick_raster_data))); + if (!new_qrsData) { + g_error("Not enough memory available for reallocating Shape::qrsData"); + } else { + qrsData = new_qrsData; + } } } else -- cgit v1.2.3