From 86891a9e442c81435c6d197cb09b3dc210643bc0 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 8 Feb 2015 16:40:25 +0100
Subject: starting whith pointwise

(bzr r13645.1.7)
---
 src/live_effects/parameter/array.h | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index a600f0257..b93c7a617 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -93,7 +93,14 @@ protected:
                 // separate items with pipe symbol
                 str << " | ";
             }
-            str << vector[i];
+            std::pair<int,Geom::satellite> pointwiseElement = dynamic_cast<std::pair<int,Geom::satellite> ><(_vector[i]);
+            if(pointwiseElement){
+                str << vector[i].first;
+                str << " , ";
+                str << vector[i].second;
+            } else {
+                str << vector[i];
+            }
         }
     }
 
-- 
cgit v1.2.3


From 99fb2239028e72f8773bff39e43f7af33b4252d4 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 15 Feb 2015 19:29:48 +0100
Subject: first steps

(bzr r13645.1.9)
---
 src/live_effects/parameter/array.h | 43 +++++++++++++++++++++++++++++++-------
 1 file changed, 35 insertions(+), 8 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index b93c7a617..9f26ed3e6 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -15,6 +15,9 @@
 
 #include "live_effects/parameter/parameter.h"
 
+#include <2geom/satellite.h>
+#include <2geom/satellite-enum.h>
+#include <2geom/pointwise.h>
 #include "svg/svg.h"
 #include "svg/stringstream.h"
 
@@ -93,16 +96,40 @@ protected:
                 // separate items with pipe symbol
                 str << " | ";
             }
-            std::pair<int,Geom::satellite> pointwiseElement = dynamic_cast<std::pair<int,Geom::satellite> ><(_vector[i]);
-            if(pointwiseElement){
-                str << vector[i].first;
-                str << " , ";
-                str << vector[i].second;
-            } else {
-                str << vector[i];
-            }
+            writesvgData(str,vector[i]);
         }
     }
+    
+    void writesvgData(SVGOStringStream &str, float const &nVector) const {
+        str << nVector;
+    }
+
+    void writesvgData(SVGOStringStream &str, double const &nVector) const {
+        str << nVector;
+    }
+
+    void writesvgData(SVGOStringStream &str, Geom::Point const &nVector) const {
+        str << nVector;
+    }
+
+    void writesvgData(SVGOStringStream &str, std::pair<int, Geom::Satellite> const &nVector) const {
+        str << nVector.first;
+        str << " , ";
+        std::map<Geom::SatelliteType, gchar const *> stg = nVector.second.SatelliteTypeToGcharMap;
+        str <<   stg[nVector.second.satellitetype()];
+        str << " * ";
+        str << nVector.second.isTime();
+        str << " * ";
+        str << nVector.second.active();
+        str << " * ";
+        str << nVector.second.hasMirror();
+        str << " * ";
+        str << nVector.second.hidden();
+        str << " * ";
+        str << nVector.second.size();
+        str << " * ";
+        str <<nVector.second.time();
+    }
 
     StorageType readsvg(const gchar * str);
 
-- 
cgit v1.2.3


From 5c3350ef1281298f25c1cbcb60a66d238a417030 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Mon, 16 Feb 2015 00:12:00 +0100
Subject: added knots

(bzr r13645.1.12)
---
 src/live_effects/parameter/array.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 9f26ed3e6..ba1ed3d4e 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -114,20 +114,20 @@ protected:
 
     void writesvgData(SVGOStringStream &str, std::pair<int, Geom::Satellite> const &nVector) const {
         str << nVector.first;
-        str << " , ";
+        str << ",";
         std::map<Geom::SatelliteType, gchar const *> stg = nVector.second.SatelliteTypeToGcharMap;
         str <<   stg[nVector.second.satellitetype()];
-        str << " * ";
+        str << "*";
         str << nVector.second.isTime();
-        str << " * ";
+        str << "*";
         str << nVector.second.active();
-        str << " * ";
+        str << "*";
         str << nVector.second.hasMirror();
-        str << " * ";
+        str << "*";
         str << nVector.second.hidden();
-        str << " * ";
+        str << "*";
         str << nVector.second.size();
-        str << " * ";
+        str << "*";
         str <<nVector.second.time();
     }
 
-- 
cgit v1.2.3


From 9593c78703845bfca18a3a135cbbc47cc03b54f6 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Mon, 16 Feb 2015 21:49:53 +0100
Subject: continuing fillet/chamfer

(bzr r13645.1.13)
---
 src/live_effects/parameter/array.h | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index ba1ed3d4e..c99777b08 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -116,19 +116,19 @@ protected:
         str << nVector.first;
         str << ",";
         std::map<Geom::SatelliteType, gchar const *> stg = nVector.second.SatelliteTypeToGcharMap;
-        str <<   stg[nVector.second.satellitetype()];
+        str <<   nVector.second.getSatelliteTypeGchar();
         str << "*";
-        str << nVector.second.isTime();
+        str << nVector.second.getIsTime();
         str << "*";
-        str << nVector.second.active();
+        str << nVector.second.getActive();
         str << "*";
-        str << nVector.second.hasMirror();
+        str << nVector.second.getHasMirror();
         str << "*";
-        str << nVector.second.hidden();
+        str << nVector.second.getHidden();
         str << "*";
-        str << nVector.second.size();
+        str << nVector.second.getSize();
         str << "*";
-        str <<nVector.second.time();
+        str <<nVector.second.getTime();
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From e6e262b34c193502d1f9be44324515bf8c861d47 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Tue, 17 Feb 2015 00:23:51 +0100
Subject: starting fillet/chamfer

(bzr r13645.1.15)
---
 src/live_effects/parameter/array.h | 1 -
 1 file changed, 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index c99777b08..8145d62a3 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -115,7 +115,6 @@ protected:
     void writesvgData(SVGOStringStream &str, std::pair<int, Geom::Satellite> const &nVector) const {
         str << nVector.first;
         str << ",";
-        std::map<Geom::SatelliteType, gchar const *> stg = nVector.second.SatelliteTypeToGcharMap;
         str <<   nVector.second.getSatelliteTypeGchar();
         str << "*";
         str << nVector.second.getIsTime();
-- 
cgit v1.2.3


From 83e726c8fb391f0cbbccc9b286bfecefc730dbc7 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Mon, 23 Feb 2015 23:16:39 +0100
Subject: Added flexible/fixed to fillet chamfer and fix bugs

(bzr r13645.1.20)
---
 src/live_effects/parameter/array.h | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 8145d62a3..e9775da24 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -115,15 +115,15 @@ protected:
     void writesvgData(SVGOStringStream &str, std::pair<int, Geom::Satellite> const &nVector) const {
         str << nVector.first;
         str << ",";
-        str <<   nVector.second.getSatelliteTypeGchar();
+        str << nVector.second.getSatelliteTypeGchar();
         str << "*";
-        str << nVector.second.getIsTime();
+        str << g_strdup(nVector.second.getIsTime() ? "true" : "false");
         str << "*";
-        str << nVector.second.getActive();
+        str << g_strdup(nVector.second.getActive() ? "true" : "false");
         str << "*";
-        str << nVector.second.getHasMirror();
+        str << g_strdup(nVector.second.getHasMirror() ? "true" : "false");
         str << "*";
-        str << nVector.second.getHidden();
+        str << g_strdup(nVector.second.getHidden() ? "true" : "false");
         str << "*";
         str << nVector.second.getSize();
         str << "*";
-- 
cgit v1.2.3


From 43c5af94d24cd408f7b369545e96cf9192f6ba90 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sat, 28 Feb 2015 13:13:49 +0100
Subject: improving code

(bzr r13645.1.24)
---
 src/live_effects/parameter/array.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index e9775da24..ff406d792 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -117,13 +117,13 @@ protected:
         str << ",";
         str << nVector.second.getSatelliteTypeGchar();
         str << "*";
-        str << g_strdup(nVector.second.getIsTime() ? "true" : "false");
+        str << nVector.second.getIsTime();
         str << "*";
-        str << g_strdup(nVector.second.getActive() ? "true" : "false");
+        str << nVector.second.getActive();
         str << "*";
-        str << g_strdup(nVector.second.getHasMirror() ? "true" : "false");
+        str << nVector.second.getHasMirror();
         str << "*";
-        str << g_strdup(nVector.second.getHidden() ? "true" : "false");
+        str << nVector.second.getHidden();
         str << "*";
         str << nVector.second.getSize();
         str << "*";
-- 
cgit v1.2.3


From 00d08a0f4bca11e775bbacf3d512676a0493c1a3 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 1 Mar 2015 01:18:02 +0100
Subject: adding mirror knot

(bzr r13645.1.25)
---
 src/live_effects/parameter/array.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index ff406d792..1a5823199 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -125,9 +125,9 @@ protected:
         str << "*";
         str << nVector.second.getHidden();
         str << "*";
-        str << nVector.second.getSize();
+        str << nVector.second.getAmmount();
         str << "*";
-        str <<nVector.second.getTime();
+        str << nVector.second.getAngle();
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From f77b5496f69a5391bc548be95c85659539a92fe9 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 1 Mar 2015 23:23:56 +0100
Subject: added mirror knots

(bzr r13645.1.26)
---
 src/live_effects/parameter/array.h | 4 ++++
 1 file changed, 4 insertions(+)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 1a5823199..0be155f50 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -119,6 +119,10 @@ protected:
         str << "*";
         str << nVector.second.getIsTime();
         str << "*";
+        str << nVector.second.getIsClosing();
+        str << "*";
+        str << nVector.second.getIsStart();
+        str << "*";
         str << nVector.second.getActive();
         str << "*";
         str << nVector.second.getHasMirror();
-- 
cgit v1.2.3


From 1db09cce6114c1b2d95ac77b00672caad0447b29 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Wed, 4 Mar 2015 23:42:59 +0100
Subject: All features done, only need piecewise update function

(bzr r13645.1.33)
---
 src/live_effects/parameter/array.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 0be155f50..d28576fce 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -112,7 +112,7 @@ protected:
         str << nVector;
     }
 
-    void writesvgData(SVGOStringStream &str, std::pair<int, Geom::Satellite> const &nVector) const {
+    void writesvgData(SVGOStringStream &str, std::pair<unsigned int, Geom::Satellite> const &nVector) const {
         str << nVector.first;
         str << ",";
         str << nVector.second.getSatelliteTypeGchar();
@@ -132,6 +132,8 @@ protected:
         str << nVector.second.getAmmount();
         str << "*";
         str << nVector.second.getAngle();
+        str << "*";
+        str << nVector.second.getSteps();
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From 62ebac099d8fa013e34a773c0fe3aee56b5a5758 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sat, 7 Mar 2015 13:55:16 +0100
Subject: finish helper paths and beter handle of fillet/chamfer overflow. Also
 make the satellitepairarray LPE parameter usable for other pointwise effects,
 not only to fillet chamfer

(bzr r13645.1.35)
---
 src/live_effects/parameter/array.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index d28576fce..a6e797d4e 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -129,7 +129,7 @@ protected:
         str << "*";
         str << nVector.second.getHidden();
         str << "*";
-        str << nVector.second.getAmmount();
+        str << nVector.second.getAmount();
         str << "*";
         str << nVector.second.getAngle();
         str << "*";
-- 
cgit v1.2.3


From aeffc3f474c1ce460b2c9f8340de283d5853a164 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Thu, 19 Mar 2015 19:26:22 +0100
Subject: fixing a boring bug in path manipulator

(bzr r13645.1.43)
---
 src/live_effects/parameter/array.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index a6e797d4e..5443cc3c4 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -119,9 +119,7 @@ protected:
         str << "*";
         str << nVector.second.getIsTime();
         str << "*";
-        str << nVector.second.getIsClosing();
-        str << "*";
-        str << nVector.second.getIsStart();
+        str << nVector.second.getIsEndOpen();
         str << "*";
         str << nVector.second.getActive();
         str << "*";
@@ -134,6 +132,7 @@ protected:
         str << nVector.second.getAngle();
         str << "*";
         str << nVector.second.getSteps();
+        std::cout << str.str() << "SATEEELIITE\n";
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From f3e7b51b1d2497cda7a66e13f4f50da145ece19c Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Fri, 20 Mar 2015 00:14:47 +0100
Subject: Added delete nodes/satellites

(bzr r13645.1.45)
---
 src/live_effects/parameter/array.h | 2 --
 1 file changed, 2 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 5443cc3c4..7ff477ffb 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -17,7 +17,6 @@
 
 #include <2geom/satellite.h>
 #include <2geom/satellite-enum.h>
-#include <2geom/pointwise.h>
 #include "svg/svg.h"
 #include "svg/stringstream.h"
 
@@ -132,7 +131,6 @@ protected:
         str << nVector.second.getAngle();
         str << "*";
         str << nVector.second.getSteps();
-        std::cout << str.str() << "SATEEELIITE\n";
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From 8bd246d8b59749e15de4d5d0d78e9b82fa8a601a Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 22 Mar 2015 18:27:17 +0100
Subject: Fixed bug when deleting nodes

(bzr r13645.1.51)
---
 src/live_effects/parameter/array.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 7ff477ffb..4fb053dbb 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -90,7 +90,7 @@ protected:
     size_t _default_size;
 
     void writesvg(SVGOStringStream &str, std::vector<StorageType> const &vector) const {
-        for (unsigned int i = 0; i < vector.size(); ++i) {
+        for (size_t i = 0; i < vector.size(); ++i) {
             if (i != 0) {
                 // separate items with pipe symbol
                 str << " | ";
@@ -111,7 +111,7 @@ protected:
         str << nVector;
     }
 
-    void writesvgData(SVGOStringStream &str, std::pair<unsigned int, Geom::Satellite> const &nVector) const {
+    void writesvgData(SVGOStringStream &str, std::pair<size_t, Geom::Satellite> const &nVector) const {
         str << nVector.first;
         str << ",";
         str << nVector.second.getSatelliteTypeGchar();
-- 
cgit v1.2.3


From dff3aa428ff050c2cce501f646977ddad921feca Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Wed, 1 Apr 2015 04:13:16 +0200
Subject: Move 2Geom work to a intermediate positon -helper- Removed dependency
 to helper/geom.h Now use a simple vector, not a vector of pairs of size_t and
 Satellite Getters and setters on Satellite removed Update store parameter to
 a more friendly string, like powerstroke Todo: Documentation and Fix coding
 style.

(bzr r13645.1.63)
---
 src/live_effects/parameter/array.h | 38 +++++++++++++++++---------------------
 1 file changed, 17 insertions(+), 21 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 4fb053dbb..25e479304 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -15,8 +15,8 @@
 
 #include "live_effects/parameter/parameter.h"
 
-#include <2geom/satellite.h>
-#include <2geom/satellite-enum.h>
+#include "helper/geom-satellite.h"
+#include "helper/geom-satellite-enum.h"
 #include "svg/svg.h"
 #include "svg/stringstream.h"
 
@@ -111,26 +111,22 @@ protected:
         str << nVector;
     }
 
-    void writesvgData(SVGOStringStream &str, std::pair<size_t, Geom::Satellite> const &nVector) const {
-        str << nVector.first;
+    void writesvgData(SVGOStringStream &str, Geom::Satellite const &nVector) const {
+        str << nVector.getSatelliteTypeGchar();
         str << ",";
-        str << nVector.second.getSatelliteTypeGchar();
-        str << "*";
-        str << nVector.second.getIsTime();
-        str << "*";
-        str << nVector.second.getIsEndOpen();
-        str << "*";
-        str << nVector.second.getActive();
-        str << "*";
-        str << nVector.second.getHasMirror();
-        str << "*";
-        str << nVector.second.getHidden();
-        str << "*";
-        str << nVector.second.getAmount();
-        str << "*";
-        str << nVector.second.getAngle();
-        str << "*";
-        str << nVector.second.getSteps();
+        str << nVector.isTime;
+        str << ",";
+        str << nVector.active;
+        str << ",";
+        str << nVector.hasMirror;
+        str << ",";
+        str << nVector.hidden;
+        str << ",";
+        str << nVector.amount;
+        str << ",";
+        str << nVector.angle;
+        str << ",";
+        str << nVector.steps;
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From 3ce6cb91e8259ec064956c79c2cc4f9050dccbce Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sat, 9 May 2015 22:48:48 +0200
Subject: fixing review

(bzr r13645.1.86)
---
 src/live_effects/parameter/array.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 25e479304..66ed6344b 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -16,7 +16,6 @@
 #include "live_effects/parameter/parameter.h"
 
 #include "helper/geom-satellite.h"
-#include "helper/geom-satellite-enum.h"
 #include "svg/svg.h"
 #include "svg/stringstream.h"
 
@@ -111,14 +110,14 @@ protected:
         str << nVector;
     }
 
-    void writesvgData(SVGOStringStream &str, Geom::Satellite const &nVector) const {
+    void writesvgData(SVGOStringStream &str, Satellite const &nVector) const {
         str << nVector.getSatelliteTypeGchar();
         str << ",";
-        str << nVector.isTime;
+        str << nVector.is_time;
         str << ",";
         str << nVector.active;
         str << ",";
-        str << nVector.hasMirror;
+        str << nVector.has_mirror;
         str << ",";
         str << nVector.hidden;
         str << ",";
-- 
cgit v1.2.3


From 97bd182d6a2113eab1dd5faf51402ebd5382791c Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 8 May 2016 22:57:37 +0200
Subject: First attempt to make fixed tweenk review

(bzr r13645.1.128)
---
 src/live_effects/parameter/array.h | 35 +++++++++++++++++++----------------
 1 file changed, 19 insertions(+), 16 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 66ed6344b..7076a465f 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -110,22 +110,25 @@ protected:
         str << nVector;
     }
 
-    void writesvgData(SVGOStringStream &str, Satellite const &nVector) const {
-        str << nVector.getSatelliteTypeGchar();
-        str << ",";
-        str << nVector.is_time;
-        str << ",";
-        str << nVector.active;
-        str << ",";
-        str << nVector.has_mirror;
-        str << ",";
-        str << nVector.hidden;
-        str << ",";
-        str << nVector.amount;
-        str << ",";
-        str << nVector.angle;
-        str << ",";
-        str << nVector.steps;
+    void writesvgData(SVGOStringStream &str, std::vector<Satellite> const &nVector) const {
+        for (size_t i = 0; i < nVector.size(); ++i) {
+            str << nVector[i].getSatelliteTypeGchar();
+            str << ",";
+            str << nVector[i].is_time;
+            str << ",";
+            str << nVector[i].has_mirror;
+            str << ",";
+            str << nVector[i].hidden;
+            str << ",";
+            str << nVector[i].amount;
+            str << ",";
+            str << nVector[i].angle;
+            str << ",";
+            str << nVector[i].steps;
+            if (i != nVector.size()-1) {
+                str << "@";
+            }
+        }
     }
 
     StorageType readsvg(const gchar * str);
-- 
cgit v1.2.3


From 07717a370b8efe6ddbb0c69d115bb063a2e7686a Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Tue, 10 May 2016 23:16:49 +0200
Subject: Working with path updates

(bzr r13645.1.130)
---
 src/live_effects/parameter/array.h | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 7076a465f..64d01650c 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -51,7 +51,7 @@ public:
 
     virtual bool param_readSVGValue(const gchar * strvalue) {
         _vector.clear();
-        gchar ** strarray = g_strsplit(strvalue, "|", 0);
+        gchar ** strarray = g_strsplit(strvalue, " | ", 0);
         gchar ** iter = strarray;
         while (*iter != NULL) {
             _vector.push_back( readsvg(*iter) );
@@ -112,6 +112,10 @@ protected:
 
     void writesvgData(SVGOStringStream &str, std::vector<Satellite> const &nVector) const {
         for (size_t i = 0; i < nVector.size(); ++i) {
+            if (i != 0) {
+                // separate items with @ symbol ¿Any other?
+                str << " @ ";
+            }
             str << nVector[i].getSatelliteTypeGchar();
             str << ",";
             str << nVector[i].is_time;
@@ -125,9 +129,6 @@ protected:
             str << nVector[i].angle;
             str << ",";
             str << nVector[i].steps;
-            if (i != nVector.size()-1) {
-                str << "@";
-            }
         }
     }
 
-- 
cgit v1.2.3


From 4c145e43f8ab8d8040fb2fa42309f7bd400f6349 Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sat, 14 May 2016 23:52:45 +0200
Subject: Fixing pointwise

(bzr r13645.1.135)
---
 src/live_effects/parameter/array.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 64d01650c..8a9d72fe3 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -51,7 +51,7 @@ public:
 
     virtual bool param_readSVGValue(const gchar * strvalue) {
         _vector.clear();
-        gchar ** strarray = g_strsplit(strvalue, " | ", 0);
+        gchar ** strarray = g_strsplit(strvalue, "|", 0);
         gchar ** iter = strarray;
         while (*iter != NULL) {
             _vector.push_back( readsvg(*iter) );
-- 
cgit v1.2.3


From 159439c26042b7c69aa9c33ce9484e4dfd00372a Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Sun, 15 May 2016 11:48:51 +0200
Subject: Fixing pointwise

(bzr r13645.1.137)
---
 src/live_effects/parameter/array.h | 32 ++++++++++++++++----------------
 1 file changed, 16 insertions(+), 16 deletions(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 8a9d72fe3..9802abc2e 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -89,7 +89,7 @@ protected:
     size_t _default_size;
 
     void writesvg(SVGOStringStream &str, std::vector<StorageType> const &vector) const {
-        for (size_t i = 0; i < vector.size(); ++i) {
+        for (unsigned int i = 0; i < vector.size(); ++i) {
             if (i != 0) {
                 // separate items with pipe symbol
                 str << " | ";
@@ -98,37 +98,37 @@ protected:
         }
     }
     
-    void writesvgData(SVGOStringStream &str, float const &nVector) const {
-        str << nVector;
+    void writesvgData(SVGOStringStream &str, float const &vector_data) const {
+        str << vector_data;
     }
 
-    void writesvgData(SVGOStringStream &str, double const &nVector) const {
-        str << nVector;
+    void writesvgData(SVGOStringStream &str, double const &vector_data) const {
+        str << vector_data;
     }
 
-    void writesvgData(SVGOStringStream &str, Geom::Point const &nVector) const {
-        str << nVector;
+    void writesvgData(SVGOStringStream &str, Geom::Point const &vector_data) const {
+        str << vector_data;
     }
 
-    void writesvgData(SVGOStringStream &str, std::vector<Satellite> const &nVector) const {
-        for (size_t i = 0; i < nVector.size(); ++i) {
+    void writesvgData(SVGOStringStream &str, std::vector<Satellite> const &vector_data) const {
+        for (size_t i = 0; i < vector_data.size(); ++i) {
             if (i != 0) {
                 // separate items with @ symbol ¿Any other?
                 str << " @ ";
             }
-            str << nVector[i].getSatelliteTypeGchar();
+            str << vector_data[i].getSatelliteTypeGchar();
             str << ",";
-            str << nVector[i].is_time;
+            str << vector_data[i].is_time;
             str << ",";
-            str << nVector[i].has_mirror;
+            str << vector_data[i].has_mirror;
             str << ",";
-            str << nVector[i].hidden;
+            str << vector_data[i].hidden;
             str << ",";
-            str << nVector[i].amount;
+            str << vector_data[i].amount;
             str << ",";
-            str << nVector[i].angle;
+            str << vector_data[i].angle;
             str << ",";
-            str << nVector[i].steps;
+            str << vector_data[i].steps;
         }
     }
 
-- 
cgit v1.2.3


From 73f078b27b669c941651ecf14a3119ae491ccabf Mon Sep 17 00:00:00 2001
From: Jabier Arraiza Cenoz <jabier.arraiza@marker.es>
Date: Mon, 13 Jun 2016 00:58:55 +0200
Subject: Fix 90% of tweenk review

(bzr r13645.1.155)
---
 src/live_effects/parameter/array.h | 2 ++
 1 file changed, 2 insertions(+)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 9802abc2e..9204ede1f 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -120,6 +120,8 @@ protected:
             str << ",";
             str << vector_data[i].is_time;
             str << ",";
+            str << vector_data[i].selected;
+            str << ",";
             str << vector_data[i].has_mirror;
             str << ",";
             str << vector_data[i].hidden;
-- 
cgit v1.2.3


From 3103b99b4cf6c1048c89f75e280761d8cd0ca1c2 Mon Sep 17 00:00:00 2001
From: Jabiertxof <jtx@jtx>
Date: Sat, 15 Apr 2017 00:20:13 +0200
Subject: Allow set and reset default values of LPE parameters

(bzr r15620.1.1)
---
 src/live_effects/parameter/array.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index a600f0257..fa08e1f91 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -59,7 +59,7 @@ public:
         g_strfreev (strarray);
         return true;
     }
-
+    virtual void param_update_default(const gchar * default_value){};
     virtual gchar * param_getSVGValue() const {
         Inkscape::SVGOStringStream os;
         writesvg(os, _vector);
-- 
cgit v1.2.3


From 52054e24f8b98c07753588c726a1e777bad7245b Mon Sep 17 00:00:00 2001
From: Jabiertxof <jtx@jtx>
Date: Fri, 28 Apr 2017 21:42:36 +0200
Subject: Reset

(bzr r15620.1.9)
---
 src/live_effects/parameter/array.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index fa08e1f91..a600f0257 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -59,7 +59,7 @@ public:
         g_strfreev (strarray);
         return true;
     }
-    virtual void param_update_default(const gchar * default_value){};
+
     virtual gchar * param_getSVGValue() const {
         Inkscape::SVGOStringStream os;
         writesvg(os, _vector);
-- 
cgit v1.2.3


From e5601e5e84df30c40d93271fd69cecd31391e309 Mon Sep 17 00:00:00 2001
From: Jabiertxof <jtx@jtx>
Date: Sat, 29 Apr 2017 02:01:22 +0200
Subject: Rewrite UX

(bzr r15620.1.12)
---
 src/live_effects/parameter/array.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index a600f0257..fa08e1f91 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -59,7 +59,7 @@ public:
         g_strfreev (strarray);
         return true;
     }
-
+    virtual void param_update_default(const gchar * default_value){};
     virtual gchar * param_getSVGValue() const {
         Inkscape::SVGOStringStream os;
         writesvg(os, _vector);
-- 
cgit v1.2.3


From 557ec6397498df157e0fd08561bede35606c7baf Mon Sep 17 00:00:00 2001
From: Jabiertxof <jtx@jtx>
Date: Sat, 6 May 2017 21:00:24 +0200
Subject: Fix a compiling bug found by Ede_123 on IRC

(bzr r15667)
---
 src/live_effects/parameter/array.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/live_effects/parameter/array.h')

diff --git a/src/live_effects/parameter/array.h b/src/live_effects/parameter/array.h
index 10a3ea018..e65d3b55c 100644
--- a/src/live_effects/parameter/array.h
+++ b/src/live_effects/parameter/array.h
@@ -130,7 +130,7 @@ protected:
             str << ",";
             str << vector_data[i].angle;
             str << ",";
-            str << vector_data[i].steps;
+            str << static_cast<int>(vector_data[i].steps);
         }
     }
 
-- 
cgit v1.2.3