From ad092a3d734fcec79273f957e8d86c7a9ceb767b Mon Sep 17 00:00:00 2001 From: Maximilian Albert Date: Sun, 8 Jun 2008 17:33:58 +0000 Subject: Make knotholders for LPE items finally work; each effect can now overload the addKnotHolderHandles() method to add handles which control its parameters. There is now also a virtual onKnotUngrabbed() method for each knotholder entity which can be used to do cleanup tasks (for LPE parameters it currently writes the value to SVG, although this should probably happen automatically) (bzr r5855) --- src/object-edit.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/object-edit.cpp') diff --git a/src/object-edit.cpp b/src/object-edit.cpp index 281b5e89d..8d8be4b85 100644 --- a/src/object-edit.cpp +++ b/src/object-edit.cpp @@ -56,11 +56,8 @@ static KnotHolder *sp_lpe_knot_holder(SPItem *item, SPDesktop *desktop) KnotHolder *knot_holder = new KnotHolder(desktop, item, NULL); Inkscape::LivePathEffect::Effect *effect = sp_lpe_item_get_current_lpe(SP_LPE_ITEM(item)); - if (!effect) { - g_error("sp_lpe_knot_holder: logical error, this method cannot be called with item having an LPE"); - } else { - effect->addHandles(knot_holder); - } +// effect->addPointParamHandles(knot_holder, desktop, item); + effect->addKnotHolderHandles(knot_holder, desktop, item); return knot_holder; } -- cgit v1.2.3