From cb8c36249e983866378e7915e6605ef92d247923 Mon Sep 17 00:00:00 2001
From: Shlomi Fish <shlomif@shlomifish.org>
Date: Thu, 23 May 2019 11:06:12 +0300
Subject: Refactoring: call setAttribute() directly.

Call this->setAttribute(...) directly instead of
this->getRepr()->setAttribute(...). This avoids clutter and mental indirection.

See
http://wiki.inkscape.org/wiki/index.php?title=Refactoring_projects&oldid=112116

and https://en.wikipedia.org/wiki/Law_of_Demeter .

---

I hereby disclaim any implicit or explicit ownership of my changes in this
changeset, and put them under a multiple licence consisting of your choice of
one of more of:

- The CC0 / Public Domain - https://creativecommons.org/choose/zero/ .

- The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License

- The default licence of your project

- The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version
2.1 or higher

- The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or
higher

- Any licence in the 2018-Aug-27 popular licenses list of
https://opensource.org/licenses

- The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later

- The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later

- The https://en.wikipedia.org/wiki/ISC_license

- The https://opensource.org/licenses/BSD-2-Clause

Crediting me will be nice, but not mandatory, and you can change the licence
of the project without needing my permission.
---
 src/object/sp-offset.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

(limited to 'src/object/sp-offset.cpp')

diff --git a/src/object/sp-offset.cpp b/src/object/sp-offset.cpp
index 13de079e0..b5965813e 100644
--- a/src/object/sp-offset.cpp
+++ b/src/object/sp-offset.cpp
@@ -118,8 +118,8 @@ void SPOffset::build(SPDocument *document, Inkscape::XML::Node *repr) {
         //XML Tree being used directly here (as object->getRepr) 
         //in all the below lines in the block while it shouldn't be.
         gchar const *oldA = this->getRepr()->attribute("sodipodi:radius");
-        this->getRepr()->setAttribute("inkscape:radius",oldA);
-        this->getRepr()->setAttribute("sodipodi:radius",nullptr);
+        this->setAttribute("inkscape:radius",oldA);
+        this->setAttribute("sodipodi:radius",nullptr);
 
         this->readAttr( "inkscape:radius" );
     }
@@ -128,8 +128,8 @@ void SPOffset::build(SPDocument *document, Inkscape::XML::Node *repr) {
         this->readAttr( "inkscape:original" );
     } else {
         gchar const *oldA = this->getRepr()->attribute("sodipodi:original");
-        this->getRepr()->setAttribute("inkscape:original",oldA);
-        this->getRepr()->setAttribute("sodipodi:original",nullptr);
+        this->setAttribute("inkscape:original",oldA);
+        this->setAttribute("sodipodi:original",nullptr);
 
         this->readAttr( "inkscape:original" );
     }
@@ -148,11 +148,11 @@ void SPOffset::build(SPDocument *document, Inkscape::XML::Node *repr) {
             nA[0]='#';
             nA[lA+1]=0;
 
-            this->getRepr()->setAttribute("xlink:href",nA);
+            this->setAttribute("xlink:href",nA);
 
             free(nA);
 
-            this->getRepr()->setAttribute("inkscape:href",nullptr);
+            this->setAttribute("inkscape:href",nullptr);
         }
 
         this->readAttr( "xlink:href" );
@@ -1188,7 +1188,7 @@ refresh_offset_source(SPOffset* offset)
 
         // TODO fix:
         //XML Tree being used directly here while it shouldn't be.
-        offset->getRepr()->setAttribute("inkscape:original", res_d);
+        offset->setAttribute("inkscape:original", res_d);
 
         free (res_d);
     }
-- 
cgit v1.2.3