From 571f36f1b61d316a2f2ace00fa94ba83ab1ac0a0 Mon Sep 17 00:00:00 2001
From: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
Date: Mon, 18 Jun 2018 18:54:54 +0200
Subject: =?UTF-8?q?Run=20clang-tidy=E2=80=99s=20modernize-pass-by-value=20?=
 =?UTF-8?q?pass.?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This avoids having to pass variables by reference before copying them
when calling a constructor.
---
 src/preferences.cpp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

(limited to 'src/preferences.cpp')

diff --git a/src/preferences.cpp b/src/preferences.cpp
index b7242a48d..1c4951d75 100644
--- a/src/preferences.cpp
+++ b/src/preferences.cpp
@@ -12,6 +12,7 @@
 
 #include <cstring>
 #include <sstream>
+#include <utility>
 #include <glibmm/fileutils.h>
 #include <glibmm/convert.h>
 #include <glibmm/i18n.h>
@@ -71,9 +72,9 @@ static void file_add_recent(gchar const *uri)
  */
 class Preferences::PrefNodeObserver : public XML::NodeObserver {
 public:
-    PrefNodeObserver(Observer &o, Glib::ustring const &filter) :
+    PrefNodeObserver(Observer &o, Glib::ustring filter) :
         _observer(o),
-        _filter(filter)
+        _filter(std::move(filter))
     {}
     ~PrefNodeObserver() override = default;
     void notifyAttributeChanged(XML::Node &node, GQuark name, Util::ptr_shared, Util::ptr_shared) override;
@@ -551,8 +552,8 @@ public:
     bool _is_attr; ///< Whether this Observer watches a single attribute
 };
 
-Preferences::Observer::Observer(Glib::ustring const &path) :
-    observed_path(path),
+Preferences::Observer::Observer(Glib::ustring path) :
+    observed_path(std::move(path)),
     _data(nullptr)
 {
 }
-- 
cgit v1.2.3