From bceaaf6eacb0bf2f23cf42af5d9ee8332a08560f Mon Sep 17 00:00:00 2001 From: Kris De Gussem Date: Sat, 4 Feb 2012 10:05:50 +0100 Subject: cppcheck tells us: scanf without field width limits can crash with huge input data. (gimpgrad) Some additional scanf modifications (bzr r10932) --- src/sp-filter.cpp | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) (limited to 'src/sp-filter.cpp') diff --git a/src/sp-filter.cpp b/src/sp-filter.cpp index d0fd59802..bafd356d6 100644 --- a/src/sp-filter.cpp +++ b/src/sp-filter.cpp @@ -564,9 +564,14 @@ Glib::ustring sp_filter_get_new_result_name(SPFilter *filter) { Inkscape::XML::Node *repr = primitive_obj->getRepr(); char const *result = repr->attribute("result"); int index; - if (result && sscanf(result, "result%d", &index) == 1) { - if (index > largest) { - largest = index; + if (result) + { + if (sscanf(result, "result%d", &index) == 1) + { + if (index > largest) + { + largest = index; + } } } } -- cgit v1.2.3