From cb8c36249e983866378e7915e6605ef92d247923 Mon Sep 17 00:00:00 2001 From: Shlomi Fish Date: Thu, 23 May 2019 11:06:12 +0300 Subject: Refactoring: call setAttribute() directly. Call this->setAttribute(...) directly instead of this->getRepr()->setAttribute(...). This avoids clutter and mental indirection. See http://wiki.inkscape.org/wiki/index.php?title=Refactoring_projects&oldid=112116 and https://en.wikipedia.org/wiki/Law_of_Demeter . --- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission. --- src/style.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/style.cpp') diff --git a/src/style.cpp b/src/style.cpp index 17ad85dc3..2d82791af 100644 --- a/src/style.cpp +++ b/src/style.cpp @@ -686,7 +686,7 @@ SPStyle::readIfUnset(SPAttributeEnum id, gchar const *val, SPStyleSrc const &sou //XML Tree being directly used here. if (object) { - object->getRepr()->setAttribute("clip-path", val); + object->setAttribute("clip-path", val); } return; case SP_PROP_MASK: @@ -697,7 +697,7 @@ SPStyle::readIfUnset(SPAttributeEnum id, gchar const *val, SPStyleSrc const &sou //XML Tree being directly used here. if (object) { - object->getRepr()->setAttribute("mask", val); + object->setAttribute("mask", val); } return; case SP_PROP_FILTER: -- cgit v1.2.3