From 3ffefe1e05e3858ce6584dc644817c411232dc77 Mon Sep 17 00:00:00 2001 From: Thomas Holder Date: Sun, 18 Aug 2019 17:29:16 +0200 Subject: reduce usage of desktop coordinates (#341) - avoid unnecessary internal usage of desktop coordinates, e.g. in SpellCheck::compareTextBboxes - document whether a function argument is in document or desktop coordinates, e.g. for SPDocument::getItemsInBox --- src/ui/tools/spray-tool.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/ui/tools/spray-tool.cpp') diff --git a/src/ui/tools/spray-tool.cpp b/src/ui/tools/spray-tool.cpp index c910607a9..c8dce3986 100644 --- a/src/ui/tools/spray-tool.cpp +++ b/src/ui/tools/spray-tool.cpp @@ -527,7 +527,6 @@ static bool fit_item(SPDesktop *desktop, sp_spray_transform_path(item, path, Geom::Scale(scale), center); sp_spray_transform_path(item, path, Geom::Rotate(angle), center); path *= Geom::Translate(move); - path *= desktop->doc2dt(); bbox_procesed = path.boundsFast(); double bbox_left_main = bbox_procesed->left(); double bbox_right_main = bbox_procesed->right(); @@ -535,7 +534,7 @@ static bool fit_item(SPDesktop *desktop, double bbox_bottom_main = bbox_procesed->bottom(); double width_transformed = bbox_procesed->width(); double height_transformed = bbox_procesed->height(); - Geom::Point mid_point = desktop->d2w(bbox_procesed->midpoint()); + Geom::Point mid_point = desktop->d2w(bbox_procesed->midpoint() * desktop->doc2dt()); Geom::IntRect area = Geom::IntRect::from_xywh(floor(mid_point[Geom::X]), floor(mid_point[Geom::Y]), 1, 1); guint32 rgba = getPickerData(area); guint32 rgba2 = 0xffffff00; -- cgit v1.2.3