From 9b2547b37b41e018659a9ece46310e2668b7f38b Mon Sep 17 00:00:00 2001 From: Eduard Braun Date: Tue, 13 Mar 2018 19:51:53 +0100 Subject: Avoid crash when confirming new value in InkSpinScale with Keyboard It seems "InkSpinScale::set_focus_widget()" is never called, so "_focus_widget" is never initialized and has an arbitrary value. Avoid this by initializing to zero. Why we never call set_focus_widget() is TBD... Fixed bugs: - https://bugs.launchpad.net/inkscape/+bug/1755464 --- src/ui/widget/ink-spinscale.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/ui/widget') diff --git a/src/ui/widget/ink-spinscale.h b/src/ui/widget/ink-spinscale.h index dda86597a..9eb297b1f 100644 --- a/src/ui/widget/ink-spinscale.h +++ b/src/ui/widget/ink-spinscale.h @@ -84,7 +84,7 @@ class InkSpinScale : public Gtk::Box InkScale* _scale; Gtk::SpinButton* _spinbutton; Glib::RefPtr _adjustment; - GtkWidget* _focus_widget; + GtkWidget* _focus_widget = nullptr; bool on_key_release_event(GdkEventKey* key_event) override; -- cgit v1.2.3