From 50ccd526dbb34f9954f5a71de18847b258e19f9b Mon Sep 17 00:00:00 2001 From: Tavmjong Bah Date: Tue, 28 Feb 2017 13:31:18 +0100 Subject: Add some comment. Comment out unused signals. (bzr r15554) --- src/ui/dialog/dialog-manager.h | 10 +++++----- src/ui/dialog/prototype.cpp | 5 +++++ src/ui/widget/panel.h | 1 + 3 files changed, 11 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/ui/dialog/dialog-manager.h b/src/ui/dialog/dialog-manager.h index 15573f760..36e9a12be 100644 --- a/src/ui/dialog/dialog-manager.h +++ b/src/ui/dialog/dialog-manager.h @@ -30,11 +30,11 @@ public: static DialogManager &getInstance(); - sigc::signal show_dialogs; - sigc::signal show_f12; - sigc::signal hide_dialogs; - sigc::signal hide_f12; - sigc::signal transientize; + // sigc::signal show_dialogs; + // sigc::signal show_f12; + // sigc::signal hide_dialogs; + // sigc::signal hide_f12; + // sigc::signal transientize; /* generic dialog management start */ typedef std::map FactoryMap; diff --git a/src/ui/dialog/prototype.cpp b/src/ui/dialog/prototype.cpp index c28f37c6a..b3bf60aab 100644 --- a/src/ui/dialog/prototype.cpp +++ b/src/ui/dialog/prototype.cpp @@ -46,9 +46,14 @@ Prototype::Prototype() : sigc::mem_fun(*this, &Prototype::handleDesktopChanged) ); desktopTracker.connect(GTK_WIDGET(gobj())); + // This results in calling handleDocumentReplaced twice. Fix me! connectionDocumentReplaced = getDesktop()->connectDocumentReplaced( sigc::mem_fun(this, &Prototype::handleDocumentReplaced)); + // Alternative mechanism but results in calling handleDocumentReplaced four times. + // signalDocumentReplaced().connect( + // sigc::mem_fun(this, &Prototype::handleDocumentReplaced)); + connectionSelectionChanged = getDesktop()->getSelection()->connectChanged( sigc::hide(sigc::mem_fun(this, &Prototype::handleSelectionChanged))); diff --git a/src/ui/widget/panel.h b/src/ui/widget/panel.h index 9cbf39de9..b5498498d 100644 --- a/src/ui/widget/panel.h +++ b/src/ui/widget/panel.h @@ -104,6 +104,7 @@ public: void setDefaultResponse(int response_id); void setResponseSensitive(int response_id, bool setting); + /* Return signals. Signals emited by PanelDialog. */ virtual sigc::signal &signalDocumentReplaced(); virtual sigc::signal &signalActivateDesktop(); virtual sigc::signal &signalDeactiveDesktop(); -- cgit v1.2.3