From d57824529dd42757b4f6e51348ac692c86ad6d7d Mon Sep 17 00:00:00 2001
From: Markus Engel <markus.engel@tum.de>
Date: Mon, 21 Oct 2013 13:06:31 +0200
Subject: Fix bug introduced in r12686.

Fixed bugs:
  - https://launchpad.net/bugs/1241034

(bzr r12702)
---
 src/sp-object.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

(limited to 'src')

diff --git a/src/sp-object.cpp b/src/sp-object.cpp
index 8c54caf48..2408370cf 100644
--- a/src/sp-object.cpp
+++ b/src/sp-object.cpp
@@ -648,11 +648,6 @@ void SPObject::build(SPDocument *document, Inkscape::XML::Node *repr) {
         try {
             const std::string typeString = NodeTraits::get_type_string(*rchild);
 
-            // special cases
-            if (typeString.empty()) continue;      // comments, usually
-            if (typeString == "rdf:RDF") continue; // no SP node yet
-            if (typeString == "inkscape:clipboard") continue; // SP node not necessary
-
             SPObject* child = SPFactory::instance().createObject(typeString);
 
             object->attach(child, object->lastChild());
@@ -663,7 +658,7 @@ void SPObject::build(SPDocument *document, Inkscape::XML::Node *repr) {
             // corresponding classes in the SPObject tree.
             // (rdf:RDF, inkscape:clipboard, ...)
             // Thus, simply ignore this case for now.
-            return;
+            continue;
         }
     }
 }
-- 
cgit v1.2.3


From 80aa53929288d194a42fa4bc81560718598198ca Mon Sep 17 00:00:00 2001
From: Markus Engel <markus.engel@tum.de>
Date: Mon, 21 Oct 2013 13:07:45 +0200
Subject: Fix mesh gradient tool.

Fixed bugs:
  - https://launchpad.net/bugs/1239430

(bzr r12703)
---
 src/sp-gradient.cpp | 29 +++++++++++++++++------------
 1 file changed, 17 insertions(+), 12 deletions(-)

(limited to 'src')

diff --git a/src/sp-gradient.cpp b/src/sp-gradient.cpp
index adfff3609..04fb18cf3 100644
--- a/src/sp-gradient.cpp
+++ b/src/sp-gradient.cpp
@@ -418,23 +418,28 @@ void SPGradient::remove_child(Inkscape::XML::Node *child)
 void SPGradient::modified(guint flags)
 {
     if (flags & SP_OBJECT_CHILD_MODIFIED_FLAG) {
-    	// CPPIFY
+        // CPPIFY
+        // This comparison has never worked (i. e. always evaluated to false),
+        // the right value would have been SP_TYPE_MESHGRADIENT
         //if( this->get_type() != SP_GRADIENT_TYPE_MESH ) {
-    	if (!SP_IS_MESHGRADIENT(this)) {
-            this->invalidateVector();
-        } else {
-            this->invalidateArray();
-        }
+//        if (!SP_IS_MESHGRADIENT(this)) {
+//            this->invalidateVector();
+//        } else {
+//            this->invalidateArray();
+//        }
+        this->invalidateVector();
     }
 
     if (flags & SP_OBJECT_STYLE_MODIFIED_FLAG) {
-    	// CPPIFY
+        // CPPIFY
+        // see above
         //if( this->get_type() != SP_GRADIENT_TYPE_MESH ) {
-    	if (!SP_IS_MESHGRADIENT(this)) {
-            this->ensureVector();
-        } else {
-            this->ensureArray();
-        }
+//        if (!SP_IS_MESHGRADIENT(this)) {
+//            this->ensureVector();
+//        } else {
+//            this->ensureArray();
+//        }
+        this->ensureVector();
     }
 
     if (flags & SP_OBJECT_MODIFIED_FLAG) flags |= SP_OBJECT_PARENT_MODIFIED_FLAG;
-- 
cgit v1.2.3