From 89c1effb9a63177251f759bee7c2e76cec06c2cd Mon Sep 17 00:00:00 2001 From: Karl Cheng Date: Wed, 22 May 2019 21:31:09 +1000 Subject: Remove custom tab order in Document Properties The method for handling custom tab order in GTK (set_focus_chain) has been deprecated since GTK 3.24 with no direct replacement. I've decided to remove this code as the code did not seem to make any difference during testing: the tab order appeared to be the same. Regardless, 'Page -> Custom size' in Document Properties is the only place that it's used, so the impact should be fairly limited anyway. --- src/ui/widget/page-sizer.cpp | 7 ------- src/ui/widget/page-sizer.h | 1 - 2 files changed, 8 deletions(-) (limited to 'src') diff --git a/src/ui/widget/page-sizer.cpp b/src/ui/widget/page-sizer.cpp index a193f84da..bd7409a0c 100644 --- a/src/ui/widget/page-sizer.cpp +++ b/src/ui/widget/page-sizer.cpp @@ -191,13 +191,6 @@ PageSizer::PageSizer(Registry & _wr) _customDimTable.attach(_fitPageMarginExpander, 0, 1, 3, 1); - _dimTabOrderList.clear(); - _dimTabOrderList.push_back(&_dimensionWidth); - _dimTabOrderList.push_back(&_dimensionHeight); - _dimTabOrderList.push_back(&_dimensionUnits); - _dimTabOrderList.push_back(&_fitPageMarginExpander); - _customDimTable.set_focus_chain(_dimTabOrderList); - //## Set up fit page expander _fitPageMarginExpander.set_use_underline(); _fitPageMarginExpander.set_label(_("Resi_ze page to content...")); diff --git a/src/ui/widget/page-sizer.h b/src/ui/widget/page-sizer.h index 54ffb9c73..b399835b7 100644 --- a/src/ui/widget/page-sizer.h +++ b/src/ui/widget/page-sizer.h @@ -224,7 +224,6 @@ protected: RegisteredUnitMenu _dimensionUnits; RegisteredScalarUnit _dimensionWidth; RegisteredScalarUnit _dimensionHeight; - std::vector _dimTabOrderList; //### Fit Page options Gtk::Expander _fitPageMarginExpander; -- cgit v1.2.3