From a61d70d8ef1325f238d197b9e09858fc5f5e7684 Mon Sep 17 00:00:00 2001
From: Jabiertxof <jabier.arraiza@marker.es>
Date: Wed, 24 Oct 2018 20:02:00 +0200
Subject: Add fixes in review.

---
 src/live_effects/lpe-knot.cpp |  4 ++--
 src/object/sp-ellipse.cpp     | 14 ++++++--------
 2 files changed, 8 insertions(+), 10 deletions(-)

(limited to 'src')

diff --git a/src/live_effects/lpe-knot.cpp b/src/live_effects/lpe-knot.cpp
index 0fd5af752..051018c43 100644
--- a/src/live_effects/lpe-knot.cpp
+++ b/src/live_effects/lpe-knot.cpp
@@ -418,7 +418,7 @@ LPEKnot::doEffect_path (Geom::PathVector const &path_in)
         unsigned i0 = 0;
         Inkscape::Preferences *prefs = Inkscape::Preferences::get();
         gint precision = prefs->getInt("/options/svgoutput/numericprecision");
-        prefs->setInt("/options/svgoutput/numericprecision", 4); // thinc is enogught to minor diferences
+        prefs->setInt("/options/svgoutput/numericprecision", 4); // I think this is enough for minor differences
         for (i0=0; i0<gpaths.size(); i0++){
             if (!strcmp(sp_svg_write_path(original_pathv[comp]), sp_svg_write_path(gpaths[i0])))
                 break;
@@ -660,7 +660,7 @@ void LPEKnot::addKnotHolderEntities(KnotHolder *knotholder, SPItem *item)
 {
     KnotHolderEntity *e = new KnotHolderEntityCrossingSwitcher(this);
     e->create(nullptr, item, knotholder, Inkscape::CTRL_TYPE_UNKNOWN,
-              _("Drag to select a crossing, click to flip it, CTRL + click to update all crossings"));
+              _("Drag to select a crossing, click to flip it, Ctrl + click to update all crossings"));
     knotholder->add(e);
 };
 
diff --git a/src/object/sp-ellipse.cpp b/src/object/sp-ellipse.cpp
index 0623fbf0c..23736b786 100644
--- a/src/object/sp-ellipse.cpp
+++ b/src/object/sp-ellipse.cpp
@@ -461,14 +461,12 @@ void SPGenericEllipse::set_shape()
     if (this->_isSlice() && this->arc_type == SP_GENERIC_ELLIPSE_ARC_TYPE_SLICE) {
         pb.lineTo(Geom::Point(0, 0));
     }
-    //    If convert to paths ellipses become unclosed so comment this and call "closePath"
-    //    Remove later
-    //    if ( !(this->arc_type == SP_GENERIC_ELLIPSE_ARC_TYPE_ARC) ) {
-    //        pb.closePath();
-    //    } else {
-    //        pb.flush();
-    //    }
-    pb.closePath();
+
+    if ( !(this->arc_type == SP_GENERIC_ELLIPSE_ARC_TYPE_ARC) ) {
+        pb.closePath();
+    } else {
+        pb.flush();
+    }
     c = new SPCurve(pb.peek());
 
     // gchar *str = sp_svg_write_path(curve->get_pathvector());
-- 
cgit v1.2.3