diff options
| author | Eduard Braun <eduard.braun2@gmx.de> | 2017-10-10 20:03:40 +0000 |
|---|---|---|
| committer | Eduard Braun <eduard.braun2@gmx.de> | 2017-10-10 20:03:40 +0000 |
| commit | 27fa4199a27db67909887170a08927eade42e465 (patch) | |
| tree | 713e2f1d127effe8a930b532ac7757ff9197ad9d /src/CMakeLists.txt | |
| parent | root dir tidying: remove mingwenv.bat / msysenv.sh (diff) | |
| download | inkscape-27fa4199a27db67909887170a08927eade42e465.tar.gz inkscape-27fa4199a27db67909887170a08927eade42e465.zip | |
Cleanup: remove unused winmain.cpp
While we were diligently compiling and maintaining it, the WinMain
entry point was completely unused for quite some time now
(if it was ever used).
gcc is perfectly happy with the standard main() entry point and even
MSVC should be able to work with alternative entry point names
(if anybody was bold enough to actually compile Inkscape that way)
Note regarding code for output redirection:
The code that was introduced in 378a6384e55bdb8c5750c051fd91302f64d2b69a
in order to achieve console output from inkscape.exe
(see comment in winconsole.cpp why this does not work by default)
works in principle, but has a number of issues
- it immediately exits (control is returned to the console)
rendering it unsuitable (or even harmful) for script usage
- despite returning control to the console Inkscape continues to
print messages to it messing up any other output
- standard input (stdin) is not working at all
The solution of using console wrappers from b8859cd12327c84f5ca8d4bf8614f0d0913d3c25
is therefore still the preferable solution, see also
https://bugs.launchpad.net/inkscape/+bug/520532 for details.
Diffstat (limited to 'src/CMakeLists.txt')
| -rw-r--r-- | src/CMakeLists.txt | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 4b3357d30..09d6d25d4 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -481,7 +481,6 @@ if(WIN32) list(APPEND main_SRC registrytool.h registrytool.cpp - winmain.cpp ) # Configure and add the platform specific resource files (enabling the app icon). |
