diff options
| author | Jon A. Cruz <jon@joncruz.org> | 2007-09-24 16:10:40 +0000 |
|---|---|---|
| committer | joncruz <joncruz@users.sourceforge.net> | 2007-09-24 16:10:40 +0000 |
| commit | 7694b9a0a85e2755f1b89c266c1c7cae3b450438 (patch) | |
| tree | f58b05b531cd4895da3c023d69a4631185296be4 /src/dialogs | |
| parent | 1781868 Faster win32 installer start-up, readded catalan for installer (diff) | |
| download | inkscape-7694b9a0a85e2755f1b89c266c1c7cae3b450438.tar.gz inkscape-7694b9a0a85e2755f1b89c266c1c7cae3b450438.zip | |
Fixed unsafe hardcoding of buffer size
(bzr r3791)
Diffstat (limited to 'src/dialogs')
| -rw-r--r-- | src/dialogs/clonetiler.cpp | 6 | ||||
| -rw-r--r-- | src/dialogs/swatches.cpp | 6 |
2 files changed, 6 insertions, 6 deletions
diff --git a/src/dialogs/clonetiler.cpp b/src/dialogs/clonetiler.cpp index fe370c522..f6d3b0309 100644 --- a/src/dialogs/clonetiler.cpp +++ b/src/dialogs/clonetiler.cpp @@ -149,7 +149,7 @@ on_picker_color_changed (guint rgba) Inkscape::XML::Node *repr = inkscape_get_repr(INKSCAPE, prefs_path); gchar c[32]; - sp_svg_write_color(c, 32, rgba); + sp_svg_write_color(c, sizeof(c), rgba); repr->setAttribute("initial_color", c); is_updating = false; @@ -1167,7 +1167,7 @@ clonetiler_apply (GtkWidget *widget, void *) float rgb[3]; sp_color_hsl_to_rgb_floatv (rgb, hsl[0], hsl[1], hsl[2]); - sp_svg_write_color(color_string, 32, SP_RGBA32_F_COMPOSE(rgb[0], rgb[1], rgb[2], 1.0)); + sp_svg_write_color(color_string, sizeof(color_string), SP_RGBA32_F_COMPOSE(rgb[0], rgb[1], rgb[2], 1.0)); } // Blur @@ -1278,7 +1278,7 @@ clonetiler_apply (GtkWidget *widget, void *) opacity *= val; } if (pick_to_color) { - sp_svg_write_color(color_string, 32, rgba); + sp_svg_write_color(color_string, sizeof(color_string), rgba); } } diff --git a/src/dialogs/swatches.cpp b/src/dialogs/swatches.cpp index 3a41c1ec4..fb302c110 100644 --- a/src/dialogs/swatches.cpp +++ b/src/dialogs/swatches.cpp @@ -332,7 +332,7 @@ static bool bruteForce( SPDocument* document, Inkscape::XML::Node* node, Glib::u SPObject *obj = document->getObjectByRepr( node ); gchar c[64] = {0}; - sp_svg_write_color( c, 64, SP_RGBA32_U_COMPOSE( r, g, b, 0xff ) ); + sp_svg_write_color( c, sizeof(c), SP_RGBA32_U_COMPOSE( r, g, b, 0xff ) ); SPCSSAttr *css = sp_repr_css_attr_new(); sp_repr_css_set_property( css, "fill", c ); @@ -347,7 +347,7 @@ static bool bruteForce( SPDocument* document, Inkscape::XML::Node* node, Glib::u SPObject *obj = document->getObjectByRepr( node ); gchar c[64] = {0}; - sp_svg_write_color( c, 64, SP_RGBA32_U_COMPOSE( r, g, b, 0xff ) ); + sp_svg_write_color( c, sizoef(c), SP_RGBA32_U_COMPOSE( r, g, b, 0xff ) ); SPCSSAttr *css = sp_repr_css_attr_new(); sp_repr_css_set_property( css, "stroke", c ); @@ -562,7 +562,7 @@ void ColorItem::buttonClicked(bool secondary) char const * attrName = secondary ? "stroke" : "fill"; guint32 rgba = (def.getR() << 24) | (def.getG() << 16) | (def.getB() << 8) | 0xff; gchar c[64]; - sp_svg_write_color(c, 64, rgba); + sp_svg_write_color(c, sizeof(c), rgba); SPCSSAttr *css = sp_repr_css_attr_new(); sp_repr_css_set_property( css, attrName, c ); |