summaryrefslogtreecommitdiffstats
path: root/src/display/inkscape-cairo.cpp
diff options
context:
space:
mode:
authorbulia byak <buliabyak@gmail.com>2008-09-01 23:05:38 +0000
committerbuliabyak <buliabyak@users.sourceforge.net>2008-09-01 23:05:38 +0000
commit486454d43ccc3e8866aaeb1dd69d34649401ad69 (patch)
tree7717ab942710c4cf512590b2aebea4579d90beac /src/display/inkscape-cairo.cpp
parentuse smaller subpixel scaling; large values take more memory and sometimes fai... (diff)
downloadinkscape-486454d43ccc3e8866aaeb1dd69d34649401ad69.tar.gz
inkscape-486454d43ccc3e8866aaeb1dd69d34649401ad69.zip
comment update
(bzr r6754)
Diffstat (limited to 'src/display/inkscape-cairo.cpp')
-rw-r--r--src/display/inkscape-cairo.cpp10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/display/inkscape-cairo.cpp b/src/display/inkscape-cairo.cpp
index 4895418f0..2ef726aab 100644
--- a/src/display/inkscape-cairo.cpp
+++ b/src/display/inkscape-cairo.cpp
@@ -194,11 +194,19 @@ feed_path_to_cairo (cairo_t *ct, Geom::Path const &path, Geom::Matrix trans, boo
if (path.closed()) {
cairo_line_to(ct, initial[0], initial[1]);
- /* It seems we cannot use cairo_close_path(ct) here; maybe because some parts of the path have been clipped and not drawn (maybe the before last segment was outside view area)
+ /* We cannot use cairo_close_path(ct) here because some parts of the path may have been
+ clipped and not drawn (maybe the before last segment was outside view area), which
+ would result in closing the "subpath" after the last interruption, not the entire path.
+
However, according to cairo documentation:
The behavior of cairo_close_path() is distinct from simply calling cairo_line_to() with the equivalent coordinate
in the case of stroking. When a closed sub-path is stroked, there are no caps on the ends of the sub-path. Instead,
there is a line join connecting the final and initial segments of the sub-path.
+
+ The correct fix will be possible when cairo introduces methods for moving without
+ ending/starting subpaths, which we will use for skipping invisible segments; then we
+ will be able to use cairo_close_path here. This issue also affects ps/eps/pdf export,
+ see bug 168129
*/
}
}