diff options
| author | Rick Yorgason <rick@firefang.com> | 2018-10-18 08:21:15 +0000 |
|---|---|---|
| committer | Rick Yorgason <rick@firefang.com> | 2018-10-18 08:21:15 +0000 |
| commit | 83bf2fdf80496f0368438e16bc3adb8ee0e86fb7 (patch) | |
| tree | 83d50e748c8fb85ea4bbcd267c9b5364722e4841 /src/display | |
| parent | New "Outline thin strokes" view mode which draws thin strokes in outline mode... (diff) | |
| download | inkscape-83bf2fdf80496f0368438e16bc3adb8ee0e86fb7.tar.gz inkscape-83bf2fdf80496f0368438e16bc3adb8ee0e86fb7.zip | |
Renamed "Outline thin strokes" to "visible hairlines" to make the intent clearer.
Diffstat (limited to 'src/display')
| -rw-r--r-- | src/display/drawing-shape.cpp | 28 | ||||
| -rw-r--r-- | src/display/drawing-text.cpp | 13 | ||||
| -rw-r--r-- | src/display/drawing.cpp | 6 | ||||
| -rw-r--r-- | src/display/drawing.h | 2 | ||||
| -rw-r--r-- | src/display/rendermode.h | 2 |
5 files changed, 26 insertions, 25 deletions
diff --git a/src/display/drawing-shape.cpp b/src/display/drawing-shape.cpp index c2208d161..05123297e 100644 --- a/src/display/drawing-shape.cpp +++ b/src/display/drawing-shape.cpp @@ -186,13 +186,13 @@ DrawingShape::_renderStroke(DrawingContext &dc) } _nrstyle.applyStroke(dc); - // Special handling for thin outline mode when we're drawing lines smaller than half a - // pixel - if (_drawing.outlineThin()) { - double outline_thin_size = 0.5, trash = 0.5; - dc.device_to_user_distance(outline_thin_size, trash); - if (_nrstyle.stroke_width < outline_thin_size) { - dc.setLineWidth(outline_thin_size); + // If the draw mode is set to visible hairlines, don't let them get smaller than half a + // pixel. + if (_drawing.visibleHairlines()) { + double half_pixel_size = 0.5, trash = 0.5; + dc.device_to_user_distance(half_pixel_size, trash); + if (_nrstyle.stroke_width < half_pixel_size) { + dc.setLineWidth(half_pixel_size); } } @@ -267,13 +267,13 @@ DrawingShape::_renderItem(DrawingContext &dc, Geom::IntRect const &area, unsigne if (has_stroke) { _nrstyle.applyStroke(dc); - // Special handling for thin outline mode when we're drawing lines smaller than - // half a pixel - if (_drawing.outlineThin()) { - double outline_thin_size = 0.5, trash = 0.5; - dc.device_to_user_distance(outline_thin_size, trash); - if (_nrstyle.stroke_width < outline_thin_size) { - dc.setLineWidth(outline_thin_size); + // If the draw mode is set to visible hairlines, don't let anything get smaller + // than half a pixel. + if (_drawing.visibleHairlines()) { + double half_pixel_size = 0.5, trash = 0.5; + dc.device_to_user_distance(half_pixel_size, trash); + if (_nrstyle.stroke_width < half_pixel_size) { + dc.setLineWidth(half_pixel_size); } } diff --git a/src/display/drawing-text.cpp b/src/display/drawing-text.cpp index b48ce7d31..d823012e3 100644 --- a/src/display/drawing-text.cpp +++ b/src/display/drawing-text.cpp @@ -604,12 +604,13 @@ unsigned DrawingText::_renderItem(DrawingContext &dc, Geom::IntRect const &/*are if (has_stroke) { _nrstyle.applyStroke(dc); - // Special handling for thin outline mode when we're drawing lines smaller than half a pixel - if (_drawing.outlineThin()) { - double outline_thin_size = 0.5, trash = 0.5; - dc.device_to_user_distance(outline_thin_size, trash); - if (_nrstyle.stroke_width < outline_thin_size) { - dc.setLineWidth(outline_thin_size); + // If the draw mode is set to visible hairlines, don't let anything get smaller + // than half a pixel. + if (_drawing.visibleHairlines()) { + double half_pixel_size = 0.5, trash = 0.5; + dc.device_to_user_distance(half_pixel_size, trash); + if (_nrstyle.stroke_width < half_pixel_size) { + dc.setLineWidth(half_pixel_size); } } diff --git a/src/display/drawing.cpp b/src/display/drawing.cpp index 7ecaea987..4b2a2cadf 100644 --- a/src/display/drawing.cpp +++ b/src/display/drawing.cpp @@ -79,14 +79,14 @@ Drawing::outline() const return renderMode() == RENDERMODE_OUTLINE; } bool -Drawing::outlineThin() const +Drawing::visibleHairlines() const { - return renderMode() == RENDERMODE_OUTLINE_THIN; + return renderMode() == RENDERMODE_VISIBLE_HAIRLINES; } bool Drawing::renderFilters() const { - return renderMode() == RENDERMODE_NORMAL || renderMode() == RENDERMODE_OUTLINE_THIN; + return renderMode() == RENDERMODE_NORMAL || renderMode() == RENDERMODE_VISIBLE_HAIRLINES; } int Drawing::blurQuality() const diff --git a/src/display/drawing.h b/src/display/drawing.h index 1669cc3a4..931fe8e46 100644 --- a/src/display/drawing.h +++ b/src/display/drawing.h @@ -50,7 +50,7 @@ public: RenderMode renderMode() const; ColorMode colorMode() const; bool outline() const; - bool outlineThin() const; + bool visibleHairlines() const; bool renderFilters() const; int blurQuality() const; int filterQuality() const; diff --git a/src/display/rendermode.h b/src/display/rendermode.h index 36dd0ead3..80e6da2dd 100644 --- a/src/display/rendermode.h +++ b/src/display/rendermode.h @@ -13,7 +13,7 @@ enum RenderMode { RENDERMODE_NORMAL, RENDERMODE_NO_FILTERS, RENDERMODE_OUTLINE, - RENDERMODE_OUTLINE_THIN + RENDERMODE_VISIBLE_HAIRLINES }; enum ColorMode { |
