diff options
| author | Johan B. C. Engelen <jbc.engelen@swissonline.ch> | 2014-02-20 17:58:24 +0000 |
|---|---|---|
| committer | Johan B. C. Engelen <j.b.c.engelen@alumnus.utwente.nl> | 2014-02-20 17:58:24 +0000 |
| commit | bf6ba105405a7eac70f1d36490d51962a4041ac0 (patch) | |
| tree | 5f0a6ad720d952d9138afb85c1778464c2ce7d1d /src/document.cpp | |
| parent | Add test for URI and help with data uris. (diff) | |
| download | inkscape-bf6ba105405a7eac70f1d36490d51962a4041ac0.tar.gz inkscape-bf6ba105405a7eac70f1d36490d51962a4041ac0.zip | |
Reverting r13045.
1. It contains a memleak
realpath allocates new memory if the second argument is NULL. In the added code, this memory is never freed.
2. Breaks build on Windows (realpath(...) not found)
3. Please don't add functions that use C-strings unnecessarily.
Simply rewrite parseDataUri to parseDataUri(const std::string &uri), and use C++'s string methods. ("#include <cstring.h>" is a huge red flag upon code review)
4. Please read this about "realpath"
http://insanecoding.blogspot.ch/2007/11/pathmax-simply-isnt.html
(bzr r13046)
Diffstat (limited to 'src/document.cpp')
0 files changed, 0 insertions, 0 deletions