diff options
| author | Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> | 2018-06-18 18:54:25 +0000 |
|---|---|---|
| committer | Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> | 2018-06-18 18:54:25 +0000 |
| commit | 5a5b61fa8085a8c5eec59614834cb882d1d778e2 (patch) | |
| tree | 848df1de494bcdae296dcaf1de4a164cbaaec780 /src/extension | |
| parent | Run clang-tidy’s modernize-pass-by-value pass. (diff) | |
| download | inkscape-5a5b61fa8085a8c5eec59614834cb882d1d778e2.tar.gz inkscape-5a5b61fa8085a8c5eec59614834cb882d1d778e2.zip | |
Run clang-tidy’s modernize-use-bool-literals pass.
This makes it clearer whether an integer or a boolean has to be passed
in this specific call.
Diffstat (limited to 'src/extension')
| -rw-r--r-- | src/extension/internal/cairo-renderer.cpp | 2 | ||||
| -rw-r--r-- | src/extension/internal/emf-inout.cpp | 2 | ||||
| -rw-r--r-- | src/extension/internal/emf-print.cpp | 6 | ||||
| -rw-r--r-- | src/extension/internal/odf.cpp | 4 | ||||
| -rw-r--r-- | src/extension/internal/odf.h | 2 | ||||
| -rw-r--r-- | src/extension/internal/pdfinput/pdf-parser.cpp | 6 | ||||
| -rw-r--r-- | src/extension/internal/pdfinput/svg-builder.cpp | 2 | ||||
| -rw-r--r-- | src/extension/internal/wmf-inout.cpp | 8 |
8 files changed, 16 insertions, 16 deletions
diff --git a/src/extension/internal/cairo-renderer.cpp b/src/extension/internal/cairo-renderer.cpp index c7cd35eb2..c06119391 100644 --- a/src/extension/internal/cairo-renderer.cpp +++ b/src/extension/internal/cairo-renderer.cpp @@ -403,7 +403,7 @@ static void sp_symbol_render(SPSymbol *symbol, CairoRenderContext *ctx) ctx->transform(symbol->c2p); // apply viewbox if set - if (0 /*symbol->viewBox_set*/) { + if (false /*symbol->viewBox_set*/) { Geom::Affine vb2user; double x, y, width, height; double view_width, view_height; diff --git a/src/extension/internal/emf-inout.cpp b/src/extension/internal/emf-inout.cpp index 549d4300e..e34d73cca 100644 --- a/src/extension/internal/emf-inout.cpp +++ b/src/extension/internal/emf-inout.cpp @@ -2920,7 +2920,7 @@ std::cout << "BEFORE DRAW" } } - if (0 && strlen(tmp_str.str().c_str())) { + if (false && strlen(tmp_str.str().c_str())) { tmp_outsvg << " <!-- \""; tmp_outsvg << tmp_str.str().c_str(); tmp_outsvg << "\" -->\n"; diff --git a/src/extension/internal/emf-print.cpp b/src/extension/internal/emf-print.cpp index 548caea95..add2f0d37 100644 --- a/src/extension/internal/emf-print.cpp +++ b/src/extension/internal/emf-print.cpp @@ -245,7 +245,7 @@ unsigned int PrintEmf::begin(Inkscape::Extension::Print *mod, SPDocument *doc) } - if (1) { + if (true) { snprintf(buff, sizeof(buff) - 1, "Screen=%dx%dpx, %dx%dmm", PixelsX, PixelsY, MMX, MMY); rec = textcomment_set(buff); if (!rec || emf_append((PU_ENHMETARECORD)rec, et, U_REC_FREE)) { @@ -1007,7 +1007,7 @@ void PrintEmf::do_clip_if_present(SPStyle const *style){ /* find the first clip_ref at object or up the stack. There may not be one. */ SPClipPath *scp = nullptr; SPItem *item = SP_ITEM(style->object); - while(1) { + while(true) { scp = (item->clip_ref ? item->clip_ref->getObject() : nullptr); if(scp)break; item = SP_ITEM(item->parent); @@ -1029,7 +1029,7 @@ void PrintEmf::do_clip_if_present(SPStyle const *style){ */ Geom::Affine tf = item->transform; SPItem *scan_item = item; - while(1) { + while(true) { scan_item = SP_ITEM(scan_item->parent); if(!scan_item)break; tf *= scan_item->transform; diff --git a/src/extension/internal/odf.cpp b/src/extension/internal/odf.cpp index 18092873e..bd036da05 100644 --- a/src/extension/internal/odf.cpp +++ b/src/extension/internal/odf.cpp @@ -1696,8 +1696,8 @@ bool OdfOutput::writeTree(Writer &couts, Writer &souts, Glib::ustring outputStroke; Glib::ustring outputStyle; - processGradient(item, id, tf, gradientNameFill, outputFill, 1); - processGradient(item, id, tf, gradientNameStroke, outputStroke, 0); + processGradient(item, id, tf, gradientNameFill, outputFill, true); + processGradient(item, id, tf, gradientNameStroke, outputStroke, false); souts.writeUString(outputFill); souts.writeUString(outputStroke); diff --git a/src/extension/internal/odf.h b/src/extension/internal/odf.h index e92bc1249..691d6e1f7 100644 --- a/src/extension/internal/odf.h +++ b/src/extension/internal/odf.h @@ -311,7 +311,7 @@ private: bool processStyle(SPItem *item, const Glib::ustring &id, const Glib::ustring &gradientNameFill, const Glib::ustring &gradientNameStroke, Glib::ustring& output); bool processGradient(SPItem *item, - const Glib::ustring &id, Geom::Affine &tf, Glib::ustring& gradientName, Glib::ustring& output, bool checkFillGradient = 1); + const Glib::ustring &id, Geom::Affine &tf, Glib::ustring& gradientName, Glib::ustring& output, bool checkFillGradient = true); bool writeStyleHeader(Writer &outs); diff --git a/src/extension/internal/pdfinput/pdf-parser.cpp b/src/extension/internal/pdfinput/pdf-parser.cpp index b81d7abcb..5fa21263a 100644 --- a/src/extension/internal/pdfinput/pdf-parser.cpp +++ b/src/extension/internal/pdfinput/pdf-parser.cpp @@ -1759,7 +1759,7 @@ void PdfParser::doShadingPatternFillFallback(GfxShadingPattern *sPat, saveState(); // clip to bbox - if (0 ){//shading->getHasBBox()) { + if (false ){//shading->getHasBBox()) { shading->getBBox(&xMin, &yMin, &xMax, &yMax); state->moveTo(xMin, yMin); state->lineTo(xMax, yMin); @@ -2599,7 +2599,7 @@ void PdfParser::doShowText(const GooString *s) { builder->beginString(state); // handle a Type 3 char - if (font->getType() == fontType3 && 0) {//out->interpretType3Chars()) { + if (font->getType() == fontType3 && false) {//out->interpretType3Chars()) { mat = state->getCTM(); for (int i = 0; i < 6; ++i) { oldCTM[i] = mat[i]; @@ -2644,7 +2644,7 @@ void PdfParser::doShowText(const GooString *s) { state->setCTM(newCTM[0], newCTM[1], newCTM[2], newCTM[3], x, y); //~ the CTM concat values here are wrong (but never used) //out->updateCTM(state, 1, 0, 0, 1, 0, 0); - if (0){ /*!out->beginType3Char(state, curX + riseX, curY + riseY, tdx, tdy, + if (false){ /*!out->beginType3Char(state, curX + riseX, curY + riseY, tdx, tdy, code, u, uLen)) {*/ #if defined(POPPLER_NEW_OBJECT_API) charProc = ((Gfx8BitFont *)font)->getCharProc(code); diff --git a/src/extension/internal/pdfinput/svg-builder.cpp b/src/extension/internal/pdfinput/svg-builder.cpp index c8e24a5e1..3fdc3db55 100644 --- a/src/extension/internal/pdfinput/svg-builder.cpp +++ b/src/extension/internal/pdfinput/svg-builder.cpp @@ -1255,7 +1255,7 @@ void SvgBuilder::_flushText() { Glib::ustring text_buffer; // Output all buffered glyphs - while (1) { + while (true) { const SvgGlyph& glyph = (*i); std::vector<SvgGlyph>::iterator prev_iterator = i - 1; // Check if we need to make a new tspan diff --git a/src/extension/internal/wmf-inout.cpp b/src/extension/internal/wmf-inout.cpp index db7c9c9ce..bcc8aea85 100644 --- a/src/extension/internal/wmf-inout.cpp +++ b/src/extension/internal/wmf-inout.cpp @@ -1252,8 +1252,8 @@ Wmf::delete_object(PWMF_CALLBACK_DATA d, int index) d->dc[d->level].style.font_size.computed = 16.0; d->dc[d->level].style.font_weight.value = SP_CSS_FONT_WEIGHT_400; d->dc[d->level].style.font_style.value = SP_CSS_FONT_STYLE_NORMAL; - d->dc[d->level].style.text_decoration_line.underline = 0; - d->dc[d->level].style.text_decoration_line.line_through = 0; + d->dc[d->level].style.text_decoration_line.underline = false; + d->dc[d->level].style.text_decoration_line.line_through = false; d->dc[d->level].style.baseline_shift.value = 0; } @@ -3119,8 +3119,8 @@ Wmf::open( Inkscape::Extension::Input * /*mod*/, const gchar *uri ) d.dc[0].style.font_size.computed = 16.0; d.dc[0].style.font_weight.value = SP_CSS_FONT_WEIGHT_400; d.dc[0].style.font_style.value = SP_CSS_FONT_STYLE_NORMAL; - d.dc[0].style.text_decoration_line.underline = 0; - d.dc[0].style.text_decoration_line.line_through = 0; + d.dc[0].style.text_decoration_line.underline = false; + d.dc[0].style.text_decoration_line.line_through = false; d.dc[0].style.baseline_shift.value = 0; // Default pen, WMF files that do not specify a pen are unlikely to look very good! |
