diff options
| author | Bryce Harrington <bryce@bryceharrington.org> | 2014-09-14 23:03:29 +0000 |
|---|---|---|
| committer | bryce <bryce@ubuntu.com> | 2014-09-14 23:03:29 +0000 |
| commit | 70f0a1b307456191c5f2ce103d3edbf4ca23d514 (patch) | |
| tree | fff9aec49679a4fa44b908f901080c0ebaf7e0dd /src/inkscape.cpp | |
| parent | Fix GTK3 build (diff) | |
| download | inkscape-70f0a1b307456191c5f2ce103d3edbf4ca23d514.tar.gz inkscape-70f0a1b307456191c5f2ce103d3edbf4ca23d514.zip | |
Always check result of sp_repr_read_mem for NULL
In cases where undefined or invalid XML is passed to sp_repr_read_mem(),
it will indicate failure by returning NULL. All callers must check for
this and handle the error condition accordingly.
Fixes: lp: #1170248
Fixed bugs:
- https://launchpad.net/bugs/1170248
(bzr r13556)
Diffstat (limited to 'src/inkscape.cpp')
| -rw-r--r-- | src/inkscape.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/inkscape.cpp b/src/inkscape.cpp index 4b4c8c678..e312e15b9 100644 --- a/src/inkscape.cpp +++ b/src/inkscape.cpp @@ -945,7 +945,7 @@ bool inkscape_load_menus( Inkscape::Application * inkscape ) inkscape->menus = sp_repr_read_mem(menus_skeleton, MENUS_SKELETON_SIZE, NULL); } - return (inkscape->menus != 0); + return (inkscape->menus != NULL); } |