Make knotholders for LPE items finally work; each effect can now overload the addKnotHolderHandles() method to add handles which control its parameters.

There is now also a virtual onKnotUngrabbed() method for each knotholder entity which can be used to do cleanup tasks (for LPE parameters it currently writes the value to SVG, although this should probably happen automatically)

(bzr r5855)

1 files changed, 3 insertions, 3 deletions

diff --git a/src/live_effects/effect.h b/src/live_effects/effect.h
index a8cb525b8..c46c145b5 100644
--- a/src/live_effects/effect.h
+++ b/src/live_effects/effect.h
@@ -101,8 +101,9 @@ public:
 
     virtual void transform_multiply(Geom::Matrix const& postmul, bool set);
 
-    bool providesKnotholder() { return knotholder_func_vector.size() > 0; }
-    void addHandles(KnotHolder *knotholder);
+    virtual bool providesKnotholder() { return false; }
+    void addPointParamHandles(KnotHolder *knotholder, SPDesktop *desktop, SPItem *item);
+    virtual void addKnotHolderHandles(KnotHolder *knotholder, SPDesktop *desktop, SPItem *item);
 
     Glib::ustring          getName();
     Inkscape::XML::Node *  getRepr();
@@ -135,7 +136,6 @@ protected:
     Parameter * getNextOncanvasEditableParam();
 
     std::vector<Parameter *> param_vector;
-    std::vector<std::pair<SPKnotHolderSetFunc, SPKnotHolderGetFunc> > knotholder_func_vector;
     int oncanvasedit_it;
     BoolParam is_visible;