summaryrefslogtreecommitdiffstats
path: root/src/live_effects/parameter/vector.cpp
diff options
context:
space:
mode:
authorJohan B. C. Engelen <jbc.engelen@swissonline.ch>2011-10-28 22:15:36 +0000
committerJohan Engelen <goejendaagh@zonnet.nl>2011-10-28 22:15:36 +0000
commitf2ce84926660eba51119fa6720921c345d5a6e0e (patch)
tree59ff99f4f0865fed28a0d8974b1465f95e5bd2dc /src/live_effects/parameter/vector.cpp
parentfix potential null pointer deref (diff)
downloadinkscape-f2ce84926660eba51119fa6720921c345d5a6e0e.tar.gz
inkscape-f2ce84926660eba51119fa6720921c345d5a6e0e.zip
fix order of checks.
(bzr r10703)
Diffstat (limited to 'src/live_effects/parameter/vector.cpp')
-rw-r--r--src/live_effects/parameter/vector.cpp5
1 files changed, 4 insertions, 1 deletions
diff --git a/src/live_effects/parameter/vector.cpp b/src/live_effects/parameter/vector.cpp
index 9086ab376..6d0824ae0 100644
--- a/src/live_effects/parameter/vector.cpp
+++ b/src/live_effects/parameter/vector.cpp
@@ -53,9 +53,12 @@ bool
VectorParam::param_readSVGValue(const gchar * strvalue)
{
gchar ** strarray = g_strsplit(strvalue, ",", 4);
+ if (!strarray) {
+ return false;
+ }
double val[4];
unsigned int i = 0;
- while (strarray[i] && i < 4) {
+ while (i < 4 && strarray[i]) {
if (sp_svg_number_read_d(strarray[i], &val[i]) != 0) {
i++;
} else {