Run clang-tidy’s modernize-pass-by-value pass.

This avoids having to pass variables by reference before copying them
when calling a constructor.

4 files changed, 15 insertions, 11 deletions

diff --git a/src/live_effects/parameter/parameter.cpp b/src/live_effects/parameter/parameter.cpp
index 7ca3f04c8..d87bd4d1b 100644
--- a/src/live_effects/parameter/parameter.cpp
+++ b/src/live_effects/parameter/parameter.cpp
@@ -16,6 +16,8 @@
 
 #include <glibmm/i18n.h>
 
+#include <utility>
+
 #define noLPEREALPARAM_DEBUG
 
 namespace Inkscape {
@@ -23,15 +25,15 @@ namespace Inkscape {
 namespace LivePathEffect {
 
 
-Parameter::Parameter( const Glib::ustring& label, const Glib::ustring& tip,
-                      const Glib::ustring& key, Inkscape::UI::Widget::Registry* wr,
+Parameter::Parameter( Glib::ustring  label, Glib::ustring  tip,
+                      Glib::ustring  key, Inkscape::UI::Widget::Registry* wr,
                       Effect* effect )
-    : param_key(key),
+    : param_key(std::move(key)),
       param_wr(wr),
-      param_label(label),
+      param_label(std::move(label)),
       oncanvas_editable(false),
       widget_is_visible(true),
-      param_tooltip(tip),
+      param_tooltip(std::move(tip)),
       param_effect(effect)
 {
 }
diff --git a/src/live_effects/parameter/parameter.h b/src/live_effects/parameter/parameter.h
index 7454558db..040955e17 100644
--- a/src/live_effects/parameter/parameter.h
+++ b/src/live_effects/parameter/parameter.h
@@ -48,9 +48,9 @@ class Effect;
 
 class Parameter {
 public:
-    Parameter(  const Glib::ustring& label,
-                const Glib::ustring& tip,
-                const Glib::ustring& key,
+    Parameter(  Glib::ustring  label,
+                Glib::ustring  tip,
+                Glib::ustring  key,
                 Inkscape::UI::Widget::Registry* wr,
                 Effect* effect);
     virtual ~Parameter() = default;;
diff --git a/src/live_effects/parameter/togglebutton.cpp b/src/live_effects/parameter/togglebutton.cpp
index b5f7f5998..535e43dcf 100644
--- a/src/live_effects/parameter/togglebutton.cpp
+++ b/src/live_effects/parameter/togglebutton.cpp
@@ -8,6 +8,8 @@
 #include "ui/widget/registered-widget.h"
 #include <glibmm/i18n.h>
 
+#include <utility>
+
 #include "live_effects/parameter/togglebutton.h"
 #include "live_effects/effect.h"
 #include "svg/svg.h"
@@ -23,11 +25,11 @@ namespace LivePathEffect {
 
 ToggleButtonParam::ToggleButtonParam( const Glib::ustring& label, const Glib::ustring& tip,
                       const Glib::ustring& key, Inkscape::UI::Widget::Registry* wr,
-                      Effect* effect, bool default_value, const Glib::ustring& inactive_label,
+                      Effect* effect, bool default_value, Glib::ustring  inactive_label,
                       char const * _icon_active, char const * _icon_inactive, 
                       GtkIconSize _icon_size)
     : Parameter(label, tip, key, wr, effect), value(default_value), defvalue(default_value),
-      inactive_label(inactive_label), _icon_active(_icon_active), _icon_inactive(_icon_inactive), _icon_size(_icon_size)
+      inactive_label(std::move(inactive_label)), _icon_active(_icon_active), _icon_inactive(_icon_inactive), _icon_size(_icon_size)
 {
     checkwdg = nullptr;
 }
diff --git a/src/live_effects/parameter/togglebutton.h b/src/live_effects/parameter/togglebutton.h
index 29ee72203..65fb5db34 100644
--- a/src/live_effects/parameter/togglebutton.h
+++ b/src/live_effects/parameter/togglebutton.h
@@ -30,7 +30,7 @@ public:
                Inkscape::UI::Widget::Registry* wr,
                Effect* effect,
                bool default_value = false,
-               const Glib::ustring& inactive_label = "",
+               Glib::ustring  inactive_label = "",
                char const * icon_active = nullptr,
                char const * icon_inactive = nullptr,
                GtkIconSize icon_size = GTK_ICON_SIZE_SMALL_TOOLBAR);