Added documentation and fix to coding style.

(bzr r13645.1.66)

4 files changed, 616 insertions, 544 deletions

diff --git a/src/live_effects/lpe-fillet-chamfer.cpp b/src/live_effects/lpe-fillet-chamfer.cpp
index e873bebf9..6e026550a 100644
--- a/src/live_effects/lpe-fillet-chamfer.cpp
+++ b/src/live_effects/lpe-fillet-chamfer.cpp
@@ -9,12 +9,12 @@
  * Also su_v for his construvtive feedback and time
  * Also to Mc- (IRC nick) for his important contribution to find real time
  * values based on
- * and finaly to Liam P. White for his big help on coding, that save me a lot of hours
+ * and finaly to Liam P. White for his big help on coding, that save me a lot of
+ * hours
  *
  * Released under GNU GPL, read the file 'COPYING' for more information
  */
 
-
 #include "live_effects/lpe-fillet-chamfer.h"
 #include "helper/geom.h"
 #include "display/curve.h"
@@ -33,29 +33,40 @@ namespace Inkscape {
 namespace LivePathEffect {
 
 static const Util::EnumData<FilletMethod> FilletMethodData[FM_END] = {
-    { FM_AUTO, N_("Auto"), "auto" },
-    { FM_ARC, N_("Force arc"), "arc" },
+    { FM_AUTO, N_("Auto"), "auto" }, { FM_ARC, N_("Force arc"), "arc" },
     { FM_BEZIER, N_("Force bezier"), "bezier" }
 };
-static const Util::EnumDataConverter<FilletMethod>
-FMConverter(FilletMethodData, FM_END);
-
-LPEFilletChamfer::LPEFilletChamfer(LivePathEffectObject *lpeobject) :
-    Effect(lpeobject),
-    satellitearrayparam_values(_("pair_array_param"), _("pair_array_param"), "satellitearrayparam_values", &wr, this),
-    unit(_("Unit:"), _("Unit"), "unit", &wr, this),
-    method(_("Method:"), _("Methods to calculate the fillet or chamfer"), "method", FMConverter, &wr, this, FM_AUTO),
-    radius(_("Radius (unit or %):"), _("Radius, in unit or %"), "radius", &wr, this, 0.),
-    chamfer_steps(_("Chamfer steps:"), _("Chamfer steps"), "chamfer_steps", &wr, this, 1),
-    flexible(_("Flexible radius size (%)"), _("Flexible radius size (%)"), "flexible", &wr, this, false),
-    mirror_knots(_("Mirror Knots"), _("Mirror Knots"), "mirror_knots", &wr, this, true),
-    only_selected(_("Change only selected nodes"), _("Change only selected nodes"), "only_selected", &wr, this, false),
-    use_knot_distance(_("Use knots distance instead radius"), _("Use knots distance instead radius"), "use_knot_distance", &wr, this, false),
-    hide_knots(_("Hide knots"), _("Hide knots"), "hide_knots", &wr, this, false),
-    ignore_radius_0(_("Ignore 0 radius knots"), _("Ignore 0 radius knots"), "ignore_radius_0", &wr, this, false),
-    helper_size(_("Helper size with direction:"), _("Helper size with direction"), "helper_size", &wr, this, 0),
-    pointwise(NULL),
-    segCount(0)
+static const Util::EnumDataConverter<FilletMethod> FMConverter(FilletMethodData,
+        FM_END);
+
+LPEFilletChamfer::LPEFilletChamfer(LivePathEffectObject *lpeobject)
+    : Effect(lpeobject),
+      satellitearrayparam_values(_("pair_array_param"), _("pair_array_param"),
+                                 "satellitearrayparam_values", &wr, this),
+      unit(_("Unit:"), _("Unit"), "unit", &wr, this),
+      method(_("Method:"), _("Methods to calculate the fillet or chamfer"),
+             "method", FMConverter, &wr, this, FM_AUTO),
+      radius(_("Radius (unit or %):"), _("Radius, in unit or %"), "radius", &wr,
+             this, 0.),
+      chamfer_steps(_("Chamfer steps:"), _("Chamfer steps"), "chamfer_steps",
+                    &wr, this, 1),
+      flexible(_("Flexible radius size (%)"), _("Flexible radius size (%)"),
+               "flexible", &wr, this, false),
+      mirror_knots(_("Mirror Knots"), _("Mirror Knots"), "mirror_knots", &wr,
+                   this, true),
+      only_selected(_("Change only selected nodes"),
+                    _("Change only selected nodes"), "only_selected", &wr, this,
+                    false),
+      use_knot_distance(_("Use knots distance instead radius"),
+                        _("Use knots distance instead radius"),
+                        "use_knot_distance", &wr, this, false),
+      hide_knots(_("Hide knots"), _("Hide knots"), "hide_knots", &wr, this,
+                 false),
+      ignore_radius_0(_("Ignore 0 radius knots"), _("Ignore 0 radius knots"),
+                      "ignore_radius_0", &wr, this, false),
+      helper_size(_("Helper size with direction:"),
+                  _("Helper size with direction"), "helper_size", &wr, this, 0),
+      pointwise(NULL), segment_size(0)
 {
     registerParameter(&satellitearrayparam_values);
     registerParameter(&unit);
@@ -83,65 +94,67 @@ LPEFilletChamfer::LPEFilletChamfer(LivePathEffectObject *lpeobject) :
 
 LPEFilletChamfer::~LPEFilletChamfer() {}
 
-
 void LPEFilletChamfer::doOnApply(SPLPEItem const *lpeItem)
 {
-    SPLPEItem * splpeitem = const_cast<SPLPEItem *>(lpeItem);
-    SPShape * shape = dynamic_cast<SPShape *>(splpeitem);
+    SPLPEItem *splpeitem = const_cast<SPLPEItem *>(lpeItem);
+    SPShape *shape = dynamic_cast<SPShape *>(splpeitem);
     if (shape) {
-        PathVector const &original_pathv = pathv_to_linear_and_cubic_beziers(shape->getCurve()->get_pathvector());
+        PathVector const &original_pathv =
+            pathv_to_linear_and_cubic_beziers(shape->getCurve()->get_pathvector());
         Piecewise<D2<SBasis> > pwd2_in = paths_to_pw(original_pathv);
         pwd2_in = remove_short_cuts(pwd2_in, 0.01);
-        int counterTotal = 0;
-        std::vector<Geom::Satellite>  satellites;
-        for (PathVector::const_iterator path_it = original_pathv.begin(); path_it != original_pathv.end(); ++path_it) {
-            if (path_it->empty()){
+        int global_counter = 0;
+        std::vector<Geom::Satellite> satellites;
+        for (PathVector::const_iterator path_it = original_pathv.begin();
+                path_it != original_pathv.end(); ++path_it) {
+            if (path_it->empty()) {
                 continue;
             }
             Geom::Path::const_iterator curve_it1 = path_it->begin();
             Geom::Path::const_iterator curve_endit = path_it->end_default();
             if (path_it->closed()) {
-              const Curve &closingline = path_it->back_closed(); 
-              // the closing line segment is always of type 
-              // LineSegment.
-              if (are_near(closingline.initialPoint(), closingline.finalPoint())) {
-                // closingline.isDegenerate() did not work, because it only checks for
-                // *exact* zero length, which goes wrong for relative coordinates and
-                // rounding errors...
-                // the closing line segment has zero-length. So stop before that one!
-                curve_endit = path_it->end_open();
-              }
+                const Curve &closingline = path_it->back_closed();
+                // the closing line segment is always of type
+                // LineSegment.
+                if (are_near(closingline.initialPoint(), closingline.finalPoint())) {
+                    // closingline.isDegenerate() did not work, because it only checks for
+                    // *exact* zero length, which goes wrong for relative coordinates and
+                    // rounding errors...
+                    // the closing line segment has zero-length. So stop before that one!
+                    curve_endit = path_it->end_open();
+                }
             }
             Geom::Path::const_iterator curve_end = curve_endit;
             --curve_end;
             int counter = 0;
             size_t steps = chamfer_steps;
             while (curve_it1 != curve_endit) {
-                if((*curve_it1).isDegenerate() || (*curve_it1).isDegenerate()){
+                if ((*curve_it1).isDegenerate() || (*curve_it1).isDegenerate()) {
                     g_warning("LPE Fillet not handle degenerate curves.");
-                    SPLPEItem * item = const_cast<SPLPEItem*>(lpeItem);
+                    SPLPEItem *item = const_cast<SPLPEItem *>(lpeItem);
                     item->removeCurrentPathEffect(false);
                     return;
                 }
                 bool active = true;
                 bool hidden = false;
-                if (counter==0) {
+                if (counter == 0) {
                     if (!path_it->closed()) {
                         active = false;
                     }
                 }
-                Satellite satellite(F, flexible, active, mirror_knots, hidden, 0.0, 0.0, steps);
+                Satellite satellite(F, flexible, active, mirror_knots, hidden, 0.0, 0.0,
+                                    steps);
                 satellites.push_back(satellite);
                 ++curve_it1;
                 counter++;
-                counterTotal++;
+                global_counter++;
             }
         }
-        pointwise = new Pointwise( pwd2_in,satellites);
-        satellitearrayparam_values.set_pointwise(pointwise);
+        pointwise = new Pointwise(pwd2_in, satellites);
+        satellitearrayparam_values.setPointwise(pointwise);
     } else {
         g_warning("LPE Fillet/Chamfer can only be applied to shapes (not groups).");
-        SPLPEItem * item = const_cast<SPLPEItem*>(lpeItem);
+        SPLPEItem *item = const_cast<SPLPEItem *>(lpeItem);
         item->removeCurrentPathEffect(false);
     }
 }
@@ -161,28 +174,36 @@ Gtk::Widget *LPEFilletChamfer::newWidget()
             Parameter *param = *it;
             Gtk::Widget *widg = param->param_newWidget();
             if (param->param_key == "radius") {
-                Inkscape::UI::Widget::Scalar *widgRegistered = Gtk::manage(dynamic_cast<Inkscape::UI::Widget::Scalar *>(widg));
-                widgRegistered->signal_value_changed().connect(sigc::mem_fun(*this, &LPEFilletChamfer::updateAmount));
-                widg = widgRegistered;
+                Inkscape::UI::Widget::Scalar *widg_registered =
+                    Gtk::manage(dynamic_cast<Inkscape::UI::Widget::Scalar *>(widg));
+                widg_registered->signal_value_changed()
+                .connect(sigc::mem_fun(*this, &LPEFilletChamfer::updateAmount));
+                widg = widg_registered;
                 if (widg) {
-                    Gtk::HBox *scalarParameter = dynamic_cast<Gtk::HBox *>(widg);
-                    std::vector<Gtk::Widget *> childList = scalarParameter->get_children();
-                    Gtk::Entry *entryWidg = dynamic_cast<Gtk::Entry *>(childList[1]);
-                    entryWidg->set_width_chars(6);
+                    Gtk::HBox *scalar_parameter = dynamic_cast<Gtk::HBox *>(widg);
+                    std::vector<Gtk::Widget *> childList =
+                        scalar_parameter->get_children();
+                    Gtk::Entry *entry_widget = dynamic_cast<Gtk::Entry *>(childList[1]);
+                    entry_widget->set_width_chars(6);
                 }
             } else if (param->param_key == "chamfer_steps") {
-                Inkscape::UI::Widget::Scalar *widgRegistered = Gtk::manage(dynamic_cast<Inkscape::UI::Widget::Scalar *>(widg));
-                widgRegistered->signal_value_changed().connect(sigc::mem_fun(*this, &LPEFilletChamfer::updateChamferSteps));
-                widg = widgRegistered;
+                Inkscape::UI::Widget::Scalar *widg_registered =
+                    Gtk::manage(dynamic_cast<Inkscape::UI::Widget::Scalar *>(widg));
+                widg_registered->signal_value_changed().connect(
+                    sigc::mem_fun(*this, &LPEFilletChamfer::updateChamferSteps));
+                widg = widg_registered;
                 if (widg) {
-                    Gtk::HBox *scalarParameter = dynamic_cast<Gtk::HBox *>(widg);
-                    std::vector<Gtk::Widget *> childList = scalarParameter->get_children();
-                    Gtk::Entry *entryWidg = dynamic_cast<Gtk::Entry *>(childList[1]);
-                    entryWidg->set_width_chars(3);
+                    Gtk::HBox *scalar_parameter = dynamic_cast<Gtk::HBox *>(widg);
+                    std::vector<Gtk::Widget *> childList =
+                        scalar_parameter->get_children();
+                    Gtk::Entry *entry_widget = dynamic_cast<Gtk::Entry *>(childList[1]);
+                    entry_widget->set_width_chars(3);
                 }
             } else if (param->param_key == "helper_size") {
-                Inkscape::UI::Widget::Scalar *widgRegistered = Gtk::manage(dynamic_cast<Inkscape::UI::Widget::Scalar *>(widg));
-                widgRegistered->signal_value_changed().connect(sigc::mem_fun(*this, &LPEFilletChamfer::refreshKnots));
+                Inkscape::UI::Widget::Scalar *widg_registered =
+                    Gtk::manage(dynamic_cast<Inkscape::UI::Widget::Scalar *>(widg));
+                widg_registered->signal_value_changed()
+                .connect(sigc::mem_fun(*this, &LPEFilletChamfer::refreshKnots));
             } else if (param->param_key == "only_selected") {
                 Gtk::manage(widg);
             }
@@ -199,32 +220,39 @@ Gtk::Widget *LPEFilletChamfer::newWidget()
         }
         ++it;
     }
-    
-    Gtk::HBox *filletContainer = Gtk::manage(new Gtk::HBox(true, 0));
-    Gtk::Button *fillet = Gtk::manage(new Gtk::Button(Glib::ustring(_("Fillet"))));
-    fillet->signal_clicked().connect(sigc::mem_fun(*this, &LPEFilletChamfer::fillet));
-
-    filletContainer->pack_start(*fillet, true, true, 2);
-    Gtk::Button *inverseFillet = Gtk::manage(new Gtk::Button(Glib::ustring(_("Inverse fillet"))));
-    inverseFillet->signal_clicked().connect(sigc::mem_fun(*this, &LPEFilletChamfer::inverseFillet));
-    filletContainer->pack_start(*inverseFillet, true, true, 2);
-    
-    Gtk::HBox *chamferContainer = Gtk::manage(new Gtk::HBox(true, 0));
-    Gtk::Button *chamfer = Gtk::manage(new Gtk::Button(Glib::ustring(_("Chamfer"))));
-    chamfer->signal_clicked().connect(sigc::mem_fun(*this, &LPEFilletChamfer::chamfer));
-
-    chamferContainer->pack_start(*chamfer, true, true, 2);
-    Gtk::Button *inverseChamfer = Gtk::manage(new Gtk::Button(Glib::ustring(_("Inverse chamfer"))));
-    inverseChamfer->signal_clicked().connect(sigc::mem_fun(*this, &LPEFilletChamfer::inverseChamfer));
-    chamferContainer->pack_start(*inverseChamfer, true, true, 2);
-
-    vbox->pack_start(*filletContainer, true, true, 2);
-    vbox->pack_start(*chamferContainer, true, true, 2);
+
+    Gtk::HBox *fillet_container = Gtk::manage(new Gtk::HBox(true, 0));
+    Gtk::Button *fillet =
+        Gtk::manage(new Gtk::Button(Glib::ustring(_("Fillet"))));
+    fillet->signal_clicked()
+    .connect(sigc::mem_fun(*this, &LPEFilletChamfer::fillet));
+
+    fillet_container->pack_start(*fillet, true, true, 2);
+    Gtk::Button *inverse_fillet =
+        Gtk::manage(new Gtk::Button(Glib::ustring(_("Inverse fillet"))));
+    inverse_fillet->signal_clicked()
+    .connect(sigc::mem_fun(*this, &LPEFilletChamfer::inverseFillet));
+    fillet_container->pack_start(*inverse_fillet, true, true, 2);
+
+    Gtk::HBox *chamfer_container = Gtk::manage(new Gtk::HBox(true, 0));
+    Gtk::Button *chamfer =
+        Gtk::manage(new Gtk::Button(Glib::ustring(_("Chamfer"))));
+    chamfer->signal_clicked()
+    .connect(sigc::mem_fun(*this, &LPEFilletChamfer::chamfer));
+
+    chamfer_container->pack_start(*chamfer, true, true, 2);
+    Gtk::Button *inverse_chamfer =
+        Gtk::manage(new Gtk::Button(Glib::ustring(_("Inverse chamfer"))));
+    inverse_chamfer->signal_clicked()
+    .connect(sigc::mem_fun(*this, &LPEFilletChamfer::inverseChamfer));
+    chamfer_container->pack_start(*inverse_chamfer, true, true, 2);
+
+    vbox->pack_start(*fillet_container, true, true, 2);
+    vbox->pack_start(*chamfer_container, true, true, 2);
 
     return vbox;
 }
 
-
 void LPEFilletChamfer::fillet()
 {
     updateSatelliteType(F);
@@ -247,7 +275,7 @@ void LPEFilletChamfer::inverseChamfer()
 
 void LPEFilletChamfer::refreshKnots()
 {
-    if(satellitearrayparam_values.knoth){
+    if (satellitearrayparam_values.knoth) {
         satellitearrayparam_values.knoth->update_knots();
     }
 }
@@ -256,81 +284,90 @@ void LPEFilletChamfer::updateAmount()
 {
     double power = 0;
     if (!flexible) {
-        power = Inkscape::Util::Quantity::convert(radius, unit.get_abbreviation(), defaultUnit);
+        power = Inkscape::Util::Quantity::convert(radius, unit.get_abbreviation(),
+                defaultUnit);
     } else {
-        power = radius/100;
+        power = radius / 100;
     }
     std::vector<Geom::Satellite> satellites = pointwise->getSatellites();
     Piecewise<D2<SBasis> > pwd2 = pointwise->getPwd2();
-    Pathinfo pathInfo(pwd2);
-    for (std::vector<Geom::Satellite>::iterator it = satellites.begin(); it != satellites.end(); ++it) {
-        if(!pathInfo.getIsClosed(it - satellites.begin()) && pathInfo.getFirst(it - satellites.begin()) == (unsigned)(it - satellites.begin())){
+    Pathinfo path_info(pwd2);
+    for (std::vector<Geom::Satellite>::iterator it = satellites.begin();
+            it != satellites.end(); ++it) {
+        if (!path_info.isClosed(it - satellites.begin()) &&
+                path_info.first(it - satellites.begin()) ==
+                (unsigned)(it - satellites.begin())) {
             it->amount = 0;
             continue;
         }
-        if(ignore_radius_0 && it->amount == 0){
+        if (ignore_radius_0 && it->amount == 0) {
             continue;
         }
-        boost::optional<size_t> prev = pathInfo.getPrevious(it - satellites.begin());
-        boost::optional<Geom::D2<Geom::SBasis> > prevPwd2 = boost::none;
-        boost::optional<Geom::Satellite > prevSat = boost::none;
-        if(prev){
-            prevPwd2 = pwd2[*prev];
-            prevSat = satellites[*prev];
+        boost::optional<size_t> previous =
+            path_info.previous(it - satellites.begin());
+        boost::optional<Geom::D2<Geom::SBasis> > previous_d2 = boost::none;
+        boost::optional<Geom::Satellite> previous_satellite = boost::none;
+        if (previous) {
+            previous_d2 = pwd2[*previous];
+            previous_satellite = satellites[*previous];
         }
-        if(only_selected){
-            Geom::Point satPoint = pwd2.valueAt(it - satellites.begin());
-            if(isNodePointSelected(satPoint)){
-                if(!use_knot_distance && !flexible){
-                    it->amount = it->rad_to_len(power, prevPwd2, pwd2[it - satellites.begin()], prevSat);
+        if (only_selected) {
+            Geom::Point satellite_point = pwd2.valueAt(it - satellites.begin());
+            if (isNodePointSelected(satellite_point)) {
+                if (!use_knot_distance && !flexible) {
+                    it->amount = it->radToLen(power, previous_d2,
+                                              pwd2[it - satellites.begin()], previous_satellite);
                 } else {
                     it->amount = power;
                 }
             }
         } else {
-            if(!use_knot_distance && !flexible){
-                it->amount = it->rad_to_len(power, prevPwd2, pwd2[it - satellites.begin()], prevSat);
+            if (!use_knot_distance && !flexible) {
+                it->amount = it->radToLen(power, previous_d2,
+                                          pwd2[it - satellites.begin()], previous_satellite);
             } else {
                 it->amount = power;
             }
         }
     }
     pointwise->setSatellites(satellites);
-    satellitearrayparam_values.set_pointwise(pointwise);
+    satellitearrayparam_values.setPointwise(pointwise);
 }
 
 void LPEFilletChamfer::updateChamferSteps()
 {
     std::vector<Geom::Satellite> satellites = pointwise->getSatellites();
     Piecewise<D2<SBasis> > pwd2 = pointwise->getPwd2();
-    for (std::vector<Geom::Satellite>::iterator it = satellites.begin(); it != satellites.end(); ++it) {
-        if(ignore_radius_0 && it->amount == 0){
+    for (std::vector<Geom::Satellite>::iterator it = satellites.begin();
+            it != satellites.end(); ++it) {
+        if (ignore_radius_0 && it->amount == 0) {
             continue;
         }
-        if(only_selected){
-            Geom::Point satPoint = pwd2.valueAt(it - satellites.begin());
-            if(isNodePointSelected(satPoint)){
-               it->steps = chamfer_steps;
+        if (only_selected) {
+            Geom::Point satellite_point = pwd2.valueAt(it - satellites.begin());
+            if (isNodePointSelected(satellite_point)) {
+                it->steps = chamfer_steps;
             }
         } else {
             it->steps = chamfer_steps;
         }
     }
     pointwise->setSatellites(satellites);
-    satellitearrayparam_values.set_pointwise(pointwise);
+    satellitearrayparam_values.setPointwise(pointwise);
 }
 
 void LPEFilletChamfer::updateSatelliteType(Geom::SatelliteType satellitetype)
 {
     std::vector<Geom::Satellite> satellites = pointwise->getSatellites();
     Piecewise<D2<SBasis> > pwd2 = pointwise->getPwd2();
-    for (std::vector<Geom::Satellite>::iterator it = satellites.begin(); it != satellites.end(); ++it) {
-        if(ignore_radius_0 && it->amount == 0){
+    for (std::vector<Geom::Satellite>::iterator it = satellites.begin();
+            it != satellites.end(); ++it) {
+        if (ignore_radius_0 && it->amount == 0) {
             continue;
         }
-        if(only_selected){
-            Geom::Point satPoint = pwd2.valueAt(it - satellites.begin());
-            if(isNodePointSelected(satPoint)){
+        if (only_selected) {
+            Geom::Point satellite_point = pwd2.valueAt(it - satellites.begin());
+            if (isNodePointSelected(satellite_point)) {
                 it->satelliteType = satellitetype;
             }
         } else {
@@ -338,75 +375,76 @@ void LPEFilletChamfer::updateSatelliteType(Geom::SatelliteType satellitetype)
         }
     }
     pointwise->setSatellites(satellites);
-    satellitearrayparam_values.set_pointwise(pointwise);
+    satellitearrayparam_values.setPointwise(pointwise);
 }
 
 void LPEFilletChamfer::doBeforeEffect(SPLPEItem const *lpeItem)
 {
-    SPLPEItem * splpeitem = const_cast<SPLPEItem *>(lpeItem);
-    SPShape * shape = dynamic_cast<SPShape *>(splpeitem);
+    SPLPEItem *splpeitem = const_cast<SPLPEItem *>(lpeItem);
+    SPShape *shape = dynamic_cast<SPShape *>(splpeitem);
     if (shape) {
         SPCurve *c = shape->getCurve();
-        SPPath * path = dynamic_cast<SPPath *>(shape);
-        if(path){
+        SPPath *path = dynamic_cast<SPPath *>(shape);
+        if (path) {
             c = path->get_original_curve();
         }
         //fillet chamfer specific calls
-        satellitearrayparam_values.set_document_unit(defaultUnit);
-        satellitearrayparam_values.set_use_distance(use_knot_distance);
-        satellitearrayparam_values.set_unit(unit.get_abbreviation());
+        satellitearrayparam_values.setDocumentUnit(defaultUnit);
+        satellitearrayparam_values.setUseDistance(use_knot_distance);
+        satellitearrayparam_values.setUnit(unit.get_abbreviation());
         //mandatory call
-        satellitearrayparam_values.set_effect_type(this->effectType());
-        
-        PathVector const &original_pathv = pathv_to_linear_and_cubic_beziers(c->get_pathvector());
+        satellitearrayparam_values.setEffectType(effectType());
+
+        PathVector const &original_pathv =
+            pathv_to_linear_and_cubic_beziers(c->get_pathvector());
         Piecewise<D2<SBasis> > pwd2_in = paths_to_pw(original_pathv);
         pwd2_in = remove_short_cuts(pwd2_in, 0.01);
-        std::vector<Geom::Satellite>  sats = satellitearrayparam_values.data();
+        std::vector<Geom::Satellite> sats = satellitearrayparam_values.data();
         //optional call
-        if(hide_knots){
-            satellitearrayparam_values.set_helper_size(0);
+        if (hide_knots) {
+            satellitearrayparam_values.setHelperSize(0);
         } else {
-            satellitearrayparam_values.set_helper_size(helper_size);
+            satellitearrayparam_values.setHelperSize(helper_size);
         }
         bool refresh = false;
         bool hide = true;
-        for (std::vector<Satellite>::iterator it = sats.begin(); it != sats.end();)
-    {
-            if(it->isTime != flexible){
+        for (std::vector<Satellite>::iterator it = sats.begin();
+                it != sats.end();) {
+            if (it->isTime != flexible) {
                 it->isTime = flexible;
                 double amount = it->amount;
                 D2<SBasis> d2_in = pwd2_in[it - sats.begin()];
-                if(it->isTime){
-                    double time = it->toTime(amount,d2_in);
+                if (it->isTime) {
+                    double time = it->toTime(amount, d2_in);
                     it->amount = time;
                 } else {
-                    double size = it->toSize(amount,d2_in);
+                    double size = it->toSize(amount, d2_in);
                     it->amount = size;
                 }
             }
-            if(it->hasMirror != mirror_knots){
+            if (it->hasMirror != mirror_knots) {
                 it->hasMirror = mirror_knots;
                 refresh = true;
             }
-            if(it->hidden == false){
+            if (it->hidden == false) {
                 hide = false;
             }
             it->hidden = hide_knots;
             ++it;
         }
-        if(hide != hide_knots){
+        if (hide != hide_knots) {
             refresh = true;
         }
-        
-        if(pointwise && c->get_segment_count() != segCount && segCount != 0){
-            pointwise->recalculate_for_new_pwd2(pwd2_in);
-            segCount = c->get_segment_count();
+
+        if (pointwise && c->get_segment_count() != segment_size && segment_size != 0) {
+            pointwise->recalculateForNewPwd2(pwd2_in);
+            segment_size = c->get_segment_count();
         } else {
             pointwise = new Pointwise(pwd2_in, sats);
-            segCount = c->get_segment_count();
+            segment_size = c->get_segment_count();
         }
-        satellitearrayparam_values.set_pointwise(pointwise);
-        if(refresh){
+        satellitearrayparam_values.setPointwise(pointwise);
+        if (refresh) {
             refreshKnots();
         }
     } else {
@@ -418,246 +456,272 @@ void
 LPEFilletChamfer::adjustForNewPath(std::vector<Geom::Path> const &path_in)
 {
     if (!path_in.empty() && pointwise) {
-        pointwise->recalculate_for_new_pwd2(remove_short_cuts(paths_to_pw(pathv_to_linear_and_cubic_beziers(path_in)),0.01));
-        satellitearrayparam_values.set_pointwise(pointwise);
+        pointwise->recalculateForNewPwd2(remove_short_cuts(
+                                             paths_to_pw(pathv_to_linear_and_cubic_beziers(path_in)), 0.01));
+        satellitearrayparam_values.setPointwise(pointwise);
     }
 }
 
 std::vector<Geom::Path>
 LPEFilletChamfer::doEffect_path(std::vector<Geom::Path> const &path_in)
 {
-    const double gapHelper = 0.00001;
-    std::vector<Geom::Path> pathvector_out;
+    const double GAP_HELPER = 0.00001;
+    std::vector<Geom::Path> path_out;
     size_t counter = 0;
     const double K = (4.0 / 3.0) * (sqrt(2.0) - 1.0);
-    std::vector<Geom::Path> path_in_processed = pathv_to_linear_and_cubic_beziers(path_in);
+    std::vector<Geom::Path> path_in_processed =
+        pathv_to_linear_and_cubic_beziers(path_in);
     for (PathVector::const_iterator path_it = path_in_processed.begin();
             path_it != path_in_processed.end(); ++path_it) {
-        if (path_it->empty()){
+        if (path_it->empty()) {
             continue;
         }
-        Geom::Path path_out;
+        Geom::Path tmp_path;
         Geom::Path::const_iterator curve_it1 = path_it->begin();
         Geom::Path::const_iterator curve_it2 = ++(path_it->begin());
         Geom::Path::const_iterator curve_endit = path_it->end_default();
-        if(path_it->size() == 1){
+        if (path_it->size() == 1) {
             counter++;
-            path_out.start((*curve_it1).pointAt(0));
-            path_out.append(*curve_it1);
-            pathvector_out.push_back(path_out);
+            tmp_path.start((*curve_it1).pointAt(0));
+            tmp_path.append(*curve_it1);
+            path_out.push_back(tmp_path);
             continue;
         }
         if (path_it->closed()) {
-          const Geom::Curve &closingline = path_it->back_closed(); 
-          // the closing line segment is always of type 
-          // Geom::LineSegment.
-          if (are_near(closingline.initialPoint(), closingline.finalPoint())) {
-            // closingline.isDegenerate() did not work, because it only checks for
-            // *exact* zero length, which goes wrong for relative coordinates and
-            // rounding errors...
-            // the closing line segment has zero-length. So stop before that one!
-            curve_endit = path_it->end_open();
-          }
+            const Geom::Curve &closingline = path_it->back_closed();
+            // the closing line segment is always of type
+            // Geom::LineSegment.
+            if (are_near(closingline.initialPoint(), closingline.finalPoint())) {
+                // closingline.isDegenerate() did not work, because it only checks for
+                // *exact* zero length, which goes wrong for relative coordinates and
+                // rounding errors...
+                // the closing line segment has zero-length. So stop before that one!
+                curve_endit = path_it->end_open();
+            }
         }
-        size_t counterCurves = 0;
+        size_t counter_curves = 0;
         size_t first = counter;
         double time0 = 0;
         std::vector<Geom::Satellite> sats = pointwise->getSatellites();
         while (curve_it1 != curve_endit) {
-            if((*curve_it1).isDegenerate() || (*curve_it1).isDegenerate()){
+            if ((*curve_it1).isDegenerate() || (*curve_it1).isDegenerate()) {
                 g_warning("LPE Fillet not handle degenerate curves.");
                 return path_in;
             }
             Satellite satellite;
-            Curve *curve_it2Fixed = path_it->begin()->duplicate();
-            if(!path_it->closed()){
-                if(curve_it2 != curve_endit){
-                    curve_it2Fixed = (*curve_it2).duplicate();
-                    if(sats.size()> counter+1 ){
-                        satellite = sats[counter+1];
+            Curve *curve_it2_fixed = path_it->begin()->duplicate();
+            if (!path_it->closed()) {
+                if (curve_it2 != curve_endit) {
+                    curve_it2_fixed = (*curve_it2).duplicate();
+                    if (sats.size() > counter + 1) {
+                        satellite = sats[counter + 1];
                     }
                 } else {
-                    if(time0 != 1){
-                        Curve *lastCurve = curve_it1->portion(time0, 1);
-                        lastCurve->setInitial(path_out.finalPoint());
-                        path_out.append(*lastCurve);
+                    if (time0 != 1) {
+                        Curve *last_curve = curve_it1->portion(time0, 1);
+                        last_curve->setInitial(tmp_path.finalPoint());
+                        tmp_path.append(*last_curve);
                     }
                     ++curve_it1;
                     counter++;
-                    counterCurves++;
+                    counter_curves++;
                     continue;
                 }
             } else {
-                if(curve_it2 != curve_endit){
-                    curve_it2Fixed = (*curve_it2).duplicate();
-                    if(sats.size()> counter+1 ){
-                        satellite = sats[counter+1];
+                if (curve_it2 != curve_endit) {
+                    curve_it2_fixed = (*curve_it2).duplicate();
+                    if (sats.size() > counter + 1) {
+                        satellite = sats[counter + 1];
                     }
 
                 } else {
-                    if(sats.size()> first ){
+                    if (sats.size() > first) {
                         satellite = sats[first];
                     }
                 }
             }
-            if(first == counter){
-                if(sats.size() > first && sats[first].active){
-                    time0 = sats[first].getTime(path_it->begin()->duplicate()->toSBasis());
+            if (first == counter) {
+                if (sats.size() > first && sats[first].active) {
+                    time0 =
+                        sats[first].time(path_it->begin()->duplicate()->toSBasis());
                 } else {
                     time0 = 0;
                 }
             }
 
             bool last = curve_it2 == curve_endit;
-            double s = satellite.getSize(curve_it2Fixed->toSBasis());
-            double time1 = satellite.getOpositeTime(s,(*curve_it1).toSBasis());
-            double time2 = satellite.getTime(curve_it2Fixed->toSBasis());
-            if(!satellite.active){
+            double s = satellite.size(curve_it2_fixed->toSBasis());
+            double time1 = satellite.time(s, true, (*curve_it1).toSBasis());
+            double time2 = satellite.time(curve_it2_fixed->toSBasis());
+            if (!satellite.active) {
                 time1 = 1;
                 time2 = 0;
             }
-            
-            if(time1 <= time0){
+
+            if (time1 <= time0) {
                 time1 = time0;
             }
             std::vector<double> times;
             times.push_back(time0);
             times.push_back(time1);
             times.push_back(time2);
-            Curve *knotCurve1 = curve_it1->portion(times[0], times[1]);
-            if (counterCurves > 0) {
-                knotCurve1->setInitial(path_out.finalPoint());
+            Curve *knot_curve_1 = curve_it1->portion(times[0], times[1]);
+            if (counter_curves > 0) {
+                knot_curve_1->setInitial(tmp_path.finalPoint());
             } else {
-                path_out.start((*curve_it1).pointAt(times[0]));
-            }
-            
-            Point startArcPoint = knotCurve1->finalPoint();
-            Point endArcPoint = curve_it2Fixed->pointAt(times[2]);
-            if(times[2] == 1){
-                endArcPoint = curve_it2Fixed->pointAt(times[2]-gapHelper);
-            }
-            if(times[1] == times[0]){
-                startArcPoint = curve_it1->pointAt(times[0]+gapHelper);
-            }
-            double k1 = distance(startArcPoint, curve_it1->finalPoint()) * K;
-            double k2 = distance(endArcPoint, curve_it2Fixed->initialPoint()) * K;
-            Geom::CubicBezier const *cubic1 = dynamic_cast<Geom::CubicBezier const *>(&*knotCurve1);
-            Ray ray1(startArcPoint, curve_it1->finalPoint());
-            if (cubic1) {
-                ray1.setPoints((*cubic1)[2], startArcPoint);
-            }
-            Point handle1 =  Point::polar(ray1.angle(),k1) + startArcPoint;
-            if(time0 == 1){
-                handle1 =  startArcPoint;
-            }
-            Curve *knotCurve2 = curve_it2Fixed->portion(times[2], 1);
-            Geom::CubicBezier const *cubic2 =  dynamic_cast<Geom::CubicBezier const *>(&*knotCurve2);
-            Ray ray2(curve_it2Fixed->initialPoint(), endArcPoint);
-            if (cubic2) {
-                ray2.setPoints(endArcPoint, (*cubic2)[1]);
-            }
-            Point handle2 = endArcPoint - Point::polar(ray2.angle(),k2);
-            
-            bool ccwToggle = cross(curve_it1->finalPoint() - startArcPoint, endArcPoint - startArcPoint) < 0;
-            double angle = angle_between(ray1, ray2, ccwToggle);
-            double handleAngle = ray1.angle() - angle;
-            if (ccwToggle) {
-                handleAngle = ray1.angle() + angle;
-            }
-            Point inverseHandle1 = Point::polar(handleAngle,k1) + startArcPoint;
-            if(time0 == 1){
-                inverseHandle1 =  startArcPoint;
-            }
-            handleAngle = ray2.angle() + angle;
-            if (ccwToggle) {
-                handleAngle = ray2.angle() - angle;
-            }
-            Point inverseHandle2 = endArcPoint - Point::polar(handleAngle,k2);
-            if(times[2] == 1){
-                endArcPoint = curve_it2Fixed->pointAt(times[2]);
-            }
-            if(times[1] == times[0]){
-                startArcPoint = curve_it1->pointAt(times[0]);
-            }
-            Line const x_line(Geom::Point(0,0),Geom::Point(1,0));
-            Line const angled_line(startArcPoint,endArcPoint);
-            double angleArc = Geom::angle_between( x_line,angled_line);
-            double radius = Geom::distance(startArcPoint,middle_point(startArcPoint,endArcPoint))/sin(angle/2.0);
+                tmp_path.start((*curve_it1).pointAt(times[0]));
+            }
+
+            Point start_arc_point = knot_curve_1->finalPoint();
+            Point end_arc_point = curve_it2_fixed->pointAt(times[2]);
+            if (times[2] == 1) {
+                end_arc_point = curve_it2_fixed->pointAt(times[2] - GAP_HELPER);
+            }
+            if (times[1] == times[0]) {
+                start_arc_point = curve_it1->pointAt(times[0] + GAP_HELPER);
+            }
+            double k1 = distance(start_arc_point, curve_it1->finalPoint()) * K;
+            double k2 = distance(end_arc_point, curve_it2_fixed->initialPoint()) * K;
+            Geom::CubicBezier const *cubic_1 =
+                dynamic_cast<Geom::CubicBezier const *>(&*knot_curve_1);
+            Ray ray_1(start_arc_point, curve_it1->finalPoint());
+            if (cubic_1) {
+                ray_1.setPoints((*cubic_1)[2], start_arc_point);
+            }
+            Point handle_1 = Point::polar(ray_1.angle(), k1) + start_arc_point;
+            if (time0 == 1) {
+                handle_1 = start_arc_point;
+            }
+            Curve *knot_curve_2 = curve_it2_fixed->portion(times[2], 1);
+            Geom::CubicBezier const *cubic_2 =
+                dynamic_cast<Geom::CubicBezier const *>(&*knot_curve_2);
+            Ray ray_2(curve_it2_fixed->initialPoint(), end_arc_point);
+            if (cubic_2) {
+                ray_2.setPoints(end_arc_point, (*cubic_2)[1]);
+            }
+            Point handle_2 = end_arc_point - Point::polar(ray_2.angle(), k2);
+
+            bool ccw_toggle = cross(curve_it1->finalPoint() - start_arc_point,
+                                    end_arc_point - start_arc_point) < 0;
+            double angle = angle_between(ray_1, ray_2, ccw_toggle);
+            double handleAngle = ray_1.angle() - angle;
+            if (ccw_toggle) {
+                handleAngle = ray_1.angle() + angle;
+            }
+            Point inverse_handle_1 = Point::polar(handleAngle, k1) + start_arc_point;
+            if (time0 == 1) {
+                inverse_handle_1 = start_arc_point;
+            }
+            handleAngle = ray_2.angle() + angle;
+            if (ccw_toggle) {
+                handleAngle = ray_2.angle() - angle;
+            }
+            Point inverse_handle_2 = end_arc_point - Point::polar(handleAngle, k2);
+            if (times[2] == 1) {
+                end_arc_point = curve_it2_fixed->pointAt(times[2]);
+            }
+            if (times[1] == times[0]) {
+                start_arc_point = curve_it1->pointAt(times[0]);
+            }
+            Line const x_line(Geom::Point(0, 0), Geom::Point(1, 0));
+            Line const angled_line(start_arc_point, end_arc_point);
+            double arc_angle = Geom::angle_between(x_line, angled_line);
+            double radius = Geom::distance(start_arc_point,
+                                           middle_point(start_arc_point, end_arc_point)) /
+                            sin(angle / 2.0);
             Coord rx = radius;
             Coord ry = rx;
             if (times[1] != 1) {
-                if (times[1] != times[0] || times[1] == times[0] == 1 ) {
-                    if(!knotCurve1->isDegenerate()){
-                        path_out.append(*knotCurve1);
+                if (times[1] != times[0] || times[1] == times[0] == 1) {
+                    if (!knot_curve_1->isDegenerate()) {
+                        tmp_path.append(*knot_curve_1);
                     }
                 }
                 SatelliteType type = satellite.satelliteType;
                 size_t steps = satellite.steps;
-                if(steps < 1){
+                if (steps < 1) {
                     steps = 1;
                 }
                 if (type == C) {
                     Geom::Path path_chamfer;
-                    path_chamfer.start(path_out.finalPoint());
-                    if((is_straight_curve(*curve_it1) && is_straight_curve(*curve_it2Fixed) && method != FM_BEZIER )|| method == FM_ARC){ 
-                        path_chamfer.appendNew<SVGEllipticalArc>(rx, ry, angleArc, 0, ccwToggle, endArcPoint);
+                    path_chamfer.start(tmp_path.finalPoint());
+                    if ((is_straight_curve(*curve_it1) &&
+                            is_straight_curve(*curve_it2_fixed) && method != FM_BEZIER) ||
+                            method == FM_ARC) {
+                        path_chamfer.appendNew<SVGEllipticalArc>(rx, ry, arc_angle, 0,
+                                ccw_toggle, end_arc_point);
                     } else {
-                        path_chamfer.appendNew<Geom::CubicBezier>(handle1, handle2, endArcPoint);
+                        path_chamfer.appendNew<Geom::CubicBezier>(handle_1, handle_2,
+                                end_arc_point);
                     }
-                    double chamfer_stepsTime = 1.0/steps;
-                    for(size_t i = 1; i < steps; i++){
-                        Geom::Point chamferStep = path_chamfer.pointAt(chamfer_stepsTime * i);
-                        path_out.appendNew<Geom::LineSegment>(chamferStep);
+                    double chamfer_stepsTime = 1.0 / steps;
+                    for (size_t i = 1; i < steps; i++) {
+                        Geom::Point chamfer_step =
+                            path_chamfer.pointAt(chamfer_stepsTime * i);
+                        tmp_path.appendNew<Geom::LineSegment>(chamfer_step);
                     }
-                    path_out.appendNew<Geom::LineSegment>(endArcPoint);
+                    tmp_path.appendNew<Geom::LineSegment>(end_arc_point);
                 } else if (type == IC) {
                     Geom::Path path_chamfer;
-                    path_chamfer.start(path_out.finalPoint());
-                    if((is_straight_curve(*curve_it1) && is_straight_curve(*curve_it2Fixed) && method != FM_BEZIER )|| method == FM_ARC){ 
-                        ccwToggle = ccwToggle?0:1;
-                        path_chamfer.appendNew<SVGEllipticalArc>(rx, ry, angleArc, 0, ccwToggle, endArcPoint);
-                    }else{
-                        path_chamfer.appendNew<Geom::CubicBezier>(inverseHandle1, inverseHandle2, endArcPoint);
+                    path_chamfer.start(tmp_path.finalPoint());
+                    if ((is_straight_curve(*curve_it1) &&
+                            is_straight_curve(*curve_it2_fixed) && method != FM_BEZIER) ||
+                            method == FM_ARC) {
+                        ccw_toggle = ccw_toggle ? 0 : 1;
+                        path_chamfer.appendNew<SVGEllipticalArc>(rx, ry, arc_angle, 0,
+                                ccw_toggle, end_arc_point);
+                    } else {
+                        path_chamfer.appendNew<Geom::CubicBezier>(
+                            inverse_handle_1, inverse_handle_2, end_arc_point);
                     }
-                    double chamfer_stepsTime = 1.0/steps;
-                    for(size_t i = 1; i < steps; i++){
-                        Geom::Point chamferStep = path_chamfer.pointAt(chamfer_stepsTime * i);
-                        path_out.appendNew<Geom::LineSegment>(chamferStep);
+                    double chamfer_stepsTime = 1.0 / steps;
+                    for (size_t i = 1; i < steps; i++) {
+                        Geom::Point chamfer_step =
+                            path_chamfer.pointAt(chamfer_stepsTime * i);
+                        tmp_path.appendNew<Geom::LineSegment>(chamfer_step);
                     }
-                    path_out.appendNew<Geom::LineSegment>(endArcPoint);
+                    tmp_path.appendNew<Geom::LineSegment>(end_arc_point);
                 } else if (type == IF) {
-                    if((is_straight_curve(*curve_it1) && is_straight_curve(*curve_it2Fixed) && method != FM_BEZIER )|| method == FM_ARC){ 
-                        ccwToggle = ccwToggle?0:1;
-                        path_out.appendNew<SVGEllipticalArc>(rx, ry, angleArc, 0, ccwToggle, endArcPoint);
-                    }else{
-                        path_out.appendNew<Geom::CubicBezier>(inverseHandle1, inverseHandle2, endArcPoint);
+                    if ((is_straight_curve(*curve_it1) &&
+                            is_straight_curve(*curve_it2_fixed) && method != FM_BEZIER) ||
+                            method == FM_ARC) {
+                        ccw_toggle = ccw_toggle ? 0 : 1;
+                        tmp_path.appendNew<SVGEllipticalArc>(rx, ry, arc_angle, 0, ccw_toggle,
+                                                             end_arc_point);
+                    } else {
+                        tmp_path.appendNew<Geom::CubicBezier>(inverse_handle_1,
+                                                              inverse_handle_2, end_arc_point);
                     }
-                } else if (type == F){
-                    if((is_straight_curve(*curve_it1) && is_straight_curve(*curve_it2Fixed) && method != FM_BEZIER )|| method == FM_ARC){ 
-                        path_out.appendNew<SVGEllipticalArc>(rx, ry, angleArc, 0, ccwToggle, endArcPoint);
+                } else if (type == F) {
+                    if ((is_straight_curve(*curve_it1) &&
+                            is_straight_curve(*curve_it2_fixed) && method != FM_BEZIER) ||
+                            method == FM_ARC) {
+                        tmp_path.appendNew<SVGEllipticalArc>(rx, ry, arc_angle, 0, ccw_toggle,
+                                                             end_arc_point);
                     } else {
-                        path_out.appendNew<Geom::CubicBezier>(handle1, handle2, endArcPoint);
+                        tmp_path.appendNew<Geom::CubicBezier>(handle_1, handle_2,
+                                                              end_arc_point);
                     }
                 }
             } else {
-                if(!knotCurve1->isDegenerate()){
-                    path_out.append(*knotCurve1);
+                if (!knot_curve_1->isDegenerate()) {
+                    tmp_path.append(*knot_curve_1);
                 }
             }
             if (path_it->closed() && last) {
-                path_out.close();
+                tmp_path.close();
             }
             ++curve_it1;
             if (curve_it2 != curve_endit) {
                 ++curve_it2;
             }
             counter++;
-            counterCurves++;
+            counter_curves++;
             time0 = times[2];
         }
-        pathvector_out.push_back(path_out);
+        path_out.push_back(tmp_path);
     }
-    return pathvector_out;
+    return path_out;
 }
 
 }; //namespace LivePathEffect
diff --git a/src/live_effects/lpe-fillet-chamfer.h b/src/live_effects/lpe-fillet-chamfer.h
index e56200a17..c519679f8 100644
--- a/src/live_effects/lpe-fillet-chamfer.h
+++ b/src/live_effects/lpe-fillet-chamfer.h
@@ -10,7 +10,8 @@
  * Special thanks to Johan Engelen for the base of the effect -powerstroke-
  * Also to ScislaC for point me to the idea
  * Also su_v for his construvtive feedback and time
- * and finaly to Liam P. White for his big help on coding, that save me a lot of hours
+ * and finaly to Liam P. White for his big help on coding, that save me a lot of
+ * hours
  *
  * Released under GNU GPL, read the file 'COPYING' for more information
  */
@@ -36,10 +37,11 @@ public:
     LPEFilletChamfer(LivePathEffectObject *lpeobject);
     virtual ~LPEFilletChamfer();
     virtual void doBeforeEffect(SPLPEItem const *lpeItem);
-    virtual std::vector<Geom::Path> doEffect_path(std::vector<Geom::Path> const &path_in);
+    virtual std::vector<Geom::Path>
+    doEffect_path(std::vector<Geom::Path> const &path_in);
     virtual void doOnApply(SPLPEItem const *lpeItem);
     virtual void adjustForNewPath(std::vector<Geom::Path> const &path_in);
-    virtual Gtk::Widget* newWidget();
+    virtual Gtk::Widget *newWidget();
 
     void updateSatelliteType(Geom::SatelliteType satellitetype);
     void updateChamferSteps();
@@ -49,7 +51,7 @@ public:
     void inverseChamfer();
     void fillet();
     void inverseFillet();
-    
+
     SatelliteArrayParam satellitearrayparam_values;
 
 private:
@@ -66,7 +68,7 @@ private:
     ScalarParam helper_size;
 
     Geom::Pointwise *pointwise;
-    double segCount;
+    double segment_size;
 
     LPEFilletChamfer(const LPEFilletChamfer &);
     LPEFilletChamfer &operator=(const LPEFilletChamfer &);
diff --git a/src/live_effects/parameter/satellitearray.cpp b/src/live_effects/parameter/satellitearray.cpp
index 24a491b4b..bac907343 100644
--- a/src/live_effects/parameter/satellitearray.cpp
+++ b/src/live_effects/parameter/satellitearray.cpp
@@ -19,27 +19,26 @@
 // this has to be included last.
 #include <glibmm/i18n.h>
 
-
 using namespace Geom;
 
 namespace Inkscape {
 
 namespace LivePathEffect {
 
-SatelliteArrayParam::SatelliteArrayParam(
-    const Glib::ustring &label, const Glib::ustring &tip,
-    const Glib::ustring &key, Inkscape::UI::Widget::Registry *wr,
-    Effect *effect)
-    : ArrayParam<Geom::Satellite>(label, tip, key, wr, effect, 0),
-    knoth(NULL)
+SatelliteArrayParam::SatelliteArrayParam(const Glib::ustring &label,
+        const Glib::ustring &tip,
+        const Glib::ustring &key,
+        Inkscape::UI::Widget::Registry *wr,
+        Effect *effect)
+    : ArrayParam<Geom::Satellite>(label, tip, key, wr, effect, 0), knoth(NULL)
 {
-    knot_shape = SP_KNOT_SHAPE_DIAMOND;
-    knot_mode = SP_KNOT_MODE_XOR;
-    knot_color = 0x00ff0000;
-    helper_size = 0;
-    use_distance = false;
+    _knot_shape = SP_KNOT_SHAPE_DIAMOND;
+    _knot_mode = SP_KNOT_MODE_XOR;
+    _knot_color = 0x00ff0000;
+    _helper_size = 0;
+    _use_distance = false;
     _effectType = FILLET_CHAMFER;
-    last_pointwise = NULL;
+    _last_pointwise = NULL;
 }
 
 SatelliteArrayParam::~SatelliteArrayParam() {}
@@ -48,138 +47,141 @@ void SatelliteArrayParam::set_oncanvas_looks(SPKnotShapeType shape,
         SPKnotModeType mode,
         guint32 color)
 {
-    knot_shape = shape;
-    knot_mode = mode;
-    knot_color = color;
+    _knot_shape = shape;
+    _knot_mode = mode;
+    _knot_color = color;
 }
 
-void SatelliteArrayParam::set_pointwise(Geom::Pointwise *pointwise)
+void SatelliteArrayParam::setPointwise(Geom::Pointwise *pointwise)
 {
-    last_pointwise = pointwise;
-    param_set_and_write_new_value(last_pointwise->getSatellites());
+    _last_pointwise = pointwise;
+    param_set_and_write_new_value(_last_pointwise->getSatellites());
 }
 
-void SatelliteArrayParam::set_document_unit(Glib::ustring value_document_unit)
+void SatelliteArrayParam::setDocumentUnit(Glib::ustring value_document_unit)
 {
-    documentUnit = value_document_unit;
+    _documentUnit = value_document_unit;
 }
 
-void SatelliteArrayParam::set_use_distance(bool use_knot_distance )
+void SatelliteArrayParam::setUseDistance(bool use_knot_distance)
 {
-    use_distance = use_knot_distance;
+    _use_distance = use_knot_distance;
 }
 
-void SatelliteArrayParam::set_unit(const gchar *abbr)
+void SatelliteArrayParam::setUnit(const gchar *abbr)
 {
-    unit = abbr;
+    _unit = abbr;
 }
 
-void SatelliteArrayParam::set_effect_type(EffectType et)
+void SatelliteArrayParam::setEffectType(EffectType et)
 {
     _effectType = et;
 }
 
-void SatelliteArrayParam::set_helper_size(int hs)
+void SatelliteArrayParam::setHelperSize(int hs)
 {
-    helper_size = hs;
+    _helper_size = hs;
     updateCanvasIndicators();
 }
 
 void SatelliteArrayParam::updateCanvasIndicators(bool mirror)
 {
-    if(!last_pointwise){
+    if (!_last_pointwise) {
         return;
     }
-    Geom::Piecewise<Geom::D2<Geom::SBasis> > pwd2 = last_pointwise->getPwd2();
-    Pathinfo pathInfo(pwd2);
-    if( mirror == true){
-        hp.clear();
+    Geom::Piecewise<Geom::D2<Geom::SBasis> > pwd2 = _last_pointwise->getPwd2();
+    Pathinfo path_info(pwd2);
+    if (mirror == true) {
+        _hp.clear();
     }
     for (size_t i = 0; i < _vector.size(); ++i) {
-        if(!_vector[i].active || _vector[i].hidden){
+        if (!_vector[i].active || _vector[i].hidden) {
             continue;
         }
-        if((!_vector[i].hasMirror && mirror == true) || _vector[i].amount == 0){
+        if ((!_vector[i].hasMirror && mirror == true) || _vector[i].amount == 0) {
             continue;
         }
         double pos = 0;
-        if(pwd2.size() <= i){
+        if (pwd2.size() <= i) {
             break;
         }
         Geom::D2<Geom::SBasis> d2 = pwd2[i];
         bool overflow = false;
-        double size_out = _vector[i].getSize(pwd2[i]);
+        double size_out = _vector[i].size(pwd2[i]);
         double lenght_out = Geom::length(pwd2[i], Geom::EPSILON);
         double lenght_in = 0;
-        boost::optional<size_t> d2_prev_index = pathInfo.getPrevious(i);
-        if(d2_prev_index){
+        boost::optional<size_t> d2_prev_index = path_info.previous(i);
+        if (d2_prev_index) {
             lenght_in = Geom::length(pwd2[*d2_prev_index], Geom::EPSILON);
         }
-        if(mirror == true){
-            if(d2_prev_index){
+        if (mirror == true) {
+            if (d2_prev_index) {
                 d2 = pwd2[*d2_prev_index];
-                pos = _vector[i].getOpositeTime(size_out,d2);
-                if(lenght_out < size_out){
+                pos = _vector[i].time(size_out, true, d2);
+                if (lenght_out < size_out) {
                     overflow = true;
                 }
             }
         } else {
-            pos = _vector[i].getTime(d2);
-            if(lenght_in < size_out){
+            pos = _vector[i].time(d2);
+            if (lenght_in < size_out) {
                 overflow = true;
             }
         }
         if (pos <= 0 || pos >= 1) {
             continue;
         }
-        Geom::Point ptA = d2.valueAt(pos);
-        Geom::Point derivA = unit_vector(derivative(d2).valueAt(pos));
+        Geom::Point point_a = d2.valueAt(pos);
+        Geom::Point deriv_a = unit_vector(derivative(d2).valueAt(pos));
         Geom::Rotate rot(Geom::Rotate::from_degrees(-90));
-        derivA = derivA * rot;
-        Geom::Point C = ptA - derivA * helper_size;
-        Geom::Point D = ptA + derivA * helper_size;
-        Geom::Ray ray1(C, D);
-        char const * svgd = "M 1,0.25 0.5,0 1,-0.25 M 1,0.5 0,0 1,-0.5";
+        deriv_a = deriv_a * rot;
+        Geom::Point point_c = point_a - deriv_a * _helper_size;
+        Geom::Point point_d = point_a + deriv_a * _helper_size;
+        Geom::Ray ray_1(point_c, point_d);
+        char const *svgd = "M 1,0.25 0.5,0 1,-0.25 M 1,0.5 0,0 1,-0.5";
         Geom::PathVector pathv = sp_svg_read_pathv(svgd);
         Geom::Affine aff = Geom::Affine();
-        aff *= Geom::Scale(helper_size);
-        if(mirror == true){
-            aff *= Geom::Rotate(ray1.angle() - deg_to_rad(90));
+        aff *= Geom::Scale(_helper_size);
+        if (mirror == true) {
+            aff *= Geom::Rotate(ray_1.angle() - deg_to_rad(90));
         } else {
-            aff *= Geom::Rotate(ray1.angle() - deg_to_rad(270));
+            aff *= Geom::Rotate(ray_1.angle() - deg_to_rad(270));
         }
         pathv *= aff;
         pathv += d2.valueAt(pos);
-        hp.push_back(pathv[0]);
-        hp.push_back(pathv[1]);
-        if(overflow){
-            double diameter = helper_size;
-            if(helper_size == 0){
+        _hp.push_back(pathv[0]);
+        _hp.push_back(pathv[1]);
+        if (overflow) {
+            double diameter = _helper_size;
+            if (_helper_size == 0) {
                 diameter = 15;
-                char const * svgd;
-                svgd = "M 0.7,0.35 A 0.35,0.35 0 0 1 0.35,0.7 0.35,0.35 0 0 1 0,0.35 0.35,0.35 0 0 1 0.35,0 0.35,0.35 0 0 1 0.7,0.35 Z";
+                char const *svgd;
+                svgd = "M 0.7,0.35 A 0.35,0.35 0 0 1 0.35,0.7 0.35,0.35 0 0 1 0,0.35 "
+                       "0.35,0.35 0 0 1 0.35,0 0.35,0.35 0 0 1 0.7,0.35 Z";
                 Geom::PathVector pathv = sp_svg_read_pathv(svgd);
-                pathv *= Geom::Scale (diameter);
-                pathv += ptA-Geom::Point(diameter * 0.35,diameter * 0.35);
-                hp.push_back(pathv[0]);
+                pathv *= Geom::Scale(diameter);
+                pathv += point_a - Geom::Point(diameter * 0.35, diameter * 0.35);
+                _hp.push_back(pathv[0]);
             } else {
-                char const * svgd;
-                svgd = "M 0 -1.32 A 1.32 1.32 0 0 0 -1.32 0 A 1.32 1.32 0 0 0 0 1.32 A 1.32 1.32 0 0 0 1.18 0.59 L 0 0 L 1.18 -0.59 A 1.32 1.32 0 0 0 0 -1.32 z";
+                char const *svgd;
+                svgd = "M 0 -1.32 A 1.32 1.32 0 0 0 -1.32 0 A 1.32 1.32 0 0 0 0 1.32 A "
+                       "1.32 1.32 0 0 0 1.18 0.59 L 0 0 L 1.18 -0.59 A 1.32 1.32 0 0 0 "
+                       "0 -1.32 z";
                 Geom::PathVector pathv = sp_svg_read_pathv(svgd);
                 aff = Geom::Affine();
-                aff *= Geom::Scale(helper_size/2.0);
-                if(mirror == true){
-                    aff *= Geom::Rotate(ray1.angle() - deg_to_rad(90));
+                aff *= Geom::Scale(_helper_size / 2.0);
+                if (mirror == true) {
+                    aff *= Geom::Rotate(ray_1.angle() - deg_to_rad(90));
                 } else {
-                    aff *= Geom::Rotate(ray1.angle() - deg_to_rad(270));
+                    aff *= Geom::Rotate(ray_1.angle() - deg_to_rad(270));
                 }
                 pathv *= aff;
                 pathv += d2.valueAt(pos);
-                hp.push_back(pathv[0]);
+                _hp.push_back(pathv[0]);
             }
         }
     }
-    if( mirror == true){
+    if (mirror == true) {
         updateCanvasIndicators(false);
     }
 }
@@ -191,58 +193,47 @@ void SatelliteArrayParam::updateCanvasIndicators()
 void SatelliteArrayParam::addCanvasIndicators(
     SPLPEItem const */*lpeitem*/, std::vector<Geom::PathVector> &hp_vec)
 {
-    hp_vec.push_back(hp);
-}
-
-void SatelliteArrayParam::recalculate_knots()
-{
-    if(last_pointwise){
-        _vector = last_pointwise->getSatellites();
-    }
+    hp_vec.push_back(_hp);
 }
 
-void
-SatelliteArrayParam::param_transform_multiply(Geom::Affine const &postmul,
+void SatelliteArrayParam::param_transform_multiply(Geom::Affine const &postmul,
         bool /*set*/)
 {
     Inkscape::Preferences *prefs = Inkscape::Preferences::get();
 
     if (prefs->getBool("/options/transform/rectcorners", true)) {
         for (size_t i = 0; i < _vector.size(); ++i) {
-            if(!_vector[i].isTime && _vector[i].amount > 0){
-                _vector[i].amount = _vector[i].amount * ((postmul.expansionX() + postmul.expansionY()) / 2);
+            if (!_vector[i].isTime && _vector[i].amount > 0) {
+                _vector[i].amount = _vector[i].amount *
+                                    ((postmul.expansionX() + postmul.expansionY()) / 2);
             }
         }
         param_set_and_write_new_value(_vector);
     }
-
-    //    param_set_and_write_new_value( (*this) * postmul );
 }
 
 void SatelliteArrayParam::addKnotHolderEntities(KnotHolder *knotholder,
         SPDesktop *desktop,
-        SPItem *item,
-        bool mirror)
+        SPItem *item, bool mirror)
 {
-    //recalculate_knots();
     for (size_t i = 0; i < _vector.size(); ++i) {
         size_t iPlus = i;
-        if( mirror == true){
+        if (mirror == true) {
             iPlus = i + _vector.size();
         }
-        if(!_vector[i].active){
+        if (!_vector[i].active) {
             continue;
         }
-        if(!_vector[i].hasMirror && mirror == true){
+        if (!_vector[i].hasMirror && mirror == true) {
             continue;
         }
         using namespace Geom;
         SatelliteType type = _vector[i].satelliteType;
         //IF is for filletChamfer effect...
-        if(_effectType == FILLET_CHAMFER){
+        if (_effectType == FILLET_CHAMFER) {
             const gchar *tip;
-            if (type == C){
-                 tip = _("<b>Chamfer</b>: <b>Ctrl+Click</b> toggle type, "
+            if (type == C) {
+                tip = _("<b>Chamfer</b>: <b>Ctrl+Click</b> toggle type, "
                         "<b>Shift+Click</b> open dialog, "
                         "<b>Ctrl+Alt+Click</b> reset");
             } else if (type == IC) {
@@ -261,11 +252,11 @@ void SatelliteArrayParam::addKnotHolderEntities(KnotHolder *knotholder,
             FilletChamferKnotHolderEntity *e =
                 new FilletChamferKnotHolderEntity(this, iPlus);
             e->create(desktop, item, knotholder, Inkscape::CTRL_TYPE_UNKNOWN, _(tip),
-                      knot_shape, knot_mode, knot_color);
+                      _knot_shape, _knot_mode, _knot_color);
             knotholder->add(e);
         }
     }
-    if( mirror == true){
+    if (mirror == true) {
         addKnotHolderEntities(knotholder, desktop, item, false);
     }
 }
@@ -274,159 +265,155 @@ void SatelliteArrayParam::addKnotHolderEntities(KnotHolder *knotholder,
         SPDesktop *desktop,
         SPItem *item)
 {
-        knoth = knotholder;
-        addKnotHolderEntities(knotholder, desktop, item, true);
+    knoth = knotholder;
+    addKnotHolderEntities(knotholder, desktop, item, true);
 }
 
-FilletChamferKnotHolderEntity::FilletChamferKnotHolderEntity(SatelliteArrayParam *p, size_t index) 
-  : _pparam(p), 
-    _index(index)
-{ 
-}
+FilletChamferKnotHolderEntity::FilletChamferKnotHolderEntity(
+    SatelliteArrayParam *p, size_t index)
+    : _pparam(p), _index(index) {}
 
 void FilletChamferKnotHolderEntity::knot_set(Point const &p,
-                                              Point const &/*origin*/,
-                                              guint state)
+        Point const &/*origin*/,
+        guint state)
 {
     Geom::Point s = snap_knot_position(p, state);
     size_t index = _index;
-    if( _index >= _pparam->_vector.size()){
-        index = _index-_pparam->_vector.size();
+    if (_index >= _pparam->_vector.size()) {
+        index = _index - _pparam->_vector.size();
     }
     if (!valid_index(index)) {
         return;
     }
 
-    if( !_pparam->last_pointwise ){
+    if (!_pparam->_last_pointwise) {
         return;
     }
 
     Geom::Satellite satellite = _pparam->_vector.at(index);
-    if(!satellite.active || satellite.hidden){
+    if (!satellite.active || satellite.hidden) {
         return;
     }
-    Geom::Pointwise* pointwise = _pparam->last_pointwise;
+    Geom::Pointwise *pointwise = _pparam->_last_pointwise;
     Geom::Piecewise<Geom::D2<Geom::SBasis> > pwd2 = pointwise->getPwd2();
-    Pathinfo pathInfo(pwd2);
-    if(_pparam->_vector.size() <= _index){
-        boost::optional<size_t> d2_prev_index = pathInfo.getPrevious(index);
-        if(d2_prev_index){
+    Pathinfo path_info(pwd2);
+    if (_pparam->_vector.size() <= _index) {
+        boost::optional<size_t> d2_prev_index = path_info.previous(index);
+        if (d2_prev_index) {
             Geom::D2<Geom::SBasis> d2_in = pwd2[*d2_prev_index];
-            double mirrorTime = Geom::nearest_point(s, d2_in);
-            double timeStart = 0;
+            double mirror_time = Geom::nearest_point(s, d2_in);
+            double time_start = 0;
             std::vector<Geom::Satellite> sats = pointwise->getSatellites();
-            timeStart =  sats[*d2_prev_index].getTime(d2_in);
-            if(timeStart > mirrorTime){
-                mirrorTime = timeStart;
+            time_start = sats[*d2_prev_index].time(d2_in);
+            if (time_start > mirror_time) {
+                mirror_time = time_start;
             }
-            double size = satellite.toSize(mirrorTime, d2_in);
+            double size = satellite.toSize(mirror_time, d2_in);
             double amount = Geom::length(d2_in, Geom::EPSILON) - size;
-            if(satellite.isTime){
-                amount = satellite.toTime(amount,pwd2[index]);
+            if (satellite.isTime) {
+                amount = satellite.toTime(amount, pwd2[index]);
             }
             satellite.amount = amount;
         }
     } else {
-        satellite.setPosition(s,pwd2[index]);
+        satellite.setPosition(s, pwd2[index]);
     }
-     _pparam->_vector.at(index) = satellite;
-    SPLPEItem * splpeitem = dynamic_cast<SPLPEItem *>(item);
-    if(splpeitem){
+    _pparam->_vector.at(index) = satellite;
+    SPLPEItem *splpeitem = dynamic_cast<SPLPEItem *>(item);
+    if (splpeitem) {
         sp_lpe_item_update_patheffect(splpeitem, false, false);
     }
 }
 
-
-Geom::Point 
-FilletChamferKnotHolderEntity::knot_get() const
+Geom::Point FilletChamferKnotHolderEntity::knot_get() const
 {
-    Geom::Point tmpPoint;
+    Geom::Point tmp_point;
     size_t index = _index;
-    if( _index >= _pparam->_vector.size()){
-        index = _index-_pparam->_vector.size();
+    if (_index >= _pparam->_vector.size()) {
+        index = _index - _pparam->_vector.size();
     }
     if (!valid_index(index)) {
         return Point(infinity(), infinity());
     }
     Geom::Satellite satellite = _pparam->_vector.at(index);
-    if(!_pparam->last_pointwise){
+    if (!_pparam->_last_pointwise) {
         return Point(infinity(), infinity());
     }
-    if(!satellite.active || satellite.hidden){
+    if (!satellite.active || satellite.hidden) {
         return Point(infinity(), infinity());
     }
-    Geom::Pointwise* pointwise = _pparam->last_pointwise;
+    Geom::Pointwise *pointwise = _pparam->_last_pointwise;
     Geom::Piecewise<Geom::D2<Geom::SBasis> > pwd2 = pointwise->getPwd2();
-    Pathinfo pathInfo(pwd2);
-    if(pwd2.size() <= index){
+    Pathinfo path_info(pwd2);
+    if (pwd2.size() <= index) {
         return Point(infinity(), infinity());
     }
     this->knot->show();
-    if( _index >= _pparam->_vector.size()){
-        tmpPoint = satellite.getPosition(pwd2[index]);
-        boost::optional<size_t> d2_prev_index = pathInfo.getPrevious(index);
-        if(d2_prev_index){
-            Geom::D2<Geom::SBasis> d2_in =  pwd2[*d2_prev_index];
-            double s = satellite.getSize(pwd2[index]);
-            double t = satellite.getOpositeTime(s,d2_in);
-            if(t > 1){
+    if (_index >= _pparam->_vector.size()) {
+        tmp_point = satellite.getPosition(pwd2[index]);
+        boost::optional<size_t> d2_prev_index = path_info.previous(index);
+        if (d2_prev_index) {
+            Geom::D2<Geom::SBasis> d2_in = pwd2[*d2_prev_index];
+            double s = satellite.size(pwd2[index]);
+            double t = satellite.time(s, true, d2_in);
+            if (t > 1) {
                 t = 1;
             }
-            if(t < 0){
+            if (t < 0) {
                 t = 0;
             }
-            double timeStart = 0;
-            timeStart =  pointwise->getSatellites()[*d2_prev_index].getTime(d2_in);
-            if(timeStart > t){
-                t = timeStart;
+            double time_start = 0;
+            time_start = pointwise->getSatellites()[*d2_prev_index].time(d2_in);
+            if (time_start > t) {
+                t = time_start;
             }
-            tmpPoint = (d2_in).valueAt(t);
+            tmp_point = (d2_in).valueAt(t);
         }
     } else {
-        tmpPoint = satellite.getPosition(pwd2[index]);
+        tmp_point = satellite.getPosition(pwd2[index]);
     }
-    Geom::Point const canvas_point = tmpPoint;
+    Geom::Point const canvas_point = tmp_point;
     return canvas_point;
 }
 
 void FilletChamferKnotHolderEntity::knot_click(guint state)
 {
-    if( !_pparam->last_pointwise){
+    if (!_pparam->_last_pointwise) {
         return;
     }
 
     size_t index = _index;
-    if( _index >= _pparam->_vector.size()){
-        index = _index-_pparam->_vector.size();
+    if (_index >= _pparam->_vector.size()) {
+        index = _index - _pparam->_vector.size();
     }
     if (state & GDK_CONTROL_MASK) {
         if (state & GDK_MOD1_MASK) {
             _pparam->_vector.at(index).amount = 0.0;
             _pparam->param_set_and_write_new_value(_pparam->_vector);
             sp_lpe_item_update_patheffect(SP_LPE_ITEM(item), false, false);
-        }else{
+        } else {
             using namespace Geom;
             SatelliteType type = _pparam->_vector.at(index).satelliteType;
-            switch(type){
-                case F:
-                    type = IF;
-                    break;
-                case IF:
-                    type =  C;
-                    break;
-                case C:
-                    type =  IC;
-                    break;
-                default:
-                    type = F;
-                    break;
+            switch (type) {
+            case F:
+                type = IF;
+                break;
+            case IF:
+                type = C;
+                break;
+            case C:
+                type = IC;
+                break;
+            default:
+                type = F;
+                break;
             }
             _pparam->_vector.at(index).satelliteType = type;
             _pparam->param_set_and_write_new_value(_pparam->_vector);
             sp_lpe_item_update_patheffect(SP_LPE_ITEM(item), false, false);
             const gchar *tip;
-            if (type == C){
-                 tip = _("<b>Chamfer</b>: <b>Ctrl+Click</b> toggle type, "
+            if (type == C) {
+                tip = _("<b>Chamfer</b>: <b>Ctrl+Click</b> toggle type, "
                         "<b>Shift+Click</b> open dialog, "
                         "<b>Ctrl+Alt+Click</b> reset");
             } else if (type == IC) {
@@ -446,55 +433,63 @@ void FilletChamferKnotHolderEntity::knot_click(guint state)
             this->knot->show();
         }
     } else if (state & GDK_SHIFT_MASK) {
-        Piecewise<D2<SBasis> > pwd2 = _pparam->last_pointwise->getPwd2();
-        Pathinfo pathInfo(pwd2);
-        double amount = _pparam->_vector.at(index).amount; 
-        if(!_pparam->use_distance && !_pparam->_vector.at(index).isTime){
-            boost::optional<size_t> prev = pathInfo.getPrevious(index);
+        Piecewise<D2<SBasis> > pwd2 = _pparam->_last_pointwise->getPwd2();
+        Pathinfo path_info(pwd2);
+        double amount = _pparam->_vector.at(index).amount;
+        if (!_pparam->_use_distance && !_pparam->_vector.at(index).isTime) {
+            boost::optional<size_t> prev = path_info.previous(index);
             boost::optional<Geom::D2<Geom::SBasis> > prevPwd2 = boost::none;
-            boost::optional<Geom::Satellite > prevSat = boost::none;
-            if(prev){
+            boost::optional<Geom::Satellite> prevSat = boost::none;
+            if (prev) {
                 prevPwd2 = pwd2[*prev];
                 prevSat = _pparam->_vector.at(*prev);
             }
-            amount = _pparam->_vector.at(index).len_to_rad(amount,  prevPwd2, pwd2[index], prevSat);
+            amount = _pparam->_vector.at(index)
+                     .lenToRad(amount, prevPwd2, pwd2[index], prevSat);
         }
         bool aprox = false;
-        D2<SBasis> d2_out = _pparam->last_pointwise->getPwd2()[index];
-        boost::optional<size_t> d2_prev_index = pathInfo.getPrevious(index);
-        if(d2_prev_index){
-            Geom::D2<Geom::SBasis> d2_in =  _pparam->last_pointwise->getPwd2()[*d2_prev_index];
-            aprox = ((d2_in)[0].degreesOfFreedom() != 2 || d2_out[0].degreesOfFreedom() != 2) && !_pparam->use_distance?true:false;
+        D2<SBasis> d2_out = _pparam->_last_pointwise->getPwd2()[index];
+        boost::optional<size_t> d2_prev_index = path_info.previous(index);
+        if (d2_prev_index) {
+            Geom::D2<Geom::SBasis> d2_in =
+                _pparam->_last_pointwise->getPwd2()[*d2_prev_index];
+            aprox = ((d2_in)[0].degreesOfFreedom() != 2 ||
+                     d2_out[0].degreesOfFreedom() != 2) &&
+                    !_pparam->_use_distance
+                    ? true
+                    : false;
         }
         Inkscape::UI::Dialogs::FilletChamferPropertiesDialog::showDialog(
-            this->desktop, amount , this, _pparam->unit, _pparam->use_distance, aprox, _pparam->documentUnit,_pparam->_vector.at(index));
-    
+            this->desktop, amount, this, _pparam->_unit, _pparam->_use_distance,
+            aprox, _pparam->_documentUnit, _pparam->_vector.at(index));
+
     }
 }
 
 void FilletChamferKnotHolderEntity::knot_set_offset(Geom::Satellite satellite)
 {
-    if( !_pparam->last_pointwise){
+    if (!_pparam->_last_pointwise) {
         return;
     }
     size_t index = _index;
-    if( _index >= _pparam->_vector.size()){
-        index = _index-_pparam->_vector.size();
+    if (_index >= _pparam->_vector.size()) {
+        index = _index - _pparam->_vector.size();
     }
     double amount = satellite.amount;
-    double maxAmount = amount;
-    if(!_pparam->use_distance && !satellite.isTime){
-        Piecewise<D2<SBasis> > pwd2 = _pparam->last_pointwise->getPwd2();
-        Pathinfo pathInfo(pwd2);
-        boost::optional<size_t> prev = pathInfo.getPrevious(index);
+    double max_amount = amount;
+    if (!_pparam->_use_distance && !satellite.isTime) {
+        Piecewise<D2<SBasis> > pwd2 = _pparam->_last_pointwise->getPwd2();
+        Pathinfo path_info(pwd2);
+        boost::optional<size_t> prev = path_info.previous(index);
         boost::optional<Geom::D2<Geom::SBasis> > prevPwd2 = boost::none;
-        boost::optional<Geom::Satellite > prevSat = boost::none;
-        if(prev){
+        boost::optional<Geom::Satellite> prevSat = boost::none;
+        if (prev) {
             prevPwd2 = pwd2[*prev];
             prevSat = _pparam->_vector.at(*prev);
         }
-        amount = _pparam->_vector.at(index).rad_to_len(amount,  prevPwd2, pwd2[index], prevSat);
-        if(maxAmount > 0 && amount == 0){
+        amount = _pparam->_vector.at(index)
+                 .radToLen(amount, prevPwd2, pwd2[index], prevSat);
+        if (max_amount > 0 && amount == 0) {
             amount = _pparam->_vector.at(index).amount;
         }
     }
@@ -502,8 +497,8 @@ void FilletChamferKnotHolderEntity::knot_set_offset(Geom::Satellite satellite)
     _pparam->_vector.at(index) = satellite;
     this->parent_holder->knot_ungrabbed_handler(this->knot, 0);
     _pparam->param_set_and_write_new_value(_pparam->_vector);
-    SPLPEItem * splpeitem = dynamic_cast<SPLPEItem *>(item);
-    if(splpeitem){
+    SPLPEItem *splpeitem = dynamic_cast<SPLPEItem *>(item);
+    if (splpeitem) {
         sp_lpe_item_update_patheffect(splpeitem, false, false);
     }
 }
diff --git a/src/live_effects/parameter/satellitearray.h b/src/live_effects/parameter/satellitearray.h
index ee0cfbad3..bb53af12b 100644
--- a/src/live_effects/parameter/satellitearray.h
+++ b/src/live_effects/parameter/satellitearray.h
@@ -10,11 +10,11 @@
  * To Nathan Hurst for his review and help on refactor
  * and finaly to Liam P. White for his big help on coding, that save me a lot of
  * hours
- * 
- * 
+ *
+ *
  * This parameter act as bridge from pointwise class to serialize it as a LPE
  * parameter
- * 
+ *
  * Released under GNU GPL, read the file 'COPYING' for more information
  */
 
@@ -32,69 +32,80 @@ class FilletChamferKnotHolderEntity;
 
 class SatelliteArrayParam : public ArrayParam<Geom::Satellite> {
 public:
-    SatelliteArrayParam(const Glib::ustring &label,
-                                 const Glib::ustring &tip,
-                                 const Glib::ustring &key,
-                                 Inkscape::UI::Widget::Registry *wr,
-                                 Effect *effect);
+    SatelliteArrayParam(const Glib::ustring &label, const Glib::ustring &tip,
+                        const Glib::ustring &key,
+                        Inkscape::UI::Widget::Registry *wr, Effect *effect);
     virtual ~SatelliteArrayParam();
 
-    virtual Gtk::Widget * param_newWidget() {
+    virtual Gtk::Widget *param_newWidget()
+    {
         return NULL;
     }
-
-    void set_oncanvas_looks(SPKnotShapeType shape, SPKnotModeType mode,
-                            guint32 color);
-    virtual void set_helper_size(int hs);
-    virtual void addKnotHolderEntities(KnotHolder *knotholder, SPDesktop *desktop, SPItem *item);
-    virtual void addKnotHolderEntities(KnotHolder *knotholder, SPDesktop *desktop, SPItem *item, bool mirror);
-    virtual void addCanvasIndicators(SPLPEItem const *lpeitem,std::vector<Geom::PathVector> &hp_vec);
-    virtual bool providesKnotHolderEntities() const {
+    virtual void setHelperSize(int hs);
+    virtual void addKnotHolderEntities(KnotHolder *knotholder, SPDesktop *desktop,
+                                       SPItem *item);
+    virtual void addKnotHolderEntities(KnotHolder *knotholder, SPDesktop *desktop,
+                                       SPItem *item, bool mirror);
+    virtual void addCanvasIndicators(SPLPEItem const *lpeitem,
+                                     std::vector<Geom::PathVector> &hp_vec);
+    virtual void updateCanvasIndicators();
+    virtual void updateCanvasIndicators(bool mirror);
+    virtual bool providesKnotHolderEntities() const
+    {
         return true;
     }
     void param_transform_multiply(Geom::Affine const &postmul, bool /*set*/);
-    void set_document_unit(Glib::ustring value_document_unit);
-    void set_use_distance(bool use_knot_distance );
-    void set_unit(const gchar *abbr);
-    void set_effect_type(EffectType et);
-    void recalculate_knots();
-    virtual void updateCanvasIndicators();
-    virtual void updateCanvasIndicators(bool mirror);
-    void set_pointwise(Geom::Pointwise *pointwise);
+    void setDocumentUnit(Glib::ustring value_document__unit);
+    void setUseDistance(bool use_knot_distance);
+    void setUnit(const gchar *abbr);
+    void setEffectType(EffectType et);
+    void setPointwise(Geom::Pointwise *pointwise);
+    void set_oncanvas_looks(SPKnotShapeType shape, SPKnotModeType mode,
+                            guint32 color);
+
     friend class FilletChamferKnotHolderEntity;
     friend class LPEFilletChamfer;
+
 protected:
     KnotHolder *knoth;
+
 private:
     SatelliteArrayParam(const SatelliteArrayParam &);
     SatelliteArrayParam &operator=(const SatelliteArrayParam &);
 
-    SPKnotShapeType knot_shape;
-    SPKnotModeType knot_mode;
-    guint32 knot_color;
-    Geom::PathVector hp;
-    int helper_size;
-    bool use_distance;
-    const gchar *unit;
-    Glib::ustring documentUnit;
+    SPKnotShapeType _knot_shape;
+    SPKnotModeType _knot_mode;
+    guint32 _knot_color;
+    Geom::PathVector _hp;
+    int _helper_size;
+    bool _use_distance;
+    const gchar *_unit;
+    Glib::ustring _documentUnit;
     EffectType _effectType;
-    Geom::Pointwise *last_pointwise;
+    Geom::Pointwise *_last_pointwise;
 
 };
 
 class FilletChamferKnotHolderEntity : public KnotHolderEntity {
 public:
     FilletChamferKnotHolderEntity(SatelliteArrayParam *p, size_t index);
-    virtual ~FilletChamferKnotHolderEntity() {_pparam->knoth = NULL;}
+    virtual ~FilletChamferKnotHolderEntity()
+    {
+        _pparam->knoth = NULL;
+    }
 
-    virtual void knot_set(Geom::Point const &p, Geom::Point const &origin, guint state);
+    virtual void knot_set(Geom::Point const &p, Geom::Point const &origin,
+                          guint state);
     virtual Geom::Point knot_get() const;
     virtual void knot_click(guint state);
     void knot_set_offset(Geom::Satellite);
-    /** Checks whether the index falls within the size of the parameter's vector */
-    bool valid_index(size_t index) const {
+    /** Checks whether the index falls within the size of the parameter's vector
+     */
+    bool valid_index(size_t index) const
+    {
         return (_pparam->_vector.size() > index);
-    };
+    }
+    ;
 
 private:
     SatelliteArrayParam *_pparam;