summaryrefslogtreecommitdiffstats
path: root/src/object/sp-guide.cpp
diff options
context:
space:
mode:
authorShlomi Fish <shlomif@shlomifish.org>2019-05-23 08:06:12 +0000
committerShlomi Fish <shlomif@shlomifish.org>2019-06-06 12:57:27 +0000
commitcb8c36249e983866378e7915e6605ef92d247923 (patch)
tree53ec0a0745250375aaeb4b5a52f821380ccb614a /src/object/sp-guide.cpp
parentCI: Avoid failure due to sorting issue (diff)
downloadinkscape-cb8c36249e983866378e7915e6605ef92d247923.tar.gz
inkscape-cb8c36249e983866378e7915e6605ef92d247923.zip
Refactoring: call setAttribute() directly.
Call this->setAttribute(...) directly instead of this->getRepr()->setAttribute(...). This avoids clutter and mental indirection. See http://wiki.inkscape.org/wiki/index.php?title=Refactoring_projects&oldid=112116 and https://en.wikipedia.org/wiki/Law_of_Demeter . --- I hereby disclaim any implicit or explicit ownership of my changes in this changeset, and put them under a multiple licence consisting of your choice of one of more of: - The CC0 / Public Domain - https://creativecommons.org/choose/zero/ . - The MIT / Expat license - https://en.wikipedia.org/wiki/MIT_License - The default licence of your project - The https://en.wikipedia.org/wiki/GNU_Lesser_General_Public_License - version 2.1 or higher - The https://en.wikipedia.org/wiki/GNU_General_Public_License - version 2 or higher - Any licence in the 2018-Aug-27 popular licenses list of https://opensource.org/licenses - The https://en.wikipedia.org/wiki/Apache_License version 2.0 or later - The https://en.wikipedia.org/wiki/Artistic_License version 2.0 or later - The https://en.wikipedia.org/wiki/ISC_license - The https://opensource.org/licenses/BSD-2-Clause Crediting me will be nice, but not mandatory, and you can change the licence of the project without needing my permission.
Diffstat (limited to 'src/object/sp-guide.cpp')
-rw-r--r--src/object/sp-guide.cpp6
1 files changed, 3 insertions, 3 deletions
diff --git a/src/object/sp-guide.cpp b/src/object/sp-guide.cpp
index 4fe73ca4e..853511d42 100644
--- a/src/object/sp-guide.cpp
+++ b/src/object/sp-guide.cpp
@@ -471,7 +471,7 @@ void SPGuide::set_color(const unsigned r, const unsigned g, const unsigned b, bo
std::ostringstream os;
os << "rgb(" << r << "," << g << "," << b << ")";
//XML Tree being used directly while it shouldn't be
- getRepr()->setAttribute("inkscape:color", os.str().c_str());
+ setAttribute("inkscape:color", os.str());
}
}
@@ -483,7 +483,7 @@ void SPGuide::set_locked(const bool locked, bool const commit)
}
if (commit) {
- getRepr()->setAttribute("inkscape:locked", g_strdup(locked ? "true" : "false"));
+ setAttribute("inkscape:locked", locked ? "true" : "false");
}
}
@@ -495,7 +495,7 @@ void SPGuide::set_label(const char* label, bool const commit)
if (commit) {
//XML Tree being used directly while it shouldn't be
- getRepr()->setAttribute("inkscape:label", label);
+ setAttribute("inkscape:label", label);
}
}