summaryrefslogtreecommitdiffstats
path: root/src/preferences.cpp
diff options
context:
space:
mode:
authorJohan B. C. Engelen <jbc.engelen@swissonline.ch>2013-10-12 22:24:05 +0000
committerJohan B. C. Engelen <j.b.c.engelen@alumnus.utwente.nl>2013-10-12 22:24:05 +0000
commita970dc423d59ea844bdb1af48d5d9419a5e2a287 (patch)
tree8f6a51df0574fe048ae7e791f276e72716aa090c /src/preferences.cpp
parentFix crash with experimental lpe tool. (diff)
downloadinkscape-a970dc423d59ea844bdb1af48d5d9419a5e2a287.tar.gz
inkscape-a970dc423d59ea844bdb1af48d5d9419a5e2a287.zip
Units: stop newing Unit objects. pass around pointers to "undeletable" Unit objects in the UnitTable. I think we should move to using indexed units, and pass around the index of the unit in the unittable, or smth like that... ?
(bzr r12679)
Diffstat (limited to 'src/preferences.cpp')
-rw-r--r--src/preferences.cpp3
1 files changed, 1 insertions, 2 deletions
diff --git a/src/preferences.cpp b/src/preferences.cpp
index 0dc6f1ec4..0dcebbb90 100644
--- a/src/preferences.cpp
+++ b/src/preferences.cpp
@@ -785,9 +785,8 @@ double Preferences::_extractDouble(Entry const &v, Glib::ustring const &requeste
if (unit.length() == 0) {
// no unit specified, don't do conversion
return val;
- } else {
- return val * (unit_table.getUnit(unit).factor / unit_table.getUnit(requested_unit).factor);
}
+ return val * (unit_table.getUnit(unit)->factor / unit_table.getUnit(requested_unit)->factor); /// \todo rewrite using Quantity class, so the standard code handles unit conversion
}
Glib::ustring Preferences::_extractString(Entry const &v)