bzr merge lp:~mc.../inkscape/SelContainer

The main change of this branch is that the container for selections is now a std::vector and not a GSList.
This change propagates in most of the codebase.

Normally, there are no changes of semantics, except the following: 

-> childList is now in the intuitive order (childList()[0] is now firstChild)
-> sp_selection_paste_impl is now in the opposite order (change is local to selection-chemistry.cpp, and simplify a few things there)
-> selection.setReprList now takes the list in the opposite order. It was always the case (the list was always reversed before handing to it)
-> a few comparison functions now work "the c++ way": the C way was to return -1 if a<b, 0 if a==b and 1 if a>b, now they return (bool)(a<b) so they can be used with std::sort

(bzr r14074)

1 files changed, 11 insertions, 13 deletions

diff --git a/src/sp-switch.cpp b/src/sp-switch.cpp
index 66cec3637..cfc0e7d8b 100644
--- a/src/sp-switch.cpp
+++ b/src/sp-switch.cpp
@@ -41,21 +41,22 @@ SPObject *SPSwitch::_evaluateFirst() {
     return first;
 }
 
-GSList *SPSwitch::_childList(bool add_ref, SPObject::Action action) {
+std::vector<SPObject*> SPSwitch::_childList(bool add_ref, SPObject::Action action) {
     if ( action != SPObject::ActionGeneral ) {
         return this->childList(add_ref, action);
     }
 
     SPObject *child = _evaluateFirst();
+    std::vector<SPObject*> x;
     if (NULL == child)
-        return NULL;
+        return x;
 
     if (add_ref) {
         //g_object_ref (G_OBJECT (child));
     	sp_object_ref(child);
     }
-
-    return g_slist_prepend (NULL, child);
+    x.push_back(child);
+    return x;
 }
 
 const char *SPSwitch::displayName() const {
@@ -95,10 +96,9 @@ void SPSwitch::_reevaluate(bool /*add_to_drawing*/) {
 
     _releaseLastItem(_cached_item);
 
-    for ( GSList *l = _childList(false, SPObject::ActionShow);
-            NULL != l ; l = g_slist_remove (l, l->data))
-    {
-        SPObject *o = SP_OBJECT (l->data);
+    std::vector<SPObject*> item_list = _childList(false, SPObject::ActionShow);
+    for ( std::vector<SPObject*>::const_reverse_iterator iter=item_list.rbegin();iter!=item_list.rend();iter++) {
+        SPObject *o = *iter;
         if ( !SP_IS_ITEM (o) ) {
             continue;
         }
@@ -130,10 +130,10 @@ void SPSwitch::_releaseLastItem(SPObject *obj)
 void SPSwitch::_showChildren (Inkscape::Drawing &drawing, Inkscape::DrawingItem *ai, unsigned int key, unsigned int flags) {
     SPObject *evaluated_child = this->_evaluateFirst();
 
-    GSList *l = this->_childList(false, SPObject::ActionShow);
+    std::vector<SPObject*> l = this->_childList(false, SPObject::ActionShow);
 
-    while (l) {
-        SPObject *o = SP_OBJECT (l->data);
+    for ( std::vector<SPObject*>::const_reverse_iterator iter=l.rbegin();iter!=l.rend();iter++) {
+        SPObject *o = *iter;
 
         if (SP_IS_ITEM (o)) {
             SPItem * child = SP_ITEM(o);
@@ -144,8 +144,6 @@ void SPSwitch::_showChildren (Inkscape::Drawing &drawing, Inkscape::DrawingItem
                 ai->appendChild(ac);
             }
         }
-
-        l = g_slist_remove (l, o);
     }
 }