bzr merge lp:~mc.../inkscape/SelContainer

The main change of this branch is that the container for selections is now a std::vector and not a GSList.
This change propagates in most of the codebase.

Normally, there are no changes of semantics, except the following: 

-> childList is now in the intuitive order (childList()[0] is now firstChild)
-> sp_selection_paste_impl is now in the opposite order (change is local to selection-chemistry.cpp, and simplify a few things there)
-> selection.setReprList now takes the list in the opposite order. It was always the case (the list was always reversed before handing to it)
-> a few comparison functions now work "the c++ way": the C way was to return -1 if a<b, 0 if a==b and 1 if a>b, now they return (bool)(a<b) so they can be used with std::sort

(bzr r14074)

1 files changed, 7 insertions, 10 deletions

diff --git a/src/ui/interface.cpp b/src/ui/interface.cpp
index 87438ac01..760d19e89 100644
--- a/src/ui/interface.cpp
+++ b/src/ui/interface.cpp
@@ -1906,11 +1906,10 @@ void ContextMenu::ActivateGroup(void)
 
 void ContextMenu::ActivateUngroup(void)
 {
-    GSList *children = NULL;
+	std::vector<SPItem*> children;
 
-    sp_item_group_ungroup(static_cast<SPGroup*>(_item), &children);
+    sp_item_group_ungroup(static_cast<SPGroup*>(_item), children);
     _desktop->selection->setList(children);
-    g_slist_free(children);
 }
 
 void ContextMenu::MakeAnchorMenu(void)
@@ -1959,10 +1958,9 @@ void ContextMenu::AnchorLinkFollow(void)
 
 void ContextMenu::AnchorLinkRemove(void)
 {
-    GSList *children = NULL;
-    sp_item_group_ungroup(static_cast<SPAnchor*>(_item), &children, false);
+	std::vector<SPItem*> children;
+    sp_item_group_ungroup(static_cast<SPAnchor*>(_item), children, false);
     DocumentUndo::done(_desktop->doc(), SP_VERB_NONE, _("Remove link"));
-    g_slist_free(children);
 }
 
 void ContextMenu::MakeImageMenu (void)
@@ -2051,8 +2049,6 @@ void ContextMenu::ImageEdit(void)
         _desktop->selection->set(_item);
     }
 
-    GSList const *selected = _desktop->selection->itemList();
-
     GError* errThing = 0;
     Glib::ustring cmdline = getImageEditorName();
     Glib::ustring name;
@@ -2079,8 +2075,9 @@ void ContextMenu::ImageEdit(void)
     }
 #endif
 
-    for (GSList const *iter = selected; iter != NULL; iter = iter->next) {
-        Inkscape::XML::Node *ir = SP_ITEM(iter->data)->getRepr();
+    std::vector<SPItem*> itemlist=_desktop->selection->itemList();
+    for(std::vector<SPItem*>::const_iterator i=itemlist.begin();i!=itemlist.end();i++){
+        Inkscape::XML::Node *ir = (*i)->getRepr();
         const gchar *href = ir->attribute("xlink:href");
         
         if (strncmp (href,"file:",5) == 0) {