reduce usage of desktop coordinates (#341)

- avoid unnecessary internal usage of desktop coordinates, e.g.
  in SpellCheck::compareTextBboxes
- document whether a function argument is in document  or desktop
  coordinates, e.g. for SPDocument::getItemsInBox

1 files changed, 5 insertions, 1 deletions

diff --git a/src/ui/tools/node-tool.cpp b/src/ui/tools/node-tool.cpp
index a14114cb7..63161b3cd 100644
--- a/src/ui/tools/node-tool.cpp
+++ b/src/ui/tools/node-tool.cpp
@@ -723,13 +723,17 @@ void NodeTool::update_tip(GdkEvent *event) {
     }
 }
 
+/**
+ * @param sel Area in desktop coordinates
+ */
 void NodeTool::select_area(Geom::Rect const &sel, GdkEventButton *event) {
     using namespace Inkscape::UI;
 
     if (this->_multipath->empty()) {
         // if multipath is empty, select rubberbanded items rather than nodes
         Inkscape::Selection *selection = this->desktop->selection;
-        std::vector<SPItem*> items = this->desktop->getDocument()->getItemsInBox(this->desktop->dkey, sel);
+        auto sel_doc = desktop->dt2doc() * sel;
+        std::vector<SPItem*> items = this->desktop->getDocument()->getItemsInBox(this->desktop->dkey, sel_doc);
         selection->setList(items);
     } else {
         if (!held_shift(*event)) {