summaryrefslogtreecommitdiffstats
path: root/src
diff options
context:
space:
mode:
authorJabier Arraiza <jabier.arraiza@marker.es>2018-11-05 23:20:35 +0000
committerJabier Arraiza <jabier.arraiza@marker.es>2018-11-05 23:20:35 +0000
commit004bd7b0af9c71afd2253c9750fc6fd1f2dd821b (patch)
treee8ccd7eb3c6fad344f8284f6453160fba5459293 /src
parentRemove unused functions (diff)
downloadinkscape-004bd7b0af9c71afd2253c9750fc6fd1f2dd821b.tar.gz
inkscape-004bd7b0af9c71afd2253c9750fc6fd1f2dd821b.zip
Remove into filtered groups
Diffstat (limited to 'src')
-rw-r--r--src/document.cpp18
-rw-r--r--src/document.h4
-rw-r--r--src/ui/contextmenu.cpp2
-rw-r--r--src/ui/tools/measure-tool.cpp2
4 files changed, 13 insertions, 13 deletions
diff --git a/src/document.cpp b/src/document.cpp
index a9cf5e441..388c89d94 100644
--- a/src/document.cpp
+++ b/src/document.cpp
@@ -1388,8 +1388,7 @@ static std::vector<SPItem*> &find_items_in_area(std::vector<SPItem*> &s,
bool take_hidden = false,
bool take_insensitive = false,
bool take_groups = true,
- bool enter_groups = false,
- bool enter_filtered = true)
+ bool enter_groups = false)
{
g_return_val_if_fail(SP_IS_GROUP(group), s);
@@ -1397,8 +1396,8 @@ static std::vector<SPItem*> &find_items_in_area(std::vector<SPItem*> &s,
if (SPItem *item = dynamic_cast<SPItem *>(&o)) {
if (SPGroup * childgroup = dynamic_cast<SPGroup *>(item)) {
bool is_layer = childgroup->effectiveLayerMode(dkey) == SPGroup::LAYER;
- if (is_layer || (enter_groups && (!childgroup->isFiltered() || enter_filtered))) {
- s = find_items_in_area(s, childgroup, dkey, area, test, take_hidden, take_insensitive, take_groups, enter_groups ,enter_filtered);
+ if (is_layer || (enter_groups)) {
+ s = find_items_in_area(s, childgroup, dkey, area, test, take_hidden, take_insensitive, take_groups, enter_groups);
}
if (!take_groups || is_layer) {
continue;
@@ -1562,16 +1561,18 @@ static SPItem *find_group_at_point(unsigned int dkey, SPGroup *group, Geom::Poin
return seen;
}
+
/*
* Return list of items, contained in box
*
* Assumes box is normalized (and g_asserts it!)
*
*/
-std::vector<SPItem*> SPDocument::getItemsInBox(unsigned int dkey, Geom::Rect const &box, bool take_hidden, bool take_insensitive, bool take_groups, bool enter_groups ,bool enter_filtered) const
+
+std::vector<SPItem*> SPDocument::getItemsInBox(unsigned int dkey, Geom::Rect const &box, bool take_hidden, bool take_insensitive, bool take_groups, bool enter_groups) const
{
std::vector<SPItem*> x;
- return find_items_in_area(x, SP_GROUP(this->root), dkey, box, is_within, take_hidden, take_insensitive, take_groups, enter_groups ,enter_filtered);
+ return find_items_in_area(x, SP_GROUP(this->root), dkey, box, is_within, take_hidden, take_insensitive, take_groups, enter_groups);
}
/*
@@ -1582,14 +1583,13 @@ std::vector<SPItem*> SPDocument::getItemsInBox(unsigned int dkey, Geom::Rect con
* @param take_insensitive get insensitive items
* @param take_groups get also the groups
* @param enter_groups get items inside groups
- * @param enter_filtered get items inside filtered groups
* @return Return list of items, that the parts of the item contained in box
*/
-std::vector<SPItem*> SPDocument::getItemsPartiallyInBox(unsigned int dkey, Geom::Rect const &box, bool take_hidden, bool take_insensitive, bool take_groups, bool enter_groups ,bool enter_filtered) const
+std::vector<SPItem*> SPDocument::getItemsPartiallyInBox(unsigned int dkey, Geom::Rect const &box, bool take_hidden, bool take_insensitive, bool take_groups, bool enter_groups) const
{
std::vector<SPItem*> x;
- return find_items_in_area(x, SP_GROUP(this->root), dkey, box, overlaps, take_hidden, take_insensitive, take_groups, enter_groups ,enter_filtered);
+ return find_items_in_area(x, SP_GROUP(this->root), dkey, box, overlaps, take_hidden, take_insensitive, take_groups, enter_groups);
}
std::vector<SPItem*> SPDocument::getItemsAtPoints(unsigned const key, std::vector<Geom::Point> points, bool all_layers, size_t limit) const
diff --git a/src/document.h b/src/document.h
index 1f16d2ad8..08ca712f4 100644
--- a/src/document.h
+++ b/src/document.h
@@ -288,8 +288,8 @@ public:
bool addResource(char const *key, SPObject *object);
bool removeResource(char const *key, SPObject *object);
std::vector<SPObject *> const getResourceList(char const *key);
- std::vector<SPItem*> getItemsInBox (unsigned int dkey, Geom::Rect const &box, bool take_hidden = false, bool take_insensitive = false, bool take_groups = true, bool enter_groups = false, bool enter_filtered = true) const;
- std::vector<SPItem*> getItemsPartiallyInBox(unsigned int dkey, Geom::Rect const &box, bool take_hidden = false, bool take_insensitive = false, bool take_groups = true, bool enter_groups = false, bool enter_filtered = true) const;
+ std::vector<SPItem*> getItemsInBox (unsigned int dkey, Geom::Rect const &box, bool take_hidden = false, bool take_insensitive = false, bool take_groups = true, bool enter_groups = false) const;
+ std::vector<SPItem*> getItemsPartiallyInBox(unsigned int dkey, Geom::Rect const &box, bool take_hidden = false, bool take_insensitive = false, bool take_groups = true, bool enter_groups = false) const;
SPItem *getItemAtPoint(unsigned int key, Geom::Point const &p, bool into_groups, SPItem *upto = nullptr) const;
std::vector<SPItem*> getItemsAtPoints(unsigned const key, std::vector<Geom::Point> points, bool all_layers = true, size_t limit = 0) const ;
SPItem *getGroupAtPoint(unsigned int key, Geom::Point const &p) const;
diff --git a/src/ui/contextmenu.cpp b/src/ui/contextmenu.cpp
index 2a4415afa..7686789b4 100644
--- a/src/ui/contextmenu.cpp
+++ b/src/ui/contextmenu.cpp
@@ -89,7 +89,7 @@ ContextMenu::ContextMenu(SPDesktop *desktop, SPItem *item) :
AddSeparator();
/* Lock/Unock Hide/Unhide*/
Geom::Rect b(_desktop->point(),_desktop->point() + Geom::Point(1,1));
- std::vector< SPItem * > down_items = _desktop->getDocument()->getItemsPartiallyInBox( _desktop->dkey, b, true, true, true, true, true);
+ std::vector< SPItem * > down_items = _desktop->getDocument()->getItemsPartiallyInBox( _desktop->dkey, b, true, true, true, true);
bool has_down_hidden = false;
bool has_down_locked = false;
for(std::vector< SPItem * >::iterator down = down_items.begin(); down != down_items.end(); ++down){
diff --git a/src/ui/tools/measure-tool.cpp b/src/ui/tools/measure-tool.cpp
index 2a2578910..17ae52a81 100644
--- a/src/ui/tools/measure-tool.cpp
+++ b/src/ui/tools/measure-tool.cpp
@@ -1300,7 +1300,7 @@ void MeasureTool::showCanvasItems(bool to_guides, bool to_item, bool to_phantom,
std::vector<SPItem*> items;
SPDocument *doc = desktop->getDocument();
Geom::Rect rect(start_p, end_p);
- items = doc->getItemsPartiallyInBox(desktop->dkey, rect, false, true, false, true, true);
+ items = doc->getItemsPartiallyInBox(desktop->dkey, rect, false, true, false, true);
Inkscape::LayerModel *layer_model = nullptr;
SPObject *current_layer = nullptr;
if(desktop){