Make ToolBase::cursor use gdkmm and smart pointers.

4 files changed, 16 insertions, 23 deletions

diff --git a/src/desktop-events.cpp b/src/desktop-events.cpp
index c48b06a9c..feeddbdff 100644
--- a/src/desktop-events.cpp
+++ b/src/desktop-events.cpp
@@ -563,7 +563,7 @@ gint sp_dt_guide_event(SPCanvasItem *item, GdkEvent *event, gpointer data)
             sp_guideline_set_color(SP_GUIDELINE(item), guide->getColor());
 
             // restore event context's cursor
-            gdk_window_set_cursor(gtk_widget_get_window (GTK_WIDGET(desktop->getCanvas())), desktop->event_context->cursor);
+            Glib::wrap(GTK_WIDGET(desktop->getCanvas()))->get_window()->set_cursor(desktop->event_context->cursor);
 
             desktop->guidesMessageContext()->clear();
             break;
diff --git a/src/ui/tools/select-tool.cpp b/src/ui/tools/select-tool.cpp
index ddc6e2881..b412812b6 100644
--- a/src/ui/tools/select-tool.cpp
+++ b/src/ui/tools/select-tool.cpp
@@ -21,6 +21,7 @@
 #include <cstring>
 #include <string>
 
+#include <gtkmm/widget.h>
 #include <gdk/gdkkeysyms.h>
 #include <glibmm/i18n.h>
 
@@ -344,9 +345,9 @@ bool SelectTool::item_handler(SPItem* item, GdkEvent* event) {
         }
         case GDK_LEAVE_NOTIFY:
             if (!desktop->isWaitingCursor() && !this->dragging) {
-                GdkWindow* window = gtk_widget_get_window (GTK_WIDGET (desktop->getCanvas()));
+                Glib::RefPtr<Gdk::Window> window = Glib::wrap(GTK_WIDGET(desktop->getCanvas()))->get_window();
 
-                gdk_window_set_cursor(window, this->cursor);
+                window->set_cursor(this->cursor);
             }
             break;
 
diff --git a/src/ui/tools/tool-base.cpp b/src/ui/tools/tool-base.cpp
index 9f9a155c2..587788e39 100644
--- a/src/ui/tools/tool-base.cpp
+++ b/src/ui/tools/tool-base.cpp
@@ -123,11 +123,6 @@ ToolBase::~ToolBase() {
         delete this->message_context;
     }
 
-    if (this->cursor != NULL) {
-        g_object_unref(this->cursor);
-        this->cursor = NULL;
-    }
-
     if (this->desktop) {
         this->desktop = NULL;
     }
@@ -161,27 +156,23 @@ void ToolBase::sp_event_context_set_cursor(GdkCursorType cursor_type) {
  * Recreates and draws cursor on desktop related to ToolBase.
  */
 void ToolBase::sp_event_context_update_cursor() {
-    GtkWidget *w = GTK_WIDGET(this->desktop->getCanvas());
-    if (gtk_widget_get_window (w)) {
+    Gtk::Widget* w = Glib::wrap(GTK_WIDGET(desktop->getCanvas()));
+    if (w->get_window()) {
         if (this->cursor_shape) {
-            if(this->cursor) {
-                g_object_unref(this->cursor);
-            }
-
 	    bool fillHasColor=false, strokeHasColor=false;
 	    guint32 fillColor = sp_desktop_get_color_tool(this->desktop, this->getPrefsPath(), true, &fillHasColor);
 	    guint32 strokeColor = sp_desktop_get_color_tool(this->desktop, this->getPrefsPath(), false, &strokeHasColor);
 	    double fillOpacity = fillHasColor ? sp_desktop_get_opacity_tool(this->desktop, this->getPrefsPath(), true) : 0;
 	    double strokeOpacity = strokeHasColor ? sp_desktop_get_opacity_tool(this->desktop, this->getPrefsPath(), false) : 0;
 
-            this->cursor = sp_cursor_from_xpm(
+            this->cursor = Glib::wrap(sp_cursor_from_xpm(
 		this->cursor_shape,
                 SP_RGBA32_C_COMPOSE(fillColor, fillOpacity),
                 SP_RGBA32_C_COMPOSE(strokeColor, strokeOpacity)
-            );
+            ));
         }
-        gdk_window_set_cursor(gtk_widget_get_window (w), this->cursor);
-        gdk_flush();
+        w->get_window()->set_cursor(cursor);
+        w->get_display()->flush();
     }
     this->desktop->waiting_cursor = false;
 }
@@ -546,8 +537,8 @@ bool ToolBase::root_handler(GdkEvent* event) {
 
         if (panning_cursor == 1) {
             panning_cursor = 0;
-            GtkWidget *w = GTK_WIDGET(this->desktop->getCanvas());
-            gdk_window_set_cursor(gtk_widget_get_window (w), this->cursor);
+            Gtk::Widget* w = Glib::wrap(GTK_WIDGET(desktop->getCanvas()));
+            w->get_window()->set_cursor(cursor);
         }
 
         if (within_tolerance && (panning || zoom_rb)) {
@@ -755,8 +746,8 @@ bool ToolBase::root_handler(GdkEvent* event) {
 
         if (panning_cursor == 1) {
             panning_cursor = 0;
-            GtkWidget *w = GTK_WIDGET(this->desktop->getCanvas());
-            gdk_window_set_cursor(gtk_widget_get_window (w), this->cursor);
+            Gtk::Widget* w = Glib::wrap(GTK_WIDGET(desktop->getCanvas()));
+            w->get_window()->set_cursor(cursor);
         }
 
         switch (get_latin_keyval(&event->key)) {
diff --git a/src/ui/tools/tool-base.h b/src/ui/tools/tool-base.h
index 7185b787e..e7b0d0155 100644
--- a/src/ui/tools/tool-base.h
+++ b/src/ui/tools/tool-base.h
@@ -18,6 +18,7 @@
 #include "knotholder.h"
 #include <2geom/point.h>
 #include <gdk/gdk.h>
+#include <gdkmm/cursor.h>
 #include <glib-object.h>
 #include <sigc++/trackable.h>
 
@@ -150,7 +151,7 @@ public:
     virtual ~ToolBase();
 
     Inkscape::Preferences::Observer *pref_observer;
-    GdkCursor *cursor;
+    Glib::RefPtr<Gdk::Cursor> cursor;
 
     gint xp, yp;           ///< where drag started
     gint tolerance;