diff options
| author | Johan B. C. Engelen <jbc.engelen@swissonline.ch> | 2014-02-24 20:28:00 +0000 |
|---|---|---|
| committer | Johan B. C. Engelen <j.b.c.engelen@alumnus.utwente.nl> | 2014-02-24 20:28:00 +0000 |
| commit | 0917cc6ed7207c0535360dd757705bda30410a47 (patch) | |
| tree | e5fb95180647564cfd693c5b364b98b2d67ad361 /src | |
| parent | Set the order of resize handles back to what they were before r12400. Now it'... (diff) | |
| download | inkscape-0917cc6ed7207c0535360dd757705bda30410a47.tar.gz inkscape-0917cc6ed7207c0535360dd757705bda30410a47.zip | |
Fix infinite loop (?) by disabling saving the order of filters when they are reordered by drag&drop in the filter editor dialog. (bug 1239296)
Fixed bugs:
- https://launchpad.net/bugs/1239296
(bzr r13055)
Diffstat (limited to 'src')
| -rw-r--r-- | src/ui/dialog/filter-effects-dialog.cpp | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/src/ui/dialog/filter-effects-dialog.cpp b/src/ui/dialog/filter-effects-dialog.cpp index 6a3a4c3f1..e8b09db8b 100644 --- a/src/ui/dialog/filter-effects-dialog.cpp +++ b/src/ui/dialog/filter-effects-dialog.cpp @@ -1515,11 +1515,16 @@ void FilterEffectsDialog::FilterModifier::on_name_edited(const Glib::ustring& pa } void FilterEffectsDialog::FilterModifier::on_filter_reorder(const Gtk::TreeModel::Path& /*path*/) { +/* The code below is bugged. Use of "object->getRepr()->setPosition(0)" is dangerous! + Writing back the reordered list to XML (reordering XML nodes) should be implemented differently. + Note that the dialog does also not update its list of filters when the order is manually changed + using the XML dialog for(Gtk::TreeModel::iterator i = _model->children().begin(); i != _model->children().end(); ++i) { SPObject* object = (*i)[_columns.filter]; - if(object && object->getRepr()) + if(object && object->getRepr()) ; object->getRepr()->setPosition(0); } +*/ } void FilterEffectsDialog::FilterModifier::on_selection_toggled(const Glib::ustring& path) |