Initialize some uninitialized variables

8 files changed, 13 insertions, 5 deletions

diff --git a/src/text-editing.cpp b/src/text-editing.cpp
index ab2ddd25d..45afcb653 100644
--- a/src/text-editing.cpp
+++ b/src/text-editing.cpp
@@ -128,7 +128,7 @@ sp_te_get_cursor_coords (SPItem const *item, Inkscape::Text::Layout::iterator co
     Inkscape::Text::Layout const *layout = te_get_layout(item);
     double height, rotation;
     layout->queryCursorShape(position, p0, height, rotation);
-    p1 = Geom::Point(p0[Geom::X] + height * sin(rotation), p0[Geom::Y] - height * cos(rotation));
+    p1 = Geom::Point(p0[Geom::X] + height * sin(rotation), p0[Geom::Y] - height * cos(rotation)); // valgrind warns that rotation is not initialized here. Why is to be seen in queryCursorShape
 }
 
 SPStyle const * sp_te_style_at_position(SPItem const *text, Inkscape::Text::Layout::iterator const &position)
diff --git a/src/ui/control-manager.cpp b/src/ui/control-manager.cpp
index 153799f2a..4aa061a7e 100644
--- a/src/ui/control-manager.cpp
+++ b/src/ui/control-manager.cpp
@@ -400,6 +400,7 @@ SPCtrlLine *ControlManager::createControlLine(SPCanvasGroup *parent, CtrlLineTyp
 
         line->setRgba32((type == CTLINE_PRIMARY) ? LINE_COLOR_PRIMARY :
                         (type == CTLINE_SECONDARY) ? LINE_COLOR_SECONDARY : LINE_COLOR_TERTIARY);
+        line->setCoords(0, 0, 0, 0);
     }
     return line;
 }
diff --git a/src/ui/toolbar/box3d-toolbar.cpp b/src/ui/toolbar/box3d-toolbar.cpp
index 527e375c9..8f1427755 100644
--- a/src/ui/toolbar/box3d-toolbar.cpp
+++ b/src/ui/toolbar/box3d-toolbar.cpp
@@ -63,7 +63,8 @@ namespace UI {
 namespace Toolbar {
 Box3DToolbar::Box3DToolbar(SPDesktop *desktop)
         : Toolbar(desktop),
-        _repr(nullptr)
+        _repr(nullptr),
+        _freeze(false)
 {
     auto prefs      = Inkscape::Preferences::get();
     auto document   = desktop->getDocument();
diff --git a/src/ui/toolbar/star-toolbar.cpp b/src/ui/toolbar/star-toolbar.cpp
index b0c585a5a..b7d59125b 100644
--- a/src/ui/toolbar/star-toolbar.cpp
+++ b/src/ui/toolbar/star-toolbar.cpp
@@ -65,7 +65,8 @@ namespace Toolbar {
 StarToolbar::StarToolbar(SPDesktop *desktop) :
     Toolbar(desktop),
     _mode_item(Gtk::manage(new UI::Widget::LabelToolItem(_("<b>New:</b>")))),
-    _repr(nullptr)
+    _repr(nullptr),
+    _freeze(false)
 {
     _mode_item->set_use_markup(true);
     add(*_mode_item);
diff --git a/src/ui/toolbar/text-toolbar.cpp b/src/ui/toolbar/text-toolbar.cpp
index 0145a01c4..8ca6be1ec 100644
--- a/src/ui/toolbar/text-toolbar.cpp
+++ b/src/ui/toolbar/text-toolbar.cpp
@@ -218,6 +218,8 @@ TextToolbar::TextToolbar(SPDesktop *desktop)
     , _tracker(new UnitTracker(Inkscape::Util::UNIT_TYPE_LINEAR))
     , _tracker_fs(new UnitTracker(Inkscape::Util::UNIT_TYPE_LINEAR))
     , _cusor_numbers(0)
+    , _updating(false)
+    , _text_style_from_prefs(false)
 {
     /* Line height unit tracker */
     _tracker->prependUnit(unit_table.getUnit("")); // Ratio
diff --git a/src/ui/widget/combo-tool-item.cpp b/src/ui/widget/combo-tool-item.cpp
index e9eee059d..205c17cdd 100644
--- a/src/ui/widget/combo-tool-item.cpp
+++ b/src/ui/widget/combo-tool-item.cpp
@@ -55,7 +55,8 @@ ComboToolItem::ComboToolItem(Glib::ustring group_label,
     _use_pixbuf (true),
     _icon_size ( Gtk::ICON_SIZE_LARGE_TOOLBAR ),
     _combobox (nullptr),
-    _menuitem (nullptr)
+    _menuitem (nullptr),
+    _use_group_label(false)
 {
     Gtk::Box* box = Gtk::manage(new Gtk::Box());
     add(*box);
diff --git a/src/ui/widget/ink-ruler.cpp b/src/ui/widget/ink-ruler.cpp
index 40f189bf4..3bb117a95 100644
--- a/src/ui/widget/ink-ruler.cpp
+++ b/src/ui/widget/ink-ruler.cpp
@@ -51,6 +51,7 @@ Ruler::Ruler(Gtk::Orientation orientation)
     , _unit(nullptr)
     , _backing_store_valid(false)
     , _rect()
+    , _position(0)
 {
     set_name("InkRuler");
 
diff --git a/src/ui/widget/preview.cpp b/src/ui/widget/preview.cpp
index 2de9a9a28..a56639c43 100644
--- a/src/ui/widget/preview.cpp
+++ b/src/ui/widget/preview.cpp
@@ -469,7 +469,8 @@ Preview::Preview()
       _ratio(100),
       _border(BORDER_NONE),
       _previewPixbuf(nullptr),
-      _scaled(nullptr)
+      _scaled(nullptr),
+      _linked(PREVIEW_LINK_NONE)
 {
     set_can_focus(true);
     set_receives_default(true);