LPE widget refactor. Improvement to not update on same value

(bzr r15665)

7 files changed, 19 insertions, 5 deletions

diff --git a/src/live_effects/parameter/bool.cpp b/src/live_effects/parameter/bool.cpp
index 9cb91bdd6..3184bfa80 100644
--- a/src/live_effects/parameter/bool.cpp
+++ b/src/live_effects/parameter/bool.cpp
@@ -87,7 +87,9 @@ BoolParam::param_newWidget()
 void
 BoolParam::param_setValue(bool newvalue)
 {
-    param_effect->upd_params = true;
+    if (value != newvalue) {
+        param_effect->upd_params = true;
+    }
     value = newvalue;
 }
 
diff --git a/src/live_effects/parameter/enum.h b/src/live_effects/parameter/enum.h
index 6cadd6953..78fa87a4f 100644
--- a/src/live_effects/parameter/enum.h
+++ b/src/live_effects/parameter/enum.h
@@ -86,7 +86,9 @@ public:
     }
     
     void param_set_value(E val) {
-        param_effect->upd_params = true;
+        if (value != val) {
+            param_effect->upd_params = true;
+        }
         value = val;
     }
 
diff --git a/src/live_effects/parameter/fontbutton.cpp b/src/live_effects/parameter/fontbutton.cpp
index 5add69c1d..ca8908f0e 100644
--- a/src/live_effects/parameter/fontbutton.cpp
+++ b/src/live_effects/parameter/fontbutton.cpp
@@ -74,7 +74,9 @@ FontButtonParam::param_newWidget()
 void
 FontButtonParam::param_setValue(const Glib::ustring newvalue)
 {
-    param_effect->upd_params = true;
+    if (value != newvalue) {
+        param_effect->upd_params = true;
+    }
     value = newvalue;
 }
 
diff --git a/src/live_effects/parameter/parameter.cpp b/src/live_effects/parameter/parameter.cpp
index 1c1063960..45f46a0a7 100644
--- a/src/live_effects/parameter/parameter.cpp
+++ b/src/live_effects/parameter/parameter.cpp
@@ -121,7 +121,9 @@ ScalarParam::param_update_default(const gchar * default_value)
 void
 ScalarParam::param_set_value(gdouble val)
 {
-    param_effect->upd_params = true;
+    if (value != val) {
+        param_effect->upd_params = true;
+    }
     value = val;
     if (integer)
         value = round(value);
diff --git a/src/live_effects/parameter/random.cpp b/src/live_effects/parameter/random.cpp
index 90e53ca0e..b1375adda 100644
--- a/src/live_effects/parameter/random.cpp
+++ b/src/live_effects/parameter/random.cpp
@@ -94,6 +94,7 @@ RandomParam::param_update_default(const gchar * default_value){
 void
 RandomParam::param_set_value(gdouble val, long newseed)
 {
+    param_effect->upd_params = true;
     value = val;
     if (integer)
         value = round(value);
diff --git a/src/live_effects/parameter/text.cpp b/src/live_effects/parameter/text.cpp
index 4062a4dc7..d633666aa 100644
--- a/src/live_effects/parameter/text.cpp
+++ b/src/live_effects/parameter/text.cpp
@@ -131,6 +131,9 @@ TextParam::param_newWidget()
 void
 TextParam::param_setValue(const Glib::ustring newvalue)
 {
+    if (value != newvalue) {
+        param_effect->upd_params = true;
+    }
     value = newvalue;
     if (!_hide_canvas_text) {
         sp_canvastext_set_text (canvas_text, newvalue.c_str());
diff --git a/src/live_effects/parameter/togglebutton.cpp b/src/live_effects/parameter/togglebutton.cpp
index 9eb89fea5..eb40a7e41 100644
--- a/src/live_effects/parameter/togglebutton.cpp
+++ b/src/live_effects/parameter/togglebutton.cpp
@@ -164,7 +164,9 @@ ToggleButtonParam::refresh_button()
 void
 ToggleButtonParam::param_setValue(bool newvalue)
 {
-    param_effect->upd_params = true;
+    if (value != newvalue) {
+        param_effect->upd_params = true;
+    }
     value = newvalue;
     refresh_button();
 }