diff options
| author | Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> | 2018-06-18 16:54:54 +0000 |
|---|---|---|
| committer | Emmanuel Gil Peyrot <linkmauve@linkmauve.fr> | 2018-06-18 18:27:11 +0000 |
| commit | 571f36f1b61d316a2f2ace00fa94ba83ab1ac0a0 (patch) | |
| tree | 95696a57d31908e2d5b5853b4c84e3d53c700db1 /src/preferences.cpp | |
| parent | Update pdf-parser.cpp (diff) | |
| download | inkscape-571f36f1b61d316a2f2ace00fa94ba83ab1ac0a0.tar.gz inkscape-571f36f1b61d316a2f2ace00fa94ba83ab1ac0a0.zip | |
Run clang-tidy’s modernize-pass-by-value pass.
This avoids having to pass variables by reference before copying them
when calling a constructor.
Diffstat (limited to 'src/preferences.cpp')
| -rw-r--r-- | src/preferences.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/preferences.cpp b/src/preferences.cpp index b7242a48d..1c4951d75 100644 --- a/src/preferences.cpp +++ b/src/preferences.cpp @@ -12,6 +12,7 @@ #include <cstring> #include <sstream> +#include <utility> #include <glibmm/fileutils.h> #include <glibmm/convert.h> #include <glibmm/i18n.h> @@ -71,9 +72,9 @@ static void file_add_recent(gchar const *uri) */ class Preferences::PrefNodeObserver : public XML::NodeObserver { public: - PrefNodeObserver(Observer &o, Glib::ustring const &filter) : + PrefNodeObserver(Observer &o, Glib::ustring filter) : _observer(o), - _filter(filter) + _filter(std::move(filter)) {} ~PrefNodeObserver() override = default; void notifyAttributeChanged(XML::Node &node, GQuark name, Util::ptr_shared, Util::ptr_shared) override; @@ -551,8 +552,8 @@ public: bool _is_attr; ///< Whether this Observer watches a single attribute }; -Preferences::Observer::Observer(Glib::ustring const &path) : - observed_path(path), +Preferences::Observer::Observer(Glib::ustring path) : + observed_path(std::move(path)), _data(nullptr) { } |