diff options
| author | Kris De Gussem <kris.degussem@gmail.com> | 2012-02-04 09:05:50 +0000 |
|---|---|---|
| committer | Kris <Kris.De.Gussem@hotmail.com> | 2012-02-04 09:05:50 +0000 |
| commit | bceaaf6eacb0bf2f23cf42af5d9ee8332a08560f (patch) | |
| tree | 05cbfa9a23814f2a4f62f25e0bf78bf13c2b23bc /src/sp-filter.cpp | |
| parent | Documentation: sp-filter.h is not documented at all, removing fake explanation. (diff) | |
| download | inkscape-bceaaf6eacb0bf2f23cf42af5d9ee8332a08560f.tar.gz inkscape-bceaaf6eacb0bf2f23cf42af5d9ee8332a08560f.zip | |
cppcheck tells us: scanf without field width limits can crash with huge input data. (gimpgrad)
Some additional scanf modifications
(bzr r10932)
Diffstat (limited to 'src/sp-filter.cpp')
| -rw-r--r-- | src/sp-filter.cpp | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/sp-filter.cpp b/src/sp-filter.cpp index d0fd59802..bafd356d6 100644 --- a/src/sp-filter.cpp +++ b/src/sp-filter.cpp @@ -564,9 +564,14 @@ Glib::ustring sp_filter_get_new_result_name(SPFilter *filter) { Inkscape::XML::Node *repr = primitive_obj->getRepr(); char const *result = repr->attribute("result"); int index; - if (result && sscanf(result, "result%d", &index) == 1) { - if (index > largest) { - largest = index; + if (result) + { + if (sscanf(result, "result%d", &index) == 1) + { + if (index > largest) + { + largest = index; + } } } } |